Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-59605

Broken core.FormValidationTest#validate

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      As James has pointed out[1], the test was broken by a change I made.

      [1] https://github.com/jenkinsci/acceptance-test-harness/pull/515#discussion_r329985479

        Attachments

          Activity

          Hide
          olivergondza Oliver Gondža added a comment -

          This problem here affects javascript based validation only. The problem is that AJAX based validation will add the <div/>[1] on success, but the javascript one does not[2]. Hence there is no easy way to tell, whether there is a validation that is pending or this is a successful result of JS validation (that keeps the DOM tree untouched).

          [1] https://github.com/jenkinsci/jenkins/blob/24d0cf90ab82f89aadd2b54c84c7fcab093b0d37/core/src/main/java/hudson/util/FormValidation.java#L159
          [2] https://github.com/jenkinsci/jenkins/blob/24d0cf90ab82f89aadd2b54c84c7fcab093b0d37/war/src/main/webapp/scripts/hudson-behavior.js#L498

          Show
          olivergondza Oliver Gondža added a comment - This problem here affects javascript based validation only. The problem is that AJAX based validation will add the <div/> [1] on success, but the javascript one does not [2] . Hence there is no easy way to tell, whether there is a validation that is pending or this is a successful result of JS validation (that keeps the DOM tree untouched). [1] https://github.com/jenkinsci/jenkins/blob/24d0cf90ab82f89aadd2b54c84c7fcab093b0d37/core/src/main/java/hudson/util/FormValidation.java#L159 [2] https://github.com/jenkinsci/jenkins/blob/24d0cf90ab82f89aadd2b54c84c7fcab093b0d37/war/src/main/webapp/scripts/hudson-behavior.js#L498
          Hide
          teilo James Nord added a comment -

          I think this is now done.

          Show
          teilo James Nord added a comment - I think this is now done.

            People

            Assignee:
            olivergondza Oliver Gondža
            Reporter:
            olivergondza Oliver Gondža
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: