• Type: Bug
• Resolution: Fixed
• Priority: Major
• Component/s: acceptance-test-harness
• Labels:

  None

[JENKINS-59605] Broken core.FormValidationTest#validate

Collapse comment: Oliver Gondža added a comment - 2019-10-11 08:29

Oliver Gondža added a comment - 2019-10-11 08:29

This problem here affects javascript based validation only. The problem is that AJAX based validation will add the <div/>[1] on success, but the javascript one does not[2]. Hence there is no easy way to tell, whether there is a validation that is pending or this is a successful result of JS validation (that keeps the DOM tree untouched).

[1] https://github.com/jenkinsci/jenkins/blob/24d0cf90ab82f89aadd2b54c84c7fcab093b0d37/core/src/main/java/hudson/util/FormValidation.java#L159
[2] https://github.com/jenkinsci/jenkins/blob/24d0cf90ab82f89aadd2b54c84c7fcab093b0d37/war/src/main/webapp/scripts/hudson-behavior.js#L498

Expand comment: Oliver Gondža added a comment - 2019-10-11 08:29

Oliver Gondža added a comment - 2019-10-11 08:29 This problem here affects javascript based validation only. The problem is that AJAX based validation will add the <div/> [1] on success, but the javascript one does not [2] . Hence there is no easy way to tell, whether there is a validation that is pending or this is a successful result of JS validation (that keeps the DOM tree untouched). [1] https://github.com/jenkinsci/jenkins/blob/24d0cf90ab82f89aadd2b54c84c7fcab093b0d37/core/src/main/java/hudson/util/FormValidation.java#L159 [2] https://github.com/jenkinsci/jenkins/blob/24d0cf90ab82f89aadd2b54c84c7fcab093b0d37/war/src/main/webapp/scripts/hudson-behavior.js#L498

Collapse comment: James Nord added a comment - 2021-03-04 11:16

James Nord added a comment - 2021-03-04 11:16

I think this is now done.

Expand comment: James Nord added a comment - 2021-03-04 11:16

James Nord added a comment - 2021-03-04 11:16 I think this is now done.