Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-59631

Adding different colors to history table and data filter

    XMLWordPrintable

Details

    • Jenkins 2.105

    Description

      When I start or refresh a job page, the build history alternating colors start with white on the filter textbox, then grey/white/grey/white for the builds. Also, after using the filter box, or even clearing an already empty filter, the colors clashe with the filter textbox having grey, and them white/grey/white/grey for the builds. It seems that color alteration are not in the right order

      It is an inconsequential issue as the rest of page and features work very well.

      I think there are some minor issues with html element rendering.

      Attachments

        Activity

          danielbeck Daniel Beck added a comment -

          Re the files, they're a fairly convoluted mess. https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/hudson/widgets/HistoryWidget/index.jelly is probably the best starting point. https://github.com/jenkinsci/jenkins/blob/ef85b89323d4ecb69f96bb2da80282a5a19e2fa4/war/src/main/webapp/scripts/hudson-behavior.js#L1937-L2158 seems to be related JS.

          I agree that approach 2 seems superior. Alternatively we could remove tbody (assuming no negative side effects) if it's easier to do, at least then there would be consistency between initial and updated UI.

          danielbeck Daniel Beck added a comment - Re the files, they're a fairly convoluted mess. https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/hudson/widgets/HistoryWidget/index.jelly is probably the best starting point. https://github.com/jenkinsci/jenkins/blob/ef85b89323d4ecb69f96bb2da80282a5a19e2fa4/war/src/main/webapp/scripts/hudson-behavior.js#L1937-L2158 seems to be related JS. I agree that approach 2 seems superior. Alternatively we could remove tbody (assuming no negative side effects) if it's easier to do, at least then there would be consistency between initial and updated UI.

          I will have a look on this and send a PR soon

          kalana Kalana Wijethunga added a comment - I will have a look on this and send a PR soon

          danielbeck the tbody tag is automatically created with the pane.jelly used in the HistoryWidget component. So I believe removing the tbody tag is not an option as it might have adverse effects if this component is used in somewhere else. Its hard to guarantee that updating the JS won't affect somewhere else as well. 

          So shall we go with option 1? This will fix if there are any inconsistencies in the other tables as well and it looks to me that it is the least harmful option as it is less likely to cause any damage to other components.

          kalana Kalana Wijethunga added a comment - danielbeck the tbody tag is automatically created with the pane.jelly used in the HistoryWidget component. So I believe removing the tbody tag is not an option as it might have adverse effects if this component is used in somewhere else. Its hard to guarantee that updating the JS won't affect somewhere else as well.  So shall we go with option 1? This will fix if there are any inconsistencies in the other tables as well and it looks to me that it is the least harmful option as it is less likely to cause any damage to other components.

          Can we take a decision on this so that we can have a fix and close this issue?

          kalana Kalana Wijethunga added a comment - Can we take a decision on this so that we can have a fix and close this issue?

          Please find the link to the PR below

          https://github.com/jenkinsci/jenkins/pull/4342

          kalana Kalana Wijethunga added a comment - Please find the link to the PR below https://github.com/jenkinsci/jenkins/pull/4342

          People

            kalana Kalana Wijethunga
            mattumd Matt Zand
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: