• cloudbees-jenkins-advisor-2.11

      While testing the plugin I found various small improvements to do to improve a bit the user experience:

      1. Logs are showing that the upload task is starting/finishing while it does nothing (because TOS aren't accepted for example). It's confusing and could let think that an upload happens which isn't the case
      Oct 03, 2019 3:17:55 PM hudson.model.AsyncPeriodicWork$1 run
      INFO: Started Bundle Upload
      Oct 03, 2019 3:17:55 PM hudson.model.AsyncPeriodicWork$1 run
      INFO: Finished Bundle Upload. 1 ms
      1. The configuration screen could be improved a bit by just reordering some fields (it's confusing to accept the TOS at the bottom of the form while it it is the most important setting. Without accepting the TOS nothing happens)
      2. Few messages / sentences could be improved

          [JENKINS-59648] UX improvements

          example of logs with the change :

          Oct 03, 2019 6:59:12 PM hudson.model.AsyncPeriodicWork$1 run
          INFO: Started Bundle Upload
          Oct 03, 2019 6:59:12 PM com.cloudbees.jenkins.plugins.advisor.BundleUpload log
          INFO: User not registered. Skipping bundle upload.
          Oct 03, 2019 6:59:12 PM hudson.model.AsyncPeriodicWork$1 run
          INFO: Finished Bundle Upload. 1 ms

          ^^ The message will be updated (there is no notion of users registration today)

          or

          Oct 03, 2019 7:05:29 PM hudson.model.AsyncPeriodicWork$1 run
          INFO: Started Bundle Upload
          Oct 03, 2019 7:05:29 PM com.cloudbees.jenkins.plugins.advisor.BundleUpload log
          INFO: User not registered. Skipping bundle upload.
          Oct 03, 2019 7:05:29 PM hudson.model.AsyncPeriodicWork$1 run
          INFO: Finished Bundle Upload. 1 ms

           

          Arnaud Héritier added a comment - example of logs with the change : Oct 03, 2019 6:59:12 PM hudson.model.AsyncPeriodicWork$1 run INFO: Started Bundle Upload Oct 03, 2019 6:59:12 PM com.cloudbees.jenkins.plugins.advisor.BundleUpload log INFO: User not registered. Skipping bundle upload. Oct 03, 2019 6:59:12 PM hudson.model.AsyncPeriodicWork$1 run INFO: Finished Bundle Upload. 1 ms ^^ The message will be updated (there is no notion of users registration today) or Oct 03, 2019 7:05:29 PM hudson.model.AsyncPeriodicWork$1 run INFO: Started Bundle Upload Oct 03, 2019 7:05:29 PM com.cloudbees.jenkins.plugins.advisor.BundleUpload log INFO: User not registered. Skipping bundle upload. Oct 03, 2019 7:05:29 PM hudson.model.AsyncPeriodicWork$1 run INFO: Finished Bundle Upload. 1 ms  

          UI Before:

          UI After:

          Arnaud Héritier added a comment - UI Before: UI After:

          Arnaud Héritier added a comment - PR:  https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/pull/37

          Screenshots with 2.138.4

          cc recampbell / pkthunda

          Arnaud Héritier added a comment - Screenshots with 2.138.4 cc recampbell / pkthunda

            aheritier Arnaud Héritier
            aheritier Arnaud Héritier
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: