Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-60694

JellyTestSuite fails with timeout issue on Windows runner because it uses HudsonTestCase instead of JenkinsRule

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • jenkins-test-harness
    • None
    • Windows agent on kubernetes
      jenkins-test-harness-2.57 and above with jetty version greater than 9.4.6.v20170531
    • jenkins-test-harness 2.60, plugin 3.56

      The test class TestInjection generated by maven-hpi-plugin fails to run the test suite with a timeout exception when updating jenkins-test-harness from 2.56 to 2.57 on Windows agent.

      The same mvn install command run on a Linux agent run fine.

      After investigation, the reason is that JellyTestSuite is based on HudsonTestCase, and HudsonTestCase does not work on the Windows agent with a jetty above 9.4.6.v20170531.

      Between jenkins-test-harness-2:56 and jenkins-test-harness:2.57 jetty version has changed from 9.4.5.v20170502 to 9.4.22.v20191022.

      Setting jetty version to 9.4.6.v20170531 in maven dependencies with jenkins-test-harness:2.57 (and above) solve the issue.

      JellyTestSuiteBuilder should be updated to use JenkinsRule and not the deprecated HudsonTestCase.

      https://github.com/jenkinsci/jenkins-test-harness/blob/0e0ec3c9ccbe6314d488faa248e2f50f312f3cad/src/main/java/org/jvnet/hudson/test/JellyTestSuiteBuilder.java#L138

      Link to maven-hpi-plugin code that generate the TestInjection class:
      https://github.com/jenkinsci/maven-hpi-plugin/blob/master/src/main/java/org/jenkinsci/maven/plugins/hpi/TestInsertionMojo.java

          [JENKINS-60694] JellyTestSuite fails with timeout issue on Windows runner because it uses HudsonTestCase instead of JenkinsRule

          A. Jard created issue -
          Jesse Glick made changes -
          Assignee Original: Oliver Gondža [ olivergondza ]

          James Nord added a comment -

          9.4.5.v20170502 -> pass

          9.4.5.v20180619 -> fail

          from the commits between v20170502  and v20180619  and (https://github.com/eclipse/jetty.project/commits/jetty-9.4.5.v20180619https://github.com/eclipse/jetty.project/pull/2102 looks like the prime suspect as everything else looks like a bit of build fluff

          James Nord added a comment - 9.4.5.v20170502 -> pass 9.4.5.v20180619 -> fail from the commits between v20170502   and v20180619   and ( https://github.com/eclipse/jetty.project/commits/jetty-9.4.5.v20180619 )  https://github.com/eclipse/jetty.project/pull/2102  looks like the prime suspect as everything else looks like a bit of build fluff
          James Nord made changes -
          Assignee New: James Nord [ teilo ]
          Jesse Glick made changes -
          Assignee Original: James Nord [ teilo ] New: Jesse Glick [ jglick ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "jenkins-test-harness #193 (Web Link)" [ 24304 ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Jesse Glick made changes -
          Link New: This issue is duplicated by JENKINS-60754 [ JENKINS-60754 ]
          Jesse Glick made changes -
          Released As New: jenkins-test-harness 2.60
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Fixed but Unreleased [ 10203 ]

            jglick Jesse Glick
            ajard A. Jard
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: