Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-60821

Check and update any Jetty code with custom threadpool

    XMLWordPrintable

Details

    • Jenkins 2.218

    Description

      As per Jetty Issue#4492 which was created to report the failure to process requests we have been told that our code is wrong.

      Jesse Glick ​verified the fix in cloudbees-workflow-template-plugin#9 commit 0c4eb98d

      We need to

      • see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔
      • make sure other uses of Jetty in Jenkins are safe
      • winstone ✔
      • maven-hpi-plugin (run mojoe etc) ✔

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-60857 Wildcard certificates rejected by Winstone after Jetty update

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          is caused by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-60694 JellyTestSuite fails with timeout issue on Windows runner because it uses HudsonTestCase instead of JenkinsRule

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link jenkins-test-harness PR#197

          Web Link winstone PR#90

          Activity

            Ascending order - Click to sort in descending order
            teilo James Nord added a comment -

            removing the thread naming means the threadpool uses threads starting with "qtp" rather than "Jetty Thread Pool"

            teilo James Nord added a comment - removing the thread naming means the threadpool uses threads starting with "qtp" rather than "Jetty Thread Pool"
            teilo James Nord added a comment -

            maven-hpi-plugin seems unaffected

            winstone allows for configuration of the acceptors and selectors and the max # threads (which by default uses Jetty defaults)

            teilo James Nord added a comment - maven-hpi-plugin seems unaffected winstone allows for configuration of the acceptors and selectors and the max # threads (which by default uses Jetty defaults )
            oleg_nenashev Oleg Nenashev added a comment -

            teilo Winstone fix was shipped in 2.218. Do we need to keep this issue open?

            oleg_nenashev Oleg Nenashev added a comment - teilo Winstone fix was shipped in 2.218. Do we need to keep this issue open?
            teilo James Nord added a comment -

            Jenkins test harness has not been released yet but happy to close as it's been merged, just not sure on the process for jth

            teilo James Nord added a comment - Jenkins test harness has not been released yet but happy to close as it's been merged, just not sure on the process for jth
            oleg_nenashev Oleg Nenashev added a comment -

            I will cut the Jetty release

            oleg_nenashev Oleg Nenashev added a comment - I will cut the Jetty release
            recena Manuel Recena Soto added a comment -

            The links provided in the issue description are broken. I assume they are private links.

            According to the CHANGELOG, we are able to update the status of this issue. It is already released.

            recena Manuel Recena Soto added a comment - The links provided in the issue description are broken. I assume they are private links. According to the CHANGELOG , we are able to update the status of this issue. It is already released.
            teilo James Nord added a comment -

            the link to jetty issue is public. the verification was a private repo

            teilo James Nord added a comment - the link to jetty issue is public. the verification was a private repo

            People

              Unassigned Unassigned
              teilo James Nord
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: