Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-60821

Check and update any Jetty code with custom threadpool

    • Jenkins 2.218

      As per Jetty Issue#4492 which was created to report the failure to process requests we have been told that our code is wrong.

      Jesse Glick ​verified the fix in cloudbees-workflow-template-plugin#9 commit 0c4eb98d

      We need to

      • see if we can remove the custom thread pools from `jenkins-test-harness` (it only is used to set the name of the Thread) ✔
      • make sure other uses of Jetty in Jenkins are safe
      • winstone ✔
      • maven-hpi-plugin (run mojoe etc) ✔

          [JENKINS-60821] Check and update any Jetty code with custom threadpool

          James Nord added a comment -

          removing the thread naming means the threadpool uses threads starting with "qtp" rather than "Jetty Thread Pool"

          James Nord added a comment - removing the thread naming means the threadpool uses threads starting with "qtp" rather than "Jetty Thread Pool"

          James Nord added a comment -

          maven-hpi-plugin seems unaffected

          winstone allows for configuration of the acceptors and selectors and the max # threads (which by default uses Jetty defaults)

          James Nord added a comment - maven-hpi-plugin seems unaffected winstone allows for configuration of the acceptors and selectors and the max # threads (which by default uses Jetty defaults )

          Oleg Nenashev added a comment -

          teilo Winstone fix was shipped in 2.218. Do we need to keep this issue open?

          Oleg Nenashev added a comment - teilo Winstone fix was shipped in 2.218. Do we need to keep this issue open?

          James Nord added a comment -

          Jenkins test harness has not been released yet but happy to close as it's been merged, just not sure on the process for jth

          James Nord added a comment - Jenkins test harness has not been released yet but happy to close as it's been merged, just not sure on the process for jth

          Oleg Nenashev added a comment -

          I will cut the Jetty release

          Oleg Nenashev added a comment - I will cut the Jetty release

          The links provided in the issue description are broken. I assume they are private links.

          According to the CHANGELOG, we are able to update the status of this issue. It is already released.

          Manuel Recena Soto added a comment - The links provided in the issue description are broken. I assume they are private links. According to the CHANGELOG , we are able to update the status of this issue. It is already released.

          James Nord added a comment -

          the link to jetty issue is public. the verification was a private repo

          James Nord added a comment - the link to jetty issue is public. the verification was a private repo

            Unassigned Unassigned
            teilo James Nord
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: