[JENKINS-61463] PipelineJob trigger deprecation, migration error

Type: Bug
Resolution: Fixed
Priority: Minor
Component/s: job-dsl-plugin
Labels:
None
Environment:
Jenkins LTS 2.204.5, job-dsl-plugin 1.77, pipeline job 2.37

Similar Issues:
Powered by SuggestiMate

Show
Released As:
job-dsl-plugin 1.78

Migration page for 1.77 deprecates pipeline trigger, so trying to migrate to new syntax.

Change my jobs from:
triggers {
cron('@daily')
}

To:
properties {
pipelineTriggers {
triggers

{ cron('@daily') }

}
}

DSL processing now fails with:
13:02:42 ERROR: (fullbyacct.groovy, line 8) No signature of method: javaposse.jobdsl.plugin.structs.DescribableListContext.cron() is applicable for argument types: (java.lang.String) values: [@daily]
13:02:42 Possible solutions: grep(), print(java.io.PrintWriter), print(java.lang.Object), grep(java.lang.Object), wait(), find()

Am I missing something?

relates to

JENKINS-63119 triggers is deprecated -> UNSTABLE build

Fixed but Unreleased

Oliver Gondža added a comment - 2020-05-25 08:51

daspilker, it seems the `pipelineTriggers` is not part of reference documentation: https://jenkinsci.github.io/job-dsl-plugin/#path/javaposse.jobdsl.dsl.DslFactory.pipelineJob-properties. It works correctly for the Jenkins "live" reference doc

Oliver Gondža added a comment - 2020-05-25 08:51 daspilker , it seems the `pipelineTriggers` is not part of reference documentation: https://jenkinsci.github.io/job-dsl-plugin/#path/javaposse.jobdsl.dsl.DslFactory.pipelineJob-properties. It works correctly for the Jenkins "live" reference doc

Gnanasekaran Gajendiran added a comment - 2020-06-25 07:54

Same issue for Bitbucket server as well

properties {
    pipelineTriggers {
        triggers {
            bitbucketTriggers {
                repositoryServerPushAction(false, false, "")
                pullRequestServerMergedAction()
            }
        }
    }
}

Gnanasekaran Gajendiran added a comment - 2020-06-25 07:54 Same issue for Bitbucket server as well properties { pipelineTriggers { triggers { bitbucketTriggers { repositoryServerPushAction( false , false , "") pullRequestServerMergedAction() } } } }

Daniel Spilker added a comment - 2020-07-15 17:49

olivergondza "pipelineTriggers" is provided by Dynamic DSL, which is not shown in the static API viewer. Use the API viewer in your Jenkins installation. See https://github.com/jenkinsci/job-dsl-plugin/wiki/Dynamic-DSL.

Daniel Spilker added a comment - 2020-07-15 17:49 olivergondza "pipelineTriggers" is provided by Dynamic DSL, which is not shown in the static API viewer. Use the API viewer in your Jenkins installation. See https://github.com/jenkinsci/job-dsl-plugin/wiki/Dynamic-DSL .

Daniel Spilker added a comment - 2020-07-15 17:53

Can someone provide a complete but minimal DSL script that reproduces the problem? Please also mention the minimal set of plugins that need to be installed.

Daniel Spilker added a comment - 2020-07-15 17:53 Can someone provide a complete but minimal DSL script that reproduces the problem? Please also mention the minimal set of plugins that need to be installed.

Gnanasekaran Gajendiran added a comment - 2020-07-20 01:05 - edited

daspilker Thanks. This works fine.

pipelineJob ("TestJob") {
    properties {
        pipelineTriggers {
            triggers {
                pollSCM {
                    scmpoll_spec('')
                }
            }
        }
    }
    definition {
        cps {
            sandbox(true)
            script("testPipeline()")
        }
    }
}

Let me try for the Bitbucket comment-393252

Gnanasekaran Gajendiran added a comment - 2020-07-20 01:05 - edited daspilker Thanks. This works fine. pipelineJob ( "TestJob" ) { properties { pipelineTriggers { triggers { pollSCM { scmpoll_spec('') } } } } definition { cps { sandbox( true ) script( "testPipeline()" ) } } } Let me try for the Bitbucket comment-393252

Gnanasekaran Gajendiran added a comment - 2020-07-20 01:36 - edited

daspilker, For bitbucket-push-and-pull-request-plugin below one works

pipelineJob ("TestJob") {
    triggers{
        bitbucketTriggers {
            pullRequestCreatedAction()
        }
    }
    definition {
        cps {
            sandbox(true)
            script("createBranchJobAll()")
        }
    }
}

but not this one

pipelineJob ("TestJob") {
    properties {
        pipelineTriggers {
            triggers {
                bitbucketTrigger {
                    triggers {
                        bitBucketPPRPullRequestServerTriggerFilter {
                            actionFilter {
                                bitBucketPPRPullRequestServerMergedActionFilter{
                                    allowedBranches('master')
                                    isToApprove(false)
                                }
                            }
                        }
                    }
                }
            }
        }
    }
    definition {
        cps {
            sandbox(true)
            script("cicdPipeline()")
        }
    }
}

reference syntax

Plugin required: bitbucket-push-and-pull-request-plugin

Gnanasekaran Gajendiran added a comment - 2020-07-20 01:36 - edited daspilker , For bitbucket-push-and-pull-request-plugin below one works pipelineJob ( "TestJob" ) { triggers{ bitbucketTriggers { pullRequestCreatedAction() } } definition { cps { sandbox( true ) script( "createBranchJobAll()" ) } } } but not this one pipelineJob ( "TestJob" ) { properties { pipelineTriggers { triggers { bitbucketTrigger { triggers { bitBucketPPRPullRequestServerTriggerFilter { actionFilter { bitBucketPPRPullRequestServerMergedActionFilter{ allowedBranches( 'master' ) isToApprove( false ) } } } } } } } } definition { cps { sandbox( true ) script( "cicdPipeline()" ) } } } reference syntax Plugin required: bitbucket-push-and-pull-request-plugin

Jean-Martin Archer added a comment - 2020-09-14 18:12

We are also experiencing the same issue with `cron(...)`. Our workaround is to use the deprecated way.

Jean-Martin Archer added a comment - 2020-09-14 18:12 We are also experiencing the same issue with `cron(...)`. Our workaround is to use the deprecated way.

Lukas Bednar added a comment - 2021-05-03 14:32 - edited

We are experiencing the same for gitlab, gerrit trigger and URL Trigger.

pipelineJob ("TestJob") {
    properties {
        pipelineTriggers {
            triggers {
                gitlab {
                    triggerOnMergeRequest(true)
                    triggerOnPush(false)
                }
            }
        }
    }
}

pipelineJob ("TestJob") {
    properties {
        pipelineTriggers {
            triggers {
                gerrit {
                    triggerOnEvents {
                        patchsetCreated()
                        draftPublished()
                        changeRestored()
                    }
                    gerritProjects {
                        gerritProject {
                            pattern('my-project')
                            branches {
                                branch {
                                    compareType('reg_exp')
                                    pattern('.*')
                                }
                            }
                        }
                    }
                }
            }
        }
    }
}

Lukas Bednar added a comment - 2021-05-03 14:32 - edited We are experiencing the same for gitlab, gerrit trigger and URL Trigger. pipelineJob ( "TestJob" ) { properties { pipelineTriggers { triggers { gitlab { triggerOnMergeRequest( true ) triggerOnPush( false ) } } } } } pipelineJob ( "TestJob" ) { properties { pipelineTriggers { triggers { gerrit { triggerOnEvents { patchsetCreated() draftPublished() changeRestored() } gerritProjects { gerritProject { pattern( 'my-project' ) branches { branch { compareType( 'reg_exp' ) pattern( '.*' ) } } } } } } } } }

robbin added a comment - 2021-07-05 14:57

Hi,
I'm also migrating to the new syntax but I can figure out why I keep getting this error:

javaposse.jobdsl.dsl.DslScriptException: (script, line 3) No signature of method: javaposse.jobdsl.dsl.helpers.properties.PropertiesContext.pipelineTriggers() is applicable for argument types: (script$_run_closure1$_closure2$_closure4) values: [script$_run_closure1$_closure2$_closure4@16f6b021]

pipelineJob ("TestJob") { 
properties { 
      pipelineTriggers { 
          triggers { 
               pollSCM { 
                   scmpoll_spec('') 
               } 
          } 
     } 
} 
definition { cps { sandbox(true) script("testPipeline()") } } }

ggnanasekaran77 I used your example.
I'm using job_dsl V1.77.

Any idea? thx in advance!

robbin added a comment - 2021-07-05 14:57 Hi, I'm also migrating to the new syntax but I can figure out why I keep getting this error: javaposse.jobdsl.dsl.DslScriptException: (script, line 3) No signature of method: javaposse.jobdsl.dsl.helpers.properties.PropertiesContext.pipelineTriggers() is applicable for argument types: (script$_run_closure1$_closure2$_closure4) values: [script$_run_closure1$_closure2$_closure4@16f6b021] pipelineJob ( "TestJob" ) { properties { pipelineTriggers { triggers { pollSCM { scmpoll_spec('') } } } } definition { cps { sandbox( true ) script( "testPipeline()" ) } } } ggnanasekaran77 I used your example. I'm using job_dsl V1.77. Any idea? thx in advance!

Parvesh Mourya added a comment - 2022-03-14 15:03 - edited

robbinvandamme: check the API for your jenkins installation and see if you are able to find this method under 'freeStyleJob' -> 'triggers' -> 'pollSCM' .

The complete API reference is available in your Jenkins installation at https://your.jenkins.installation/plugin/job-dsl/api-viewer/index.html.

Parvesh Mourya added a comment - 2022-03-14 15:03 - edited robbinvandamme : check the API for your jenkins installation and see if you are able to find this method under 'freeStyleJob' -> 'triggers' -> 'pollSCM' . The complete API reference is available in your Jenkins installation at https://your.jenkins.installation/plugin/job-dsl/api-viewer/index.html .

Assignee:: Jamie Tanna

Reporter:: Alan Sparks

Votes:: 6 Vote for this issue

Watchers:: 14 Start watching this issue

Created:: 2020-03-12 19:20

Updated:: 2022-03-14 15:04

Resolved:: 2021-10-27 09:30

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: Oliver Gondža added a comment - 2020-05-25 08:51

Expand comment: Oliver Gondža added a comment - 2020-05-25 08:51

Collapse comment: Gnanasekaran Gajendiran added a comment - 2020-06-25 07:54

Expand comment: Gnanasekaran Gajendiran added a comment - 2020-06-25 07:54

Collapse comment: Daniel Spilker added a comment - 2020-07-15 17:49

Expand comment: Daniel Spilker added a comment - 2020-07-15 17:49

Collapse comment: Daniel Spilker added a comment - 2020-07-15 17:53

Expand comment: Daniel Spilker added a comment - 2020-07-15 17:53

Collapse comment: Gnanasekaran Gajendiran added a comment - 2020-07-20 01:05, Edited by Gnanasekaran Gajendiran - 2020-07-20 01:06

Expand comment: Gnanasekaran Gajendiran added a comment - 2020-07-20 01:05, Edited by Gnanasekaran Gajendiran - 2020-07-20 01:06

Collapse comment: Gnanasekaran Gajendiran added a comment - 2020-07-20 01:36, Edited by Gnanasekaran Gajendiran - 2020-07-20 02:04

Expand comment: Gnanasekaran Gajendiran added a comment - 2020-07-20 01:36, Edited by Gnanasekaran Gajendiran - 2020-07-20 02:04

Collapse comment: Jean-Martin Archer added a comment - 2020-09-14 18:12

Expand comment: Jean-Martin Archer added a comment - 2020-09-14 18:12

Collapse comment: Lukas Bednar added a comment - 2021-05-03 14:32, Edited by Lukas Bednar - 2021-05-07 09:20

Expand comment: Lukas Bednar added a comment - 2021-05-03 14:32, Edited by Lukas Bednar - 2021-05-07 09:20

Collapse comment: robbin added a comment - 2021-07-05 14:57

Expand comment: robbin added a comment - 2021-07-05 14:57

Collapse comment: Parvesh Mourya added a comment - 2022-03-14 15:03, Edited by Parvesh Mourya - 2022-03-14 15:04

Expand comment: Parvesh Mourya added a comment - 2022-03-14 15:03, Edited by Parvesh Mourya - 2022-03-14 15:04

People

Dates