Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-61478

"Apply" (and similar) banners look really bad with larger header bar

    XMLWordPrintable

    Details

    • Similar Issues:
    • Epic Link:
    • Released As:
      Jenkins 2.230

      Description

      Previously, notification banners like the one that appears when pressing "Apply" buttons were the same height as the Jenkins header.

      With the 2.222 design update, that is no longer the case. They look broken now (not merely ugly ).

        Attachments

          Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-62065 The bread crumb navigation on the top of the job is not responding after clicking Apply

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link PR 4610

            Activity

            Ascending order - Click to sort in descending order
            4 older comments
            Hide
            Permalink
            romenrg Romen Rodriguez-Gil added a comment - - edited

            I'd be happy to experiment using Bootstrap alerts for this. I'm pretty sure it will be an improvement.

            Are you OK if I take the ticket and play with it a bit?

            EDIT: I'll be working on this as agreed in the UX SIG meeting

            Show
            romenrg Romen Rodriguez-Gil added a comment - - edited I'd be happy to experiment using Bootstrap alerts for this. I'm pretty sure it will be an improvement. Are you OK if I take the ticket and play with it a bit? EDIT: I'll be working on this as agreed in the UX SIG meeting
            Hide
            Permalink
            fqueiruga Félix Queiruga Balado added a comment -

            I found one more banner that should be updated as well:

            1. Go to the /user/admin/configure page
            2. Generate an API token
            3. Click the button to copy the API token to the clipboard

            Screenshot:

            Show
            fqueiruga Félix Queiruga Balado added a comment - I found one more banner that should be updated as well: Go to the /user/admin/configure page Generate an API token Click the button to copy the API token to the clipboard Screenshot:
            Hide
            Permalink
            romenrg Romen Rodriguez-Gil added a comment -

            Thanks Félix. I'll work on that one as well

            Show
            romenrg Romen Rodriguez-Gil added a comment - Thanks Félix. I'll work on that one as well
            Hide
            Permalink
            fqueiruga Félix Queiruga Balado added a comment -

            If you work with bootstrap alerts, it's better if you don't bring the library in, just bring the code you need.

            Show
            fqueiruga Félix Queiruga Balado added a comment - If you work with bootstrap alerts, it's better if you don't bring the library in, just bring the code you need.
            Hide
            Permalink
            romenrg Romen Rodriguez-Gil added a comment -

            PR: https://github.com/jenkinsci/jenkins/pull/4610

            Show
            romenrg Romen Rodriguez-Gil added a comment - PR:  https://github.com/jenkinsci/jenkins/pull/4610

              People

              Assignee:
              romenrg Romen Rodriguez-Gil
              Reporter:
              danielbeck Daniel Beck
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: