Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-61478

"Apply" (and similar) banners look really bad with larger header bar

    • Jenkins 2.230

      Previously, notification banners like the one that appears when pressing "Apply" buttons were the same height as the Jenkins header.

      With the 2.222 design update, that is no longer the case. They look broken now (not merely ugly ).

          [JENKINS-61478] "Apply" (and similar) banners look really bad with larger header bar

          Daniel Beck added a comment -

          Daniel Beck added a comment - FYI fqueiruga

          Félix Queiruga Balado added a comment - - edited

          It would make sense to revisit the banner. Can someone add it to the https://issues.jenkins-ci.org/browse/JENKINS-60919 epic and mark this as an improvement? We can triage it on the SIG meeting.

          Edit: nevermind, I did that

          Félix Queiruga Balado added a comment - - edited It would make sense to revisit the banner. Can someone add it to the  https://issues.jenkins-ci.org/browse/JENKINS-60919  epic and mark this as an improvement? We can triage it on the SIG meeting. Edit:  nevermind, I did that

          Daniel Beck added a comment -

          an improvement

          So you're saying the banner doesn't look any more broken now than it did in 2.221 before the UI refresh?

          Daniel Beck added a comment - an improvement So you're saying the banner doesn't look any more broken now than it did in 2.221 before the UI refresh?

          I'm saying I don't consider it a bug. But it's OK, I'll mark it back as a bug and we can talk about it on the next SIG meeting, maybe we could even get some designs going.

          Félix Queiruga Balado added a comment - I'm saying I don't consider it a bug. But it's OK, I'll mark it back as a bug and we can talk about it on the next SIG meeting, maybe we could even get some designs going.

          Romen Rodriguez-Gil added a comment - - edited

          I'd be happy to experiment using Bootstrap alerts for this. I'm pretty sure it will be an improvement.

          Are you OK if I take the ticket and play with it a bit?

          EDIT: I'll be working on this as agreed in the UX SIG meeting

          Romen Rodriguez-Gil added a comment - - edited I'd be happy to experiment using Bootstrap alerts for this. I'm pretty sure it will be an improvement. Are you OK if I take the ticket and play with it a bit? EDIT: I'll be working on this as agreed in the UX SIG meeting

          I found one more banner that should be updated as well:

          1. Go to the /user/admin/configure page
          2. Generate an API token
          3. Click the button to copy the API token to the clipboard

          Screenshot:

          Félix Queiruga Balado added a comment - I found one more banner that should be updated as well: Go to the /user/admin/configure page Generate an API token Click the button to copy the API token to the clipboard Screenshot:

          Thanks Félix. I'll work on that one as well

          Romen Rodriguez-Gil added a comment - Thanks Félix. I'll work on that one as well

          If you work with bootstrap alerts, it's better if you don't bring the library in, just bring the code you need.

          Félix Queiruga Balado added a comment - If you work with bootstrap alerts, it's better if you don't bring the library in, just bring the code you need.

          Romen Rodriguez-Gil added a comment - PR:  https://github.com/jenkinsci/jenkins/pull/4610

            romenrg Romen Rodriguez-Gil
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: