Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62059

JabberIMConnectionProvider.createConnection() swallows Exceptions

    XMLWordPrintable

Details

    Description

      Hi flow,

      this is a followup ticket to JENKINS-60193.
      While I was trying to find out why my connection didn't work, I came across this issue.

      When an XmppStringprepException occurs in JabberIMConnection(JabberPublisherDescriptor desc, AuthenticationHolder authentication), this exception is re-thrown as hudson.plugins.im.IMException.

      But in JabberIMConnectionProvider.createConnection(), only RuntimeExceptions are getting caught.

      So the log just tells me that the connection failed, but nut why it failed:

      	h.p.j.i.t.JabberIMConnectionProvider#createConnection: Creating XMPP JabberIMConnection
	h.p.j.i.t.JabberIMConnectionProvider#createConnection: Connection failed

      So IMHO here Exception should get caught here, not only RuntimeException.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          flow Florian Schmaus added a comment -

          I had argued that the try/catch should be removed completely and any kind of exception should be handled by higher layers. So the issue is actually that IMConnectionProvider.create() of the jabber-im plugin, silently swallows the exception.

          flow Florian Schmaus added a comment - I had argued that the try/catch should be removed completely and any kind of exception should be handled by higher layers. So the issue is actually that IMConnectionProvider.create() of the jabber-im plugin, silently swallows the exception.
          flow Florian Schmaus added a comment -

          https://github.com/jenkinsci/instant-messaging-plugin/pull/40

          flow Florian Schmaus added a comment - https://github.com/jenkinsci/instant-messaging-plugin/pull/40

          People

            flow Florian Schmaus
            matthias_m Matthias Müller
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: