-
Bug
-
Resolution: Fixed
-
Minor
-
None
Summary: Some help buttons when clicked jumps to the top or the bottom of the page.
Tested docker run --rm -ti -p 8080:8080 -e ID=3895 jenkins/core-pr-tester
- Folders plugin (see screenshot and screen recordings attached)
- Jenkins Health Advisor plugin (see screenshot)
...
In the PR test version, when you click on the help button, the navigation jumps to the top of the page, without showing the help text. This behavior does not occur in a previous version.
Other places where this occurs in the new version but not the previous one:
Manage Jenkins > Configure Global Security
- Authorization -> Logged in user can do anything -> Allow anonymous read access -> Help button
- CSRF Protection -> Enable proxy compatibility -> Help button
- API Token -> Help buttons (3x)
Freestyle job configuration
- Build Triggers -> Poll SCM -> Ignore post-commit hooks -> Help button
- Post Build Actions -> Archive the artifacts -> Do not fail build if archiving returns nothing, Use default excludes, Treat include and exclude patterns as case sensitive, Follow symbolic links -> Help buttons (4x)
- Post Build Actions -> Publish Javadoc -> Retain Javadoc for each successful build -> Help button
A similar "jumpy" behavior was observed with the Bitbucket Branch Source plugin in both the previous and the PR test version. When you select the checkbox, it jumps to the bottom of the page. This does not happen when you unselect the checkbox (see screen recording bitbucket.mov.zip).
Screenshots
- Folders plugin - Health metrics in Configure System
- folder-health-metric.png
- folder-health-metrics-before.mov
- folder-health-metrics-after.mov
- Health Advisor Plugin
- health-advisor.png
[JENKINS-62500] Help button breaks for some plugins with table to div changes
JavaScript:
var tr = findFollowingTR(this, "help-area", "help-sibling") ||
findFollowingTR(this, "help-area", "setting-help");
var div = $(tr).down();
cc fqueiruga
Thanks for reporting this one. We'll track it and fix it.
One question timja. Do you believe it may be happening in all checkboxes? Also, I have been thinking the last few days that we should include a fallback for the `help-area` like we did for `validation-error-area` here https://issues.jenkins-ci.org/browse/JENKINS-62500. Thoughts?
Possibly, haven’t had time to look closely, other than checking the code and the markup looks fine
I have a working fix for these issues 
I'll try to get it done this weekend hopefully
I have pushed a fix to the branch here: https://github.com/jenkinsci/jenkins/pull/3895/commits/cf9f8b34eb7be64e9033e3f83b2f2b4c54cbf924
timja megathaum would you please give it a try to verify that the problem is finally fixed?
fqueiruga All the following test passed:
Manage Jenkins > Configure System
- Folder -> Health metrics -> Child item with worst health -> Recursive Help Button : Tested OK
Manage Jenkins > Manage Jenkins Health Advisor -> Reminder -> Suppress the reminder to configure Jenkins Health Advisor by CloudBees -> Help Button : Tested OK
Manage Jenkins > Configure Global Security
- Authorization -> Logged in user can do anything -> Allow anonymous read access -> Help button : Tested OK
- CSRF Protection -> Enable proxy compatibility -> Help button : Tested OK
- API Token -> Help buttons (3x) : Tested OK
Freestyle job configuration
- Build Triggers -> Poll SCM -> Ignore post-commit hooks -> Help button : Tested OK
- Post Build Actions -> Archive the artifacts -> Advanced -> Do not fail build if archiving returns nothing, Use default excludes, Treat include and exclude patterns as case sensitive, Follow symbolic links -> Help buttons (4x) : Tested OK
- Post Build Actions -> Publish Javadoc -> Retain Javadoc for each successful build -> Help button : Tested OK
Cloudbees-health advisor plugin has javascript errors when you click the help button:
code: https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/blob/master/src/main/resources/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration/index.jelly#L122