Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62560

Buttons linger when closing modal

    XMLWordPrintable

Details

    • Jenkins 2.240

    Description

      Jenkins 2.233 introduced changes to the button. Since then, button position and visibility seem to be "animated" and it causes buttons to linger when closing modals.

      Steps

      • Open a modal like the one to select repo credentials on a pipeline.
      • Close the modal.
      • Notice that the buttons linger for a bit before fading out.

      Attached screenshots with the modal open and the lingering effect.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          fqueiruga Félix Queiruga Balado added a comment -

          PR here: https://github.com/jenkinsci/jenkins/pull/4770

          olivergondza I guess this can be considered a regression from 2.233. It's not a big bug so I have no opinions whether this should be backported to this release, assuming it gets merged soon ofc. I'd vote to include it on the July one at least though. Thoughts?

          fqueiruga Félix Queiruga Balado added a comment - PR here: https://github.com/jenkinsci/jenkins/pull/4770 olivergondza I guess this can be considered a regression from 2.233. It's not a big bug so I have no opinions whether this should be backported to this release, assuming it gets merged soon ofc. I'd vote to include it on the July one at least though. Thoughts?
          olivergondza Oliver Gondža added a comment -

          fqueiruga, sure, it is too late for 2.235.1 but for the .2 this might be a valid candidate. I see the label is in place so it will be considered provided it will be resolved by then.

          olivergondza Oliver Gondža added a comment - fqueiruga , sure, it is too late for 2.235.1 but for the .2 this might be a valid candidate. I see the label is in place so it will be considered provided it will be resolved by then.
          fqueiruga Félix Queiruga Balado added a comment -

          Understood, thanks!

          fqueiruga Félix Queiruga Balado added a comment - Understood, thanks!
          fqueiruga Félix Queiruga Balado added a comment -

          oleg_nenashev can this be resolved?

          fqueiruga Félix Queiruga Balado added a comment - oleg_nenashev can this be resolved?
          oleg_nenashev Oleg Nenashev added a comment -

          fqueiruga yes, fixed. Usually we expect fix submitters to resolve the issues, and we just do a cleanup afterwards. But everyone was busy with other fires

          oleg_nenashev Oleg Nenashev added a comment - fqueiruga yes, fixed. Usually we expect fix submitters to resolve the issues, and we just do a cleanup afterwards. But everyone was busy with other fires

          People

            fqueiruga Félix Queiruga Balado
            fqueiruga Félix Queiruga Balado
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: