[JENKINS-62619] IllegalArgumentException in parameters slicer

Type: Bug
Resolution: Fixed
Priority: Major
Component/s: configurationslicing-plugin
Labels:
None
Environment:
Jenkins 2.222.3
Configuration Slicing plugin 1.50

Similar Issues:
Powered by SuggestiMate

Show
Released As:
https://github.com/jenkinsci/configurationslicing-plugin/releases

If I open try to open the parameters slicer, I get:

java.lang.IllegalArgumentException: Don't know how to convert (StringParameterValue) BRANCH='master'
	at configurationslicing.parameters.ParametersSlicer$ParametersSliceSpec.toStringValue(ParametersSlicer.java:176)
	at configurationslicing.parameters.ParametersSlicer$ParametersSliceSpec.getParameterItems(ParametersSlicer.java:140)
	at configurationslicing.parameters.ParametersSlicer$ParametersSliceSpec.getValues(ParametersSlicer.java:82)
	at configurationslicing.parameters.ParametersSlicer$ParametersSliceSpec.getValues(ParametersSlicer.java:33)
	at configurationslicing.UnorderedStringSlicer.accumulate(UnorderedStringSlicer.java:81)
	at configurationslicing.UnorderedStringSlicer.accumulate(UnorderedStringSlicer.java:6)
	at configurationslicing.ConfigurationSlicing$SliceExecutor.execute(ConfigurationSlicing.java:126)
	at configurationslicing.ConfigurationSlicing$SliceExecutor.<init>(ConfigurationSlicing.java:114)
	at configurationslicing.ConfigurationSlicing.getDynamic(ConfigurationSlicing.java:99)
	at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627)
	at org.kohsuke.stapler.Function$MethodFunction.invoke(Function.java:396)
	at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:408)
	at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:212)
	at org.kohsuke.stapler.MetaClass$9.dispatch(MetaClass.java:454)
	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:747)
Caused: javax.servlet.ServletException
	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:797)
	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:878)
	at org.kohsuke.stapler.MetaClass$9.dispatch(MetaClass.java:456)
	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:747)
	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:878)
	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:676)
	at org.kohsuke.stapler.Stapler.service(Stapler.java:238)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:755)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1617)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:154)
	at jenkins.security.ResourceDomainFilter.doFilter(ResourceDomainFilter.java:76)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151)
	at hudson.plugins.greenballs.GreenBallFilter.doFilter(GreenBallFilter.java:59)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151)
	at jenkins.telemetry.impl.UserLanguages$AcceptLanguageFilter.doFilter(UserLanguages.java:128)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151)
	at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:157)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:159)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84)
	at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:118)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:93)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249)
	at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:90)
	at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:171)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:82)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at jenkins.security.SuspiciousRequestFilter.doFilter(SuspiciousRequestFilter.java:36)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:545)
	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
	at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:566)
	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
	at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1610)
	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1300)
	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:485)
	at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1580)
	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1215)
	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
	at org.eclipse.jetty.server.Server.handle(Server.java:500)
	at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:383)
	at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:547)
	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:375)
	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273)
	at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103)
	at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117)
	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336)
	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313)
	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171)
	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129)
	at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:375)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938)
	at java.lang.Thread.run(Thread.java:748)

All other slicer work as expected.

Guy Sheffer added a comment - 2020-06-09 21:50

Tried merging it, let see if it works now, if not I am kinda out of ideas

Guy Sheffer added a comment - 2020-06-09 21:50 Tried merging it, let see if it works now, if not I am kinda out of ideas

Guy Sheffer added a comment - 2020-06-10 08:25

I have merged this in to master and it has been built if you want to test if this fixes the issue it would help

There is an HPI from the last successful build:
https://ci.jenkins.io/job/Plugins/job/configurationslicing-plugin/job/master/lastSuccessfulBuild/artifact/target/configurationslicing.hpi

Guy Sheffer added a comment - 2020-06-10 08:25 I have merged this in to master and it has been built if you want to test if this fixes the issue it would help There is an HPI from the last successful build: https://ci.jenkins.io/job/Plugins/job/configurationslicing-plugin/job/master/lastSuccessfulBuild/artifact/target/configurationslicing.hpi

Hendrik Brandenburger added a comment - 2020-06-10 10:20

Unfortunately, this does not fix the problem. The exception remains the same:

java.lang.IllegalArgumentException: Don't know how to convert (StringParameterValue) BRANCH='master'
	at configurationslicing.parameters.ParametersSlicer$ParametersSliceSpec.toStringValue(ParametersSlicer.java:180)
	at configurationslicing.parameters.ParametersSlicer$ParametersSliceSpec.getParameterItems(ParametersSlicer.java:144)
	at configurationslicing.parameters.ParametersSlicer$ParametersSliceSpec.getValues(ParametersSlicer.java:84)
	at configurationslicing.parameters.ParametersSlicer$ParametersSliceSpec.getValues(ParametersSlicer.java:35)
	at configurationslicing.UnorderedStringSlicer.accumulate(UnorderedStringSlicer.java:81)
	at configurationslicing.UnorderedStringSlicer.accumulate(UnorderedStringSlicer.java:6)
	at configurationslicing.ConfigurationSlicing$SliceExecutor.execute(ConfigurationSlicing.java:126)
	at configurationslicing.ConfigurationSlicing$SliceExecutor.<init>(ConfigurationSlicing.java:114)
	at configurationslicing.ConfigurationSlicing.getDynamic(ConfigurationSlicing.java:99)
	at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627)
	at org.kohsuke.stapler.Function$MethodFunction.invoke(Function.java:396)
	at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:408)
	at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:212)
	at org.kohsuke.stapler.MetaClass$9.dispatch(MetaClass.java:454)
	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:747)
Caused: javax.servlet.ServletException
	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:797)
	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:878)
	at org.kohsuke.stapler.MetaClass$9.dispatch(MetaClass.java:456)
	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:747)
	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:878)
	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:676)
	at org.kohsuke.stapler.Stapler.service(Stapler.java:238)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:755)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1617)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:154)
	at jenkins.security.ResourceDomainFilter.doFilter(ResourceDomainFilter.java:76)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151)
	at hudson.plugins.greenballs.GreenBallFilter.doFilter(GreenBallFilter.java:59)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151)
	at jenkins.telemetry.impl.UserLanguages$AcceptLanguageFilter.doFilter(UserLanguages.java:128)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151)
	at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:157)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:159)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84)
	at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:118)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:93)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249)
	at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:90)
	at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:171)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:82)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at jenkins.security.SuspiciousRequestFilter.doFilter(SuspiciousRequestFilter.java:36)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604)
	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:545)
	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
	at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:566)
	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
	at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1610)
	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1300)
	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:485)
	at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1580)
	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1215)
	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
	at org.eclipse.jetty.server.Server.handle(Server.java:500)
	at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:383)
	at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:547)
	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:375)
	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273)
	at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103)
	at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117)
	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336)
	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313)
	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171)
	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129)
	at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:375)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938)
	at java.lang.Thread.run(Thread.java:748)

I would be a pity if the parameter slicing had to be removed, because it is the main feature why we use the plugin.

Hendrik Brandenburger added a comment - 2020-06-10 10:20 Unfortunately, this does not fix the problem. The exception remains the same: java.lang.IllegalArgumentException: Don 't know how to convert (StringParameterValue) BRANCH=' master' at configurationslicing.parameters.ParametersSlicer$ParametersSliceSpec.toStringValue(ParametersSlicer.java:180) at configurationslicing.parameters.ParametersSlicer$ParametersSliceSpec.getParameterItems(ParametersSlicer.java:144) at configurationslicing.parameters.ParametersSlicer$ParametersSliceSpec.getValues(ParametersSlicer.java:84) at configurationslicing.parameters.ParametersSlicer$ParametersSliceSpec.getValues(ParametersSlicer.java:35) at configurationslicing.UnorderedStringSlicer.accumulate(UnorderedStringSlicer.java:81) at configurationslicing.UnorderedStringSlicer.accumulate(UnorderedStringSlicer.java:6) at configurationslicing.ConfigurationSlicing$SliceExecutor.execute(ConfigurationSlicing.java:126) at configurationslicing.ConfigurationSlicing$SliceExecutor.<init>(ConfigurationSlicing.java:114) at configurationslicing.ConfigurationSlicing.getDynamic(ConfigurationSlicing.java:99) at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627) at org.kohsuke.stapler.Function$MethodFunction.invoke(Function.java:396) at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:408) at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:212) at org.kohsuke.stapler.MetaClass$9.dispatch(MetaClass.java:454) at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:747) Caused: javax.servlet.ServletException at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:797) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:878) at org.kohsuke.stapler.MetaClass$9.dispatch(MetaClass.java:456) at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:747) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:878) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:676) at org.kohsuke.stapler.Stapler.service(Stapler.java:238) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:755) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1617) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:154) at jenkins.security.ResourceDomainFilter.doFilter(ResourceDomainFilter.java:76) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151) at hudson.plugins.greenballs.GreenBallFilter.doFilter(GreenBallFilter.java:59) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151) at jenkins.telemetry.impl.UserLanguages$AcceptLanguageFilter.doFilter(UserLanguages.java:128) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:151) at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:157) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604) at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:159) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84) at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:118) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:93) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249) at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:90) at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:171) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604) at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604) at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:82) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604) at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604) at jenkins.security.SuspiciousRequestFilter.doFilter(SuspiciousRequestFilter.java:36) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1604) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:545) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:566) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235) at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1610) at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233) at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1300) at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188) at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:485) at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1580) at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186) at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1215) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) at org.eclipse.jetty.server.Server.handle(Server.java:500) at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:383) at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:547) at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:375) at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273) at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311) at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103) at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:117) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129) at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:375) at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806) at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938) at java.lang. Thread .run( Thread .java:748) I would be a pity if the parameter slicing had to be removed, because it is the main feature why we use the plugin.

Hendrik Brandenburger added a comment - 2020-06-10 11:43

I just looked into your commit that removed the StringParameterValue readout https://github.com/jenkinsci/configurationslicing-plugin/commit/7d4fd1a9beccad67818239ef312da828d33d1d2d and into the StringParameterValue documentation at https://javadoc.jenkins.io/hudson/model/StringParameterValue.html. As far as I can see, it should be possible, instead of removing the decoding of StringParameterValue, to change the previous line 177 from

return ((StringParameterValue) value).value;

into

return ((StringParameterValue) value).getValue();

return ((String) (value.getValue()));

Hendrik Brandenburger added a comment - 2020-06-10 11:43 I just looked into your commit that removed the StringParameterValue readout https://github.com/jenkinsci/configurationslicing-plugin/commit/7d4fd1a9beccad67818239ef312da828d33d1d2d and into the StringParameterValue documentation at https://javadoc.jenkins.io/hudson/model/StringParameterValue.html . As far as I can see, it should be possible, instead of removing the decoding of StringParameterValue, to change the previous line 177 from return ((StringParameterValue) value).value; into return ((StringParameterValue) value).getValue(); or return (( String ) (value.getValue()));

Guy Sheffer added a comment - 2020-06-10 17:48

The issue is I had to remove:

import hudson.model.StringParameterValue;

Would this work if I don't have StringParameterValue imported? how does it resolve instanceof StringParameterValue?

if (value instanceof StringParameterValue) {
 return ((String) (value.getValue()));
}

Guy Sheffer added a comment - 2020-06-10 17:48 The issue is I had to remove: import hudson.model.StringParameterValue; Would this work if I don't have StringParameterValue imported? how does it resolve instanceof StringParameterValue? if (value instanceof StringParameterValue) { return (( String ) (value.getValue())); }

Hendrik Brandenburger added a comment - 2020-06-11 13:58 - edited

I don't think that your problem was the import of StringParameterValue, because on line 6 you import the sibling class BooleanParameterValue without problems. I think the problem was the access to StringParameterValue::value, which, according to https://javadoc.jenkins.io/hudson/model/StringParameterValue.html, is indeed public, but annotated with @Restricted(value=org.kohsuke.accmod.restrictions.NoExternalUse.class). If my assumption is right, it should be no problem to use getValue() instead.

If the import is really the problem you should get around that with something like:

if (value.toString().contains("StringParameterValue")) {
 return ((String) (value.getValue()));
}

Hendrik Brandenburger added a comment - 2020-06-11 13:58 - edited I don't think that your problem was the import of StringParameterValue , because on line 6 you import the sibling class BooleanParameterValue without problems. I think the problem was the access to StringParameterValue::value , which, according to https://javadoc.jenkins.io/hudson/model/StringParameterValue.html , is indeed public, but annotated with @Restricted(value=org.kohsuke.accmod.restrictions.NoExternalUse.class) . If my assumption is right, it should be no problem to use getValue() instead. If the import is really the problem you should get around that with something like: if (value.toString().contains( "StringParameterValue" )) { return (( String ) (value.getValue())); }

Kuan-Yu Ho added a comment - 2020-06-12 06:04

I changed it to getValue() and it works well

PR: https://github.com/jenkinsci/configurationslicing-plugin/pull/28

Kuan-Yu Ho added a comment - 2020-06-12 06:04 I changed it to getValue() and it works well PR: https://github.com/jenkinsci/configurationslicing-plugin/pull/28

Guy Sheffer added a comment - 2020-06-12 07:16

Thanks" merged.

You are welcome to test.

Will also try test here, if all is well will make a new release.

Guy Sheffer added a comment - 2020-06-12 07:16 Thanks" merged. You are welcome to test. Will also try test here, if all is well will make a new release.

Hendrik Brandenburger added a comment - 2020-06-15 09:22

I tested the latest build from https://ci.jenkins.io/job/Plugins/job/configurationslicing-plugin/job/master and it works. The exception is gone. Thanks to hoky841023 for his PR.

Hendrik Brandenburger added a comment - 2020-06-15 09:22 I tested the latest build from https://ci.jenkins.io/job/Plugins/job/configurationslicing-plugin/job/master and it works. The exception is gone. Thanks to hoky841023 for his PR.

Hendrik Brandenburger added a comment - 2020-12-14 13:34

This bug was fixed with Configuration Slicing Plugin 1.51

Hendrik Brandenburger added a comment - 2020-12-14 13:34 This bug was fixed with Configuration Slicing Plugin 1.51

Assignee:: Guy Sheffer

Reporter:: Hendrik Brandenburger

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 2020-06-08 20:04

Updated:: 2020-12-14 13:34

Resolved:: 2020-06-15 09:27

Details

Description

Attachments

Activity

Collapse comment: Guy Sheffer added a comment - 2020-06-09 21:50

Expand comment: Guy Sheffer added a comment - 2020-06-09 21:50

Collapse comment: Guy Sheffer added a comment - 2020-06-10 08:25

Expand comment: Guy Sheffer added a comment - 2020-06-10 08:25

Collapse comment: Hendrik Brandenburger added a comment - 2020-06-10 10:20

Expand comment: Hendrik Brandenburger added a comment - 2020-06-10 10:20

Collapse comment: Hendrik Brandenburger added a comment - 2020-06-10 11:43

Expand comment: Hendrik Brandenburger added a comment - 2020-06-10 11:43

Collapse comment: Guy Sheffer added a comment - 2020-06-10 17:48

Expand comment: Guy Sheffer added a comment - 2020-06-10 17:48

Collapse comment: Hendrik Brandenburger added a comment - 2020-06-11 13:58, Edited by Hendrik Brandenburger - 2020-06-11 14:00

Expand comment: Hendrik Brandenburger added a comment - 2020-06-11 13:58, Edited by Hendrik Brandenburger - 2020-06-11 14:00

Collapse comment: Kuan-Yu Ho added a comment - 2020-06-12 06:04

Expand comment: Kuan-Yu Ho added a comment - 2020-06-12 06:04

Collapse comment: Guy Sheffer added a comment - 2020-06-12 07:16

Expand comment: Guy Sheffer added a comment - 2020-06-12 07:16

Collapse comment: Hendrik Brandenburger added a comment - 2020-06-15 09:22

Expand comment: Hendrik Brandenburger added a comment - 2020-06-15 09:22

Collapse comment: Hendrik Brandenburger added a comment - 2020-12-14 13:34

Expand comment: Hendrik Brandenburger added a comment - 2020-12-14 13:34

People

Dates