Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6262

Fix restarting of Slave nodes with HTTP auth.

    • Icon: Patch Patch
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      Hi,

      We're using Hudson with HTTP-based authentication. There are a few master->slave related issues:

      • Code that waits for slave node has no timeouts...
      • Due to HTTP auth, slave node will never restart since server will return 401.
      • Connection is never closed (resources leak).

      I'm attaching patch that fixed all of these issues here.

          [JENKINS-6262] Fix restarting of Slave nodes with HTTP auth.

          Alan Harder added a comment -

          Looks pretty good to me.. maybe a little longer on the timeout.
          I'll assign to Kohsuke for final review and to commit. Thanks!

          Alan Harder added a comment - Looks pretty good to me.. maybe a little longer on the timeout. I'll assign to Kohsuke for final review and to commit. Thanks!

          Code changed in hudson
          User: : kohsuke
          Path:
          trunk/hudson/main/remoting/src/main/java/hudson/remoting/Engine.java
          trunk/www/changelog.html
          http://jenkins-ci.org/commit/31576
          Log:
          [FIXED JENKINS-6262] HTTP auth support was added in JENKINS-4071, so I've only integrated the portion that specifies the timeout and a call to disconnect(). Will be in 1.361.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/remoting/src/main/java/hudson/remoting/Engine.java trunk/www/changelog.html http://jenkins-ci.org/commit/31576 Log: [FIXED JENKINS-6262] HTTP auth support was added in JENKINS-4071 , so I've only integrated the portion that specifies the timeout and a call to disconnect(). Will be in 1.361.

          Code changed in hudson
          User: : StevenGBrown
          Path:
          trunk/hudson/main/core/src/main/java/hudson/model/FileParameterDefinition.java
          trunk/www/changelog.html
          http://jenkins-ci.org/commit/31582
          Log:
          [FIXED JENKINS-6262] File parameter builds started with the CLI command no longer throw an NPE.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : StevenGBrown Path: trunk/hudson/main/core/src/main/java/hudson/model/FileParameterDefinition.java trunk/www/changelog.html http://jenkins-ci.org/commit/31582 Log: [FIXED JENKINS-6262] File parameter builds started with the CLI command no longer throw an NPE.

          StevenGBrown added a comment -

          Please ignore the previous comment - it was meant for JENKINS-4296.

          StevenGBrown added a comment - Please ignore the previous comment - it was meant for JENKINS-4296 .

            kohsuke Kohsuke Kawaguchi
            dmitry_nezhevenko Dmitry Nezhevenko
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: