Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6274

use dependencygraph for downstream job scheduling

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • maven-plugin
    • None

      The parameterized trigger plugin has to use 2 different mechanisms to trigger projects because maven2 jobs current use downstreamProject.scheduleBuild directly rather than using the DependencyGraph mechanism. If it used DependencyGraph then the parameterized-trigger plugin could remove its special case handling for maven projects. This is in reference to JENKINS-6141.

          [JENKINS-6274] use dependencygraph for downstream job scheduling

          Code changed in hudson
          User: : mindless
          Path:
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java
          http://jenkins-ci.org/commit/33360
          Log:
          [parameterized-trigger] [FIXED JENKINS-6141] Maven plugin currently does not
          use DependencyGraph to trigger downstream jobs so parameters were lost when
          the upstream job is a maven project. Now excluding maven projects from
          DependencyGraph handling, until JENKINS-6274 is implemented.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java http://jenkins-ci.org/commit/33360 Log: [parameterized-trigger] [FIXED JENKINS-6141] Maven plugin currently does not use DependencyGraph to trigger downstream jobs so parameters were lost when the upstream job is a maven project. Now excluding maven projects from DependencyGraph handling, until JENKINS-6274 is implemented.

          Stefan Wolf added a comment -

          This is a patch against trunk fixing this issue. It also fixes the same issue regarding the matrix build, i.e. no more aggregators are necessary.

          Stefan Wolf added a comment - This is a patch against trunk fixing this issue. It also fixes the same issue regarding the matrix build, i.e. no more aggregators are necessary.

          Code changed in hudson
          User: : wolfs
          Path:
          trunk/hudson/main/core/src/main/java/hudson/model/AbstractBuild.java
          trunk/hudson/main/core/src/main/java/hudson/model/Build.java
          trunk/hudson/main/core/src/main/java/hudson/tasks/BuildTrigger.java
          trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/AbstractMavenBuild.java
          trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/AbstractMavenProject.java
          trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenBuild.java
          trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenModule.java
          trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
          trunk/hudson/main/test/src/test/java/hudson/matrix/MatrixProjectDependencyTest.java
          http://jenkins-ci.org/commit/36669
          Log:
          JENKINS-6274: Maven build and Matrix build should trigger dependencies via DependencyGraph

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : wolfs Path: trunk/hudson/main/core/src/main/java/hudson/model/AbstractBuild.java trunk/hudson/main/core/src/main/java/hudson/model/Build.java trunk/hudson/main/core/src/main/java/hudson/tasks/BuildTrigger.java trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/AbstractMavenBuild.java trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/AbstractMavenProject.java trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenBuild.java trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenModule.java trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java trunk/hudson/main/test/src/test/java/hudson/matrix/MatrixProjectDependencyTest.java http://jenkins-ci.org/commit/36669 Log: JENKINS-6274 : Maven build and Matrix build should trigger dependencies via DependencyGraph

          Code changed in hudson
          User: : wolfs
          Path:
          trunk/hudson/main/test/src/test/java/hudson/matrix/MatrixProjectDependencyTest.java
          http://jenkins-ci.org/commit/36670
          Log:
          JENKINS-6274: Added Author to test

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : wolfs Path: trunk/hudson/main/test/src/test/java/hudson/matrix/MatrixProjectDependencyTest.java http://jenkins-ci.org/commit/36670 Log: JENKINS-6274 : Added Author to test

          Stefan Wolf added a comment -

          Fixed in Hudson version 1.385

          Stefan Wolf added a comment - Fixed in Hudson version 1.385

          SauravSengupta added a comment -

          What version contains this fix? The changelog for 1.385 says "Oops, same as 1.384", and 1.386 does not mention this bug number. Maybe the changelogs only include a subset of the bugs fixed in a release?

          SauravSengupta added a comment - What version contains this fix? The changelog for 1.385 says "Oops, same as 1.384", and 1.386 does not mention this bug number. Maybe the changelogs only include a subset of the bugs fixed in a release?

          Stefan Wolf added a comment -

          Seems like it didn't make it into 1.385. The fix is still in trunk, so I don't know when it will be included. Where do you see the changelog for 1.386? I just checked in Fisheye under the 1.386 tag, and there the patch is included. So probably the fix will be in 1.386.

          Stefan Wolf added a comment - Seems like it didn't make it into 1.385. The fix is still in trunk, so I don't know when it will be included. Where do you see the changelog for 1.386? I just checked in Fisheye under the 1.386 tag, and there the patch is included. So probably the fix will be in 1.386.

          SauravSengupta added a comment -

          The usual changelog page I look at:

          https://hudson.dev.java.net/changelog.html

          No 6274 yet. Don't know how that page is generated.

          SauravSengupta added a comment - The usual changelog page I look at: https://hudson.dev.java.net/changelog.html No 6274 yet. Don't know how that page is generated.

            wolfs Stefan Wolf
            herque herque
            Votes:
            5 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: