Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62789

htmlpublisher plugin may break with tables-to-divs

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The htmlpublisher plugin contains a fork of the f:repeatableProperty __ widget and may break with the form-tables-to-divs changes: https://github.com/jenkinsci/htmlpublisher-plugin/blob/master/src/main/resources/htmlpublisher/lib/repeatableProperty.jelly

      It needs to be reviewed and fixed.

       

        Attachments

          Activity

          Hide
          r2b2_nz Richard Bywater added a comment -

          Thanks Félix Queiruga Balado - is there a branch somewhere of the fork-origin that has the required change in it? (To try and discover whether the best approach is to revert back to the original or reapply the same fix in the fork)

          Show
          r2b2_nz Richard Bywater added a comment - Thanks Félix Queiruga Balado - is there a branch somewhere of the fork-origin that has the required change in it? (To try and discover whether the best approach is to revert back to the original or reapply the same fix in the fork)
          Hide
          timja Tim Jacomb added a comment -

          Hi Richard Bywater

          The pull request you can validate it against is:
          https://github.com/jenkinsci/jenkins/pull/3895

          Ideally it would be best to switch back to the original, or upstream the required changes.

          Thanks!

          Show
          timja Tim Jacomb added a comment - Hi Richard Bywater The pull request you can validate it against is: https://github.com/jenkinsci/jenkins/pull/3895 Ideally it would be best to switch back to the original, or upstream the required changes. Thanks!
          Hide
          jsoref Josh Soref added a comment -

          Richard Bywater

          Show
          jsoref Josh Soref added a comment - Richard Bywater Quick-start:  https://github.com/oleg-nenashev/jenkins-tabs-to-divs-config-migration-testenv Manual setup:  docker run --rm -ti -p 8080:8080 -e ID=3895 jenkins/core-pr-tester
          Hide
          fqueiruga Félix Queiruga Balado added a comment -

          Hi Richard Bywater, these changes are now on the master branch of Jenkins ever since version 2.265.

          Show
          fqueiruga Félix Queiruga Balado added a comment - Hi Richard Bywater , these changes are now on the master branch of Jenkins ever since version 2.265.
          Hide
          r2b2_nz Richard Bywater added a comment -

          Olivier Lamy Would you happen to have some time to look into this? I've been meaning to for a while now but kept getting sidetracked with other personal/work stuff...

          Show
          r2b2_nz Richard Bywater added a comment - Olivier Lamy  Would you happen to have some time to look into this? I've been meaning to for a while now but kept getting sidetracked with other personal/work stuff...
          Hide
          r2b2_nz Richard Bywater added a comment -

          Have reviewed and even without the change layout still seems to be ok from what I can see. However I have a PR open (https://github.com/jenkinsci/htmlpublisher-plugin/pull/99) to revert back to the normal repeatableProperty. I'm not sure why it was actually ever forked as it appears that it was due to the lack of invokeBody which actually appeared to have existed at the time anyway but perhaps the Git log doesn't tell the full story

          Show
          r2b2_nz Richard Bywater added a comment - Have reviewed and even without the change layout still seems to be ok from what I can see. However I have a PR open ( https://github.com/jenkinsci/htmlpublisher-plugin/pull/99)  to revert back to the normal repeatableProperty. I'm not sure why it was actually ever forked as it appears that it was due to the lack of invokeBody which actually appeared to have existed at the time anyway but perhaps the Git log doesn't tell the full story

            People

            Assignee:
            r2b2_nz Richard Bywater
            Reporter:
            fqueiruga Félix Queiruga Balado
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: