Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62868

Form changes: ATH errors for Git plugin

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • git-plugin
    • None

      The following ATH errors for the plugin may be caused the tables-to-divs changes:

      • plugins.GitPluginTest.ancestry_strategy_to_choose_build

          [JENKINS-62868] Form changes: ATH errors for Git plugin

          Mark Waite added a comment -

          I propose that we delete that acceptance test.

          The Git plugin ancestry strategy chooser is tested much more thoroughly in AncestryBuildChooserTest and tested a little more in GitSCMUnitTest.

          Web browser clicks of the user interface seem much less likely to detect a bug and much more likely to distract us with irrelevant failures.

          I'd much rather invest our energy in other areas rather than trying to modify this test to operate with the improved user interface.

          Mark Waite added a comment - I propose that we delete that acceptance test. The Git plugin ancestry strategy chooser is tested much more thoroughly in AncestryBuildChooserTest and tested a little more in GitSCMUnitTest . Web browser clicks of the user interface seem much less likely to detect a bug and much more likely to distract us with irrelevant failures. I'd much rather invest our energy in other areas rather than trying to modify this test to operate with the improved user interface.

          Félix Queiruga Balado added a comment -

          This may be related / caused by JEKNINS-62905

          Félix Queiruga Balado added a comment - This may be related / caused by JEKNINS-62905

          Mark Waite added a comment -

          I've invested all that I'm willing to invest in this issue.

          I've submitted the pull request to remove the failing test because I believe it is well covered by existing automated tests inside the git plugin. I've unassigned this issue from myself. I will let others decide if they want to merge that pull request or invest their effort to modify the acceptance test source code.

          Mark Waite added a comment - I've invested all that I'm willing to invest in this issue. I've submitted the pull request to remove the failing test because I believe it is well covered by existing automated tests inside the git plugin. I've unassigned this issue from myself. I will let others decide if they want to merge that pull request or invest their effort to modify the acceptance test source code.

          Tim Jacomb added a comment -

          Marks PR was merged, thanks for making the change Mark

          Tim Jacomb added a comment - Marks PR was merged, thanks for making the change Mark

            markewaite Mark Waite
            fqueiruga Félix Queiruga Balado
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: