Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62910

conditional-buildstep-plugin impacted by tables-to-divs changes

    • Conditional Build Steps 1.4.0

      The plugin contains tabular markup on some form elements and will probably present issues with the tables-to-divs changes in https://issues.jenkins-ci.org/browse/JENKINS-62437

      At least the following files may be affected:

       

      Some migration recipes can be found on https://www.jenkins.io/doc/developer/views/table-to-div-migration/

       

          [JENKINS-62910] conditional-buildstep-plugin impacted by tables-to-divs changes

          AFAICT this is unaffected, I've tested it with the latest jenkins 2.266

          Raihaan Shouhell added a comment - AFAICT this is unaffected, I've tested it with the latest jenkins 2.266

          Oliver Daum added a comment -

          raihaan I have also tested it with a new installtion of jenkins 2.266. I configured a job to mimic our configuration where I discovered that it breaks.

          That is, using the "Conditional steps (multiple)" with an inner step of "Trigger/call builds on other projects" (from the Parameterized Trigger plugin).

          This is the result after saving the config and reopening it:

          The UI below it is broken and no buttons are functional.

          The brwoser console log also contains some errors:

          Whether this is a problem of the Conditional Build Step plugin or the inner step (in this case the Paramterized Trigger plugin) I can not tell.

          Using a different inner step works, as well as using the trigger step outside a conditional step.

           

          Oliver Daum added a comment - raihaan I have also tested it with a new installtion of jenkins 2.266. I configured a job to mimic our configuration where I discovered that it breaks. That is, using the "Conditional steps (multiple)" with an inner step of "Trigger/call builds on other projects" (from the Parameterized Trigger plugin). This is the result after saving the config and reopening it: The UI below it is broken and no buttons are functional. The brwoser console log also contains some errors: Whether this is a problem of the Conditional Build Step plugin or the inner step (in this case the Paramterized Trigger plugin) I can not tell. Using a different inner step works, as well as using the trigger step outside a conditional step.  

          Hi oliverdaum thank you so much for the details, let me try to reproduce this. I was unable to with just the information at hand. I will update when I'm done

          Raihaan Shouhell added a comment - Hi oliverdaum thank you so much for the details, let me try to reproduce this. I was unable to with just the information at hand. I will update when I'm done

          This has been reproduced and is resolved in the linked PR.

          Raihaan Shouhell added a comment - This has been reproduced and is resolved in the linked PR.

          Oliver Daum added a comment -

          Hi raihaan. Thx for the fix.

          I already tested with fixed version and I am no longer able to reproduce it.

          Oliver Daum added a comment - Hi raihaan . Thx for the fix. I already tested with fixed version and I am no longer able to reproduce it.

          Oleg Nenashev added a comment -

          ETA for the plugin release is tomorrow. Luckily, I have taken ownership of this plugin 1 week ago due to another issue (implied plugin dependencies due to the old core version). Thanks to raihaan for addressing it in the PR as well.

          Oleg Nenashev added a comment - ETA for the plugin release is tomorrow. Luckily, I have taken ownership of this plugin 1 week ago due to another issue (implied plugin dependencies due to the old core version). Thanks to raihaan  for addressing it in the PR as well.

          Oleg Nenashev added a comment -

          Oleg Nenashev added a comment - https://github.com/jenkinsci/conditional-buildstep-plugin/releases/tag/conditional-buildstep-1.4.0

          Sammy added a comment -

          Just encountered same issue in Jenkins v2.273 and conditional-buildstep-plugin v1.4.1 with Boolean Parameter included.

          Step to reproduce:

          1. Create a freestyle job
          2. Add Conditional steps (multiple)
          3. Select "Trigger/call builds on other projects" in "Add Steps to run if condition is met" section
          4. Select "Boolean Parameters" in "Add Parameters" dropdown
          5. Save
          6. Re-configure the job, the UI is broken with same JS error as this issue mentioned.

          Sammy added a comment - Just encountered same issue in Jenkins v2.273 and conditional-buildstep-plugin v1.4.1 with Boolean Parameter included. Step to reproduce: Create a freestyle job Add Conditional steps (multiple) Select "Trigger/call builds on other projects" in "Add Steps to run if condition is met" section Select "Boolean Parameters" in "Add Parameters" dropdown Save Re-configure the job, the UI is broken with same JS error as this issue mentioned.

          sammyhk your issue sounds like parameterized-trigger-plugin https://github.com/jenkinsci/parameterized-trigger-plugin which hasn't been released

          Raihaan Shouhell added a comment - sammyhk your issue sounds like parameterized-trigger-plugin https://github.com/jenkinsci/parameterized-trigger-plugin which hasn't been released

          Sammy added a comment -

          Thank you for point me out the cause, I clone the parameterized-trigger-plugin repo and build by myself, after install and it is working correctly

          Sammy added a comment - Thank you for point me out the cause, I clone the parameterized-trigger-plugin repo and build by myself, after install and it is working correctly

            raihaan Raihaan Shouhell
            fqueiruga FĂ©lix Queiruga Balado
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: