Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-62944

make taskScanner ignore its own setup

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      When using

      recordIssues tool: taskScanner(
          excludePattern: '*moc_*, sources/.clang-tidy',
          highTags: 'FIXME',
          ignoreCase: true,
          includePattern: 'sources/**/*.h, sources/**/*.cpp, sources/*',
          lowTags: 'REVIEW',
          normalTags: 'TODO'
      ) 

      we deliberately include our Jenkinsfile to match open tasks there. Unfortunately, task scanner now reports 3 open tasks from its own definition for highTags, lowTags, normalTags.

      It would be good if there was a way to

      • EITHER ignore it's own definition (task-plugin extra code I guess)
      • OR add regexp markers for start- and end-ignore lines, so that we can comment our definition out
        // task-scanner-ignore-begin
        recordIssues tool: taskScanner(
            excludePattern: '*moc_*, sources/.clang-tidy',
            highTags: 'FIXME',
            ignoreCase: true,
            includePattern: 'sources/**/*.h, sources/**/*.cpp, sources/*',
            lowTags: 'REVIEW',
            normalTags: 'TODO',
            ignoreBegin: 'task-scanner-ignore-begin',
            ignoreEnd: 'task-scanner-ignore-end'
        )
        // task-scanner-ignore-end
        

        Attachments

          Activity

          Hide
          drulli Ulli Hafner added a comment -

          Yes, that would be helpful indeed. I needed to exclude some files in order to use the tool with my own plugin.

          Show
          drulli Ulli Hafner added a comment - Yes, that would be helpful indeed. I needed to exclude some files in order to use the tool with my own plugin.
          Hide
          ssproessig Soeren Sproessig added a comment - - edited

          Ulli Hafner  I provided a draft PR for the functionality at https://github.com/jenkinsci/warnings-ng-plugin/pull/682.

          Executing it with mvnd compile test checkstyle:checkstyle on my machine I get

          [INFO] Scanning for projects...
          [INFO] Inspecting build with total of 3 modules...
          [INFO] Installing Nexus Staging features:
          [INFO]   ... total of 1 executions of maven-deploy-plugin replaced with nexus-staging-maven-plugin
          [INFO]
          [INFO] ---------------< io.jenkins.plugins:warnings-ng-parent >----------------
          [INFO] Building Aggregator for Warnings Plugin UNVERSIONED                [2/3]
          [INFO] --------------------------------[ pom ]---------------------------------
          [INFO]
          [INFO] --- maven-checkstyle-plugin:3.1.1:checkstyle (default-cli) @ warnings-ng-parent ---
          [INFO]
          [INFO] --------------< io.jenkins.plugins:warnings-ng-ui-tests >---------------
          [INFO] Building UI Tests of Warnings Plugin UNVERSIONED                   [3/3]
          [INFO] --------------------------------[ jar ]---------------------------------
          [INFO]
          [INFO] --- maven-resources-plugin:3.2.0:resources (default-resources) @ warnings-ng-ui-tests ---
          [INFO] Using 'UTF-8' encoding to copy filtered resources.
          [INFO] Using 'UTF-8' encoding to copy filtered properties files.
          [INFO] skip non existing resourceDirectory G:\Code\github\warnings-ng-plugin\ui-tests\src\main\resources
          [INFO]
          [INFO] --- maven-resources-plugin:3.2.0:copy-resources (copy-resources) @ warnings-ng-ui-tests ---
          [INFO] Using 'UTF-8' encoding to copy filtered resources.
          [INFO] Using 'UTF-8' encoding to copy filtered properties files.
          [INFO] Copying 1 resource
          [INFO]
          [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ warnings-ng-ui-tests ---
          [INFO] Nothing to compile - all classes are up to date
          [INFO]
          [INFO] --- maven-help-plugin:3.2.0:active-profiles (show-profiles) @ warnings-ng-ui-tests ---
          [INFO]
          Active Profiles for Project 'io.jenkins.plugins:warnings-ng:hpi:8.5.0-SNAPSHOT':
          
          The following profiles are active:
          ...
          
          [INFO]
          [INFO] Tests run: 425, Failures: 0, Errors: 0, Skipped: 0
          [INFO]
          [INFO]
          [INFO] --- animal-sniffer-maven-plugin:1.19:check (check) @ warnings-ng ---
          [INFO] Resolved signature org.codehaus.mojo.signature:java18 version as 1.0 from dependencyManagement
          [INFO] Checking unresolved references to org.codehaus.mojo.signature:java18:1.0
          [INFO]
          [INFO] --- maven-checkstyle-plugin:3.1.1:checkstyle (default-cli) @ warnings-ng ---
          [INFO] Segment walltime 75 s, segment projects service time 76 s, effective/maximum degree of concurrency 1,02/15
          [INFO] ------------------------------------------------------------------------
          [INFO] Reactor Summary:
          [INFO]
          [INFO] Warnings Next Generation Plugin 8.5.0-SNAPSHOT ..... SUCCESS [01:15 min]
          [INFO] UI Tests of Warnings Plugin UNVERSIONED ............ SUCCESS [  1.147 s]
          [INFO] Aggregator for Warnings Plugin UNVERSIONED ......... SUCCESS [  0.012 s]
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD SUCCESS
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time:  01:15 min (Wall Clock)
          [INFO] Finished at: 2020-11-06T13:23:08+01:00
          [INFO] ------------------------------------------------------------------------
          

          So, it compiles and the tests succeed, without checkstyle finding something. I'm a bit lost with the CI/CD which keeps failing

          Show
          ssproessig Soeren Sproessig added a comment - - edited Ulli Hafner   I provided a draft PR for the functionality at  https://github.com/jenkinsci/warnings-ng-plugin/pull/682 . Executing it with mvnd compile test checkstyle:checkstyle on my machine I get [INFO] Scanning for projects... [INFO] Inspecting build with total of 3 modules... [INFO] Installing Nexus Staging features: [INFO] ... total of 1 executions of maven-deploy-plugin replaced with nexus-staging-maven-plugin [INFO] [INFO] ---------------< io.jenkins.plugins:warnings-ng-parent >---------------- [INFO] Building Aggregator for Warnings Plugin UNVERSIONED [2/3] [INFO] --------------------------------[ pom ]--------------------------------- [INFO] [INFO] --- maven-checkstyle-plugin:3.1.1:checkstyle ( default -cli) @ warnings-ng-parent --- [INFO] [INFO] --------------< io.jenkins.plugins:warnings-ng-ui-tests >--------------- [INFO] Building UI Tests of Warnings Plugin UNVERSIONED [3/3] [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] --- maven-resources-plugin:3.2.0:resources ( default -resources) @ warnings-ng-ui-tests --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Using 'UTF-8' encoding to copy filtered properties files. [INFO] skip non existing resourceDirectory G:\Code\github\warnings-ng-plugin\ui-tests\src\main\resources [INFO] [INFO] --- maven-resources-plugin:3.2.0:copy-resources (copy-resources) @ warnings-ng-ui-tests --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Using 'UTF-8' encoding to copy filtered properties files. [INFO] Copying 1 resource [INFO] [INFO] --- maven-compiler-plugin:3.8.1:compile ( default -compile) @ warnings-ng-ui-tests --- [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] --- maven-help-plugin:3.2.0:active-profiles (show-profiles) @ warnings-ng-ui-tests --- [INFO] Active Profiles for Project 'io.jenkins.plugins:warnings-ng:hpi:8.5.0-SNAPSHOT' : The following profiles are active: ... [INFO] [INFO] Tests run: 425, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] --- animal-sniffer-maven-plugin:1.19:check (check) @ warnings-ng --- [INFO] Resolved signature org.codehaus.mojo.signature:java18 version as 1.0 from dependencyManagement [INFO] Checking unresolved references to org.codehaus.mojo.signature:java18:1.0 [INFO] [INFO] --- maven-checkstyle-plugin:3.1.1:checkstyle ( default -cli) @ warnings-ng --- [INFO] Segment walltime 75 s, segment projects service time 76 s, effective/maximum degree of concurrency 1,02/15 [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Warnings Next Generation Plugin 8.5.0-SNAPSHOT ..... SUCCESS [01:15 min] [INFO] UI Tests of Warnings Plugin UNVERSIONED ............ SUCCESS [ 1.147 s] [INFO] Aggregator for Warnings Plugin UNVERSIONED ......... SUCCESS [ 0.012 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:15 min (Wall Clock) [INFO] Finished at: 2020-11-06T13:23:08+01:00 [INFO] ------------------------------------------------------------------------ So, it compiles and the tests succeed, without checkstyle finding something. I'm a bit lost with the CI/CD which keeps failing

            People

            Assignee:
            ssproessig Soeren Sproessig
            Reporter:
            ssproessig Soeren Sproessig
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: