Details
-
Bug
-
Status: Open (View Workflow)
-
Minor
-
Resolution: Unresolved
-
Docker 19.03.6-ce, OpenJDK 11.0.7, Jenkins 2.235.1, branch-api 2.5.6
Description
After digging through the source code of the Branch API plugin I came across the following logic to evaluate the triggering of automatic builds based on Build Strategies, https://github.com/jenkinsci/branch-api-plugin/blob/master/src/main/java/jenkins/branch/MultiBranchProject.java#L2246-L2257
Apparently this logic will trigger a branch build with a short-circuit OR, meaning if I have two strategies returning false and one returning true the branch build will be triggered no matter what.
A clear example of the situation above and the problems it brings is the use of the strategy jenkins.branch.buildstrategies.basic.SkipInitialBuildOnFirstBranchIndexing. After the first build, it will always return true, which in turn will make all other strategies, like jenkins.branch.buildstrategies.basic.ChangeRequestBuildStrategyImpl useless, even if it returns false.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
After digging through the source code of the Branch API plugin I came across the following logic to evaluate the triggering of automatic builds based on Build Strategies, [https://github.com/jenkinsci/branch-api-plugin/blob/master/src/main/java/jenkins/branch/MultiBranchProject.java#L2246-L2257] Apparently this logic will trigger a branch build with a short-circuit `OR`, meaning if I have two strategies returning `false` and one returning `true` the branch build will be triggered no matter what. A clear example of the situation above and the problems it brings is the use of the strategy `jenkins.branch.buildstrategies.basic.SkipInitialBuildOnFirstBranchIndexing`. After the first build it will always return `true`, which in turn will make all other strategies, like `jenkins.branch.buildstrategies.basic.ChangeRequestBuildStrategyImpl` useless, even if it returns `false`. |
After digging through the source code of the Branch API plugin I came across the following logic to evaluate the triggering of automatic builds based on Build Strategies, [https://github.com/jenkinsci/branch-api-plugin/blob/master/src/main/java/jenkins/branch/MultiBranchProject.java#L2246-L2257] Apparently this logic will trigger a branch build with a short-circuit {{OR}}, meaning if I have two strategies returning {{false}} and one returning {{true}} the branch build will be triggered no matter what. A clear example of the situation above and the problems it brings is the use of the strategy {{jenkins.branch.buildstrategies.basic.SkipInitialBuildOnFirstBranchIndexing}}. After the first build, it will always return {{true}}, which in turn will make all other strategies, like {{jenkins.branch.buildstrategies.basic.ChangeRequestBuildStrategyImpl}} useless, even if it returns {{false}}. |
Jakob Sloth Nielsen
made changes -
| Attachment | image-2021-11-18-10-32-09-647.png [ 56789 ] |