• Type: New Feature
• Resolution: Fixed
• Priority: Minor
• Component/s: sidebar-link-plugin
• Labels:

  • jcasc-compatibility

[JENKINS-63149] Add JCasC support for the sidebar link plugin

Collapse comment: Robert added a comment - 2021-05-11 08:55

Robert added a comment - 2021-05-11 08:55

Prepared JCasC 
see https://github.com/jenkinsci/sidebar-link-plugin/pull/25 

Expand comment: Robert added a comment - 2021-05-11 08:55

Robert added a comment - 2021-05-11 08:55 Prepared JCasC  see https://github.com/jenkinsci/sidebar-link-plugin/pull/25  

Collapse comment: Valentin Delaye added a comment - 2022-02-02 08:02

Valentin Delaye added a comment - 2022-02-02 08:02

+1

Expand comment: Valentin Delaye added a comment - 2022-02-02 08:02

Valentin Delaye added a comment - 2022-02-02 08:02 +1

Collapse comment: Valentin Delaye added a comment - 2022-02-07 07:10, Edited by Valentin Delaye - 2022-02-07 07:11

Valentin Delaye added a comment - 2022-02-07 07:10 - edited

I've tested the PR, seems to work.

unclassified:
  sidebarGlobalLink:
    links:
    - displayName: "Link1"
      iconFileName: "static/5f38cabf/images/jenkins-header-logo-v2.svg"
      urlName: "https://www.google.com"
    - displayName: "Link2"
      urlName: "https://www.google.com"

 

Expand comment: Valentin Delaye added a comment - 2022-02-07 07:10, Edited by Valentin Delaye - 2022-02-07 07:11

Valentin Delaye added a comment - 2022-02-07 07:10 - edited I've tested the PR, seems to work. unclassified: sidebarGlobalLink: links: - displayName: "Link1" iconFileName: " static /5f38cabf/images/jenkins-header-logo-v2.svg" urlName: "https: //www.google.com" - displayName: "Link2" urlName: "https: //www.google.com"  

Collapse comment: Kalle Niemitalo added a comment - 2022-02-09 20:19

Kalle Niemitalo added a comment - 2022-02-09 20:19

PR 25 was merged and released in Sidebar Link 2.0.0.

Expand comment: Kalle Niemitalo added a comment - 2022-02-09 20:19

Kalle Niemitalo added a comment - 2022-02-09 20:19 PR 25 was merged and released in Sidebar Link 2.0.0.

Collapse comment: Valentin Delaye added a comment - 2022-02-18 08:20

Valentin Delaye added a comment - 2022-02-18 08:20

Thanks! All good on my side

Expand comment: Valentin Delaye added a comment - 2022-02-18 08:20

Valentin Delaye added a comment - 2022-02-18 08:20 Thanks! All good on my side

Collapse comment: Kalle Niemitalo added a comment - 2022-02-18 08:45, Edited by Kalle Niemitalo - 2022-02-18 09:16

Kalle Niemitalo added a comment - 2022-02-18 08:45 - edited

There are a few problems in how PR 25 selects a default icon when none is specified, but let's resolve this issue and file those separately.

Filed https://github.com/jenkinsci/sidebar-link-plugin/issues/40.

Expand comment: Kalle Niemitalo added a comment - 2022-02-18 08:45, Edited by Kalle Niemitalo - 2022-02-18 09:16

Kalle Niemitalo added a comment - 2022-02-18 08:45 - edited There are a few problems in how PR 25 selects a default icon when none is specified, but let's resolve this issue and file those separately. Filed https://github.com/jenkinsci/sidebar-link-plugin/issues/40 .