Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-63508

Unquoted system image names break sh

    XMLWordPrintable

    Details

    • Similar Issues:
    • Released As:
      3.1.2

      Description

      Old

      /Users/builduser/Library/Android/sdk/tools/android create avd -f -a -c 512M -s 1080x1920 -n hudson_en-US_420_1080x1920_Google_Inc._Google_APIs_29_x86 -t "Google Inc.:Google APIs:29" --abi x86

      New

      **/Volumes/Code/Jenkins/tools/android-sdk/tools/bin/avdmanager create avd -f -c 512M -d 17 -n hudson_en-US_420_1080x1920_Google_Inc._Google_APIs_29_x86_17 -k system-images;android-29;google_apis;x86 --tag google_apis

      The CLI changed a little bit in the newer scheme, but as far as I can tell the semi colons in the system image names still throw the shell for a loop. Running the second command fails with

      Error: Package path is not valid. Valid system image paths are:ository...
      system-images;android-29;google_apis;x86
      system-images;android-26;google_apis;x86
      null

      Running the command with quotes around the system image name works as expected.

        Attachments

          Issue Links

            Activity

            Hide
            jzbrooks Justin Brooks added a comment -

            Hi Nikolas Falco, I've upgraded to the latest emulator plugin to 3.1.2 and am still not seeing the improvement here. This is breaking our CI tests. Would it be possible to ship another build that includes this fix?

            Show
            jzbrooks Justin Brooks added a comment - Hi Nikolas Falco , I've upgraded to the latest emulator plugin to 3.1.2 and am still not seeing the improvement here. This is breaking our CI tests. Would it be possible to ship another build that includes this fix?
            Hide
            nfalco Nikolas Falco added a comment -

            Could you attach the jenkins console log? Because chages are there and also a test case that verify string is quoted. So if not changed I need the console log to understand what is doing on your jenkins

            Show
            nfalco Nikolas Falco added a comment - Could you attach the jenkins console log? Because chages are there and also a test case that verify string is quoted. So if not changed I need the console log to understand what is doing on your jenkins
            Hide
            jzbrooks Justin Brooks added a comment -
            15:41:04 Started by user Justin Brooks
            15:41:04 Running as SYSTEM
            15:41:05 [EnvInject] - Loading node environment variables.
            15:41:05 Building remotely on build-machine (faithlife-app) in workspace /Volumes/Code/Jenkins/workspace/Faithlife-Android-Connected-Tests
            15:41:05 The recommended git tool is: NONE
            15:41:05 No credentials specified
            15:41:05  > git rev-parse --is-inside-work-tree # timeout=10
            15:41:05 Fetching changes from the remote Git repository
            15:41:05  > git config remote.origin.url <remote> # timeout=10
            15:41:05 Fetching upstream changes from <remote>
            15:41:05  > git --version # timeout=10
            15:41:05  > git --version # 'git version 2.24.3 (Apple Git-128)'
            15:41:05  > git fetch --tags --force --progress -- <remote> +refs/heads/*:refs/remotes/origin/* # timeout=10
            15:41:07  > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
            15:41:07  > git rev-parse refs/remotes/origin/refs/heads/master^{commit} # timeout=10
            15:41:07 Checking out Revision efe589697263ba8c5a1b6efa1ce224d188932a85 (refs/remotes/origin/master)
            15:41:07  > git config core.sparsecheckout # timeout=10
            15:41:07  > git checkout -f efe589697263ba8c5a1b6efa1ce224d188932a85 # timeout=10
            15:41:07 Commit message: "Merge branch 'internal' into master"
            15:41:07 First time build. Skipping changelog.
            15:41:07 Cleaning workspace
            15:41:07  > git rev-parse --verify HEAD # timeout=10
            15:41:07 Resetting working tree
            15:41:07  > git reset --hard # timeout=10
            15:41:07  > git clean -fdx # timeout=10
            15:41:07 [Checks API] No suitable checks publisher found.
            15:41:07 [android] Using Android SDK: /Users/builduser/Library/Android/sdk
            15:41:07 [android] Creating Android AVD: /mnt/jenkins/.android/avd/hudson_en-US_420_1080x1920_Google_Inc._Google_APIs_29_x86_17.avd
            15:41:07 [android] /Users/builduser/Library/Android/sdk/tools/bin/avdmanager create avd -f -c 512M -d 17 -n hudson_en-US_420_1080x1920_Google_Inc._Google_APIs_29_x86_17 -k system-images;android-29;google_apis;x86 --tag google_apis
            15:41:08 	Loading local repository...                                                     
            15:41:08 	Warning: Observed package id 'tools' in inconsistent location '/Users/builduser/Library/Android/sdk/tools' (Expected '/Users/builduser/Library/Android/sdk/tools/tools')
            15:41:08 	[=========                              ] 25% Loading local repository...       
            15:41:08 	[=========                              ] 25% Fetch remote repository...        
            15:41:08 	[=========                              ] 25% Fetch remote repository...        
            15:41:08 	[=========                              ] 25% Fetch remote repository...        
            15:41:08 	[=======================================] 100% Fetch remote repository...       
            15:41:08 	Error: Package path is not valid. Valid system image paths are:
            15:41:08 	null
            15:41:08 	
            15:41:08 [android] Failed to run AVD creation command
            15:41:08 [android] Could not create Android emulator: Failed to run AVD creation command
            15:41:08 Archiving artifacts
            15:41:08 [htmlpublisher] Archiving HTML reports...
            15:41:08 [htmlpublisher] Archiving at BUILD level /Volumes/Code/Jenkins/workspace/Faithlife-Android-Connected-Tests/app/build/reports/androidTests/connected/flavors/INTERNAL to /mnt/jenkins/jobs/Faithlife-Android-Connected-Tests/builds/474/htmlreports/App_20Test_20Results
            15:41:08 ERROR: Specified HTML directory '/Volumes/Code/Jenkins/workspace/Faithlife-Android-Connected-Tests/app/build/reports/androidTests/connected/flavors/INTERNAL' does not exist.
            15:41:08 [Checks API] No suitable checks publisher found.
            15:41:08 Finished: NOT_BUILT
            

            I saw the commit as well. I'm surprised it still isn't quoted. There does seem to be a discrepancy related to the android sdk tools instalation directory. We set ANDROID_SDK_ROOT to /Users/builduser/Library/Android/sdk.

            Show
            jzbrooks Justin Brooks added a comment - 15:41:04 Started by user Justin Brooks 15:41:04 Running as SYSTEM 15:41:05 [EnvInject] - Loading node environment variables. 15:41:05 Building remotely on build-machine (faithlife-app) in workspace /Volumes/Code/Jenkins/workspace/Faithlife-Android-Connected-Tests 15:41:05 The recommended git tool is: NONE 15:41:05 No credentials specified 15:41:05 > git rev-parse --is-inside-work-tree # timeout=10 15:41:05 Fetching changes from the remote Git repository 15:41:05 > git config remote.origin.url <remote> # timeout=10 15:41:05 Fetching upstream changes from <remote> 15:41:05 > git --version # timeout=10 15:41:05 > git --version # 'git version 2.24.3 (Apple Git-128)' 15:41:05 > git fetch --tags --force --progress -- <remote> +refs/heads/*:refs/remotes/origin/* # timeout=10 15:41:07 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10 15:41:07 > git rev-parse refs/remotes/origin/refs/heads/master^{commit} # timeout=10 15:41:07 Checking out Revision efe589697263ba8c5a1b6efa1ce224d188932a85 (refs/remotes/origin/master) 15:41:07 > git config core.sparsecheckout # timeout=10 15:41:07 > git checkout -f efe589697263ba8c5a1b6efa1ce224d188932a85 # timeout=10 15:41:07 Commit message: "Merge branch 'internal' into master" 15:41:07 First time build. Skipping changelog. 15:41:07 Cleaning workspace 15:41:07 > git rev-parse --verify HEAD # timeout=10 15:41:07 Resetting working tree 15:41:07 > git reset --hard # timeout=10 15:41:07 > git clean -fdx # timeout=10 15:41:07 [Checks API] No suitable checks publisher found. 15:41:07 [android] Using Android SDK: /Users/builduser/Library/Android/sdk 15:41:07 [android] Creating Android AVD: /mnt/jenkins/.android/avd/hudson_en-US_420_1080x1920_Google_Inc._Google_APIs_29_x86_17.avd 15:41:07 [android] /Users/builduser/Library/Android/sdk/tools/bin/avdmanager create avd -f -c 512M -d 17 -n hudson_en-US_420_1080x1920_Google_Inc._Google_APIs_29_x86_17 -k system-images;android-29;google_apis;x86 --tag google_apis 15:41:08 Loading local repository... 15:41:08 Warning: Observed package id 'tools' in inconsistent location '/Users/builduser/Library/Android/sdk/tools' (Expected '/Users/builduser/Library/Android/sdk/tools/tools' ) 15:41:08 [========= ] 25% Loading local repository... 15:41:08 [========= ] 25% Fetch remote repository... 15:41:08 [========= ] 25% Fetch remote repository... 15:41:08 [========= ] 25% Fetch remote repository... 15:41:08 [=======================================] 100% Fetch remote repository... 15:41:08 Error: Package path is not valid. Valid system image paths are: 15:41:08 null 15:41:08 15:41:08 [android] Failed to run AVD creation command 15:41:08 [android] Could not create Android emulator: Failed to run AVD creation command 15:41:08 Archiving artifacts 15:41:08 [htmlpublisher] Archiving HTML reports... 15:41:08 [htmlpublisher] Archiving at BUILD level /Volumes/Code/Jenkins/workspace/Faithlife-Android-Connected-Tests/app/build/reports/androidTests/connected/flavors/INTERNAL to /mnt/jenkins/jobs/Faithlife-Android-Connected-Tests/builds/474/htmlreports/App_20Test_20Results 15:41:08 ERROR: Specified HTML directory '/Volumes/Code/Jenkins/workspace/Faithlife-Android-Connected-Tests/app/build/reports/androidTests/connected/flavors/INTERNAL' does not exist. 15:41:08 [Checks API] No suitable checks publisher found. 15:41:08 Finished: NOT_BUILT I saw the commit as well. I'm surprised it still isn't quoted. There does seem to be a discrepancy related to the android sdk tools instalation directory. We set ANDROID_SDK_ROOT to /Users/builduser/Library/Android/sdk.

              People

              Assignee:
              nfalco Nikolas Falco
              Reporter:
              jzbrooks Justin Brooks
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: