• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • None
    • Jenkins 2.260
      Pipeline stage view 2.16
      Firefox 81.0.1

      After upgrading pipeline stage view plugin to version 2.16 the input stage "hover box" no longer appear for input stages. Input stages could still be completed using the links in "Console Output".

      This screenshot was taken after downgrading to 2.15. It's the yellow box I mean was missing in 2.16.

        1. jenkins_input_hover.png
          jenkins_input_hover.png
          41 kB
        2. JenkinsInputLocation.png
          JenkinsInputLocation.png
          59 kB
        3. jenkins-scrollbar.png
          jenkins-scrollbar.png
          172 kB
        4. screenshot-1.png
          screenshot-1.png
          10 kB

          [JENKINS-63892] Missing pipeline input hover in stage view

          Nice find! So a workaround could be building longer pipelines!

          Robin Karlsson added a comment - Nice find! So a workaround could be building longer pipelines!

          Ed Thorne added a comment - - edited

          Actually the PR author has already pushed a fix in pull request 116 so the next version of the plugin should fix the issue. I tested it by altering the in memory CSS based on his PR and the popover appears where you'd expect it.

          Ed Thorne added a comment - - edited Actually the PR author has already pushed a fix in pull request 116 so the next version of the plugin should fix the issue. I tested it by altering the in memory CSS based on his PR and the popover appears where you'd expect it.

          Jimmy Praet added a comment -

          The input hover is still not showing up correctly for me in 2.17.

          Jimmy Praet added a comment - The input hover is still not showing up correctly for me in 2.17.

          Same here. Even with 2.17 the box is not showing up.

          And if I check the Style Editor in Firefox it's as if pull request 116 wasn't included in 2.17. I see:

          .cbwf-widget {
            width: calc(100% - 10px);
          }
          

          and if I change it to

          .cbwf-widget {
            width: calc(~'100% - 10px');
          }
          

          the box appears where it should!

          I've tried reloading hard and clearing cache, but no luck.

          Robin Karlsson added a comment - Same here. Even with 2.17 the box is not showing up. And if I check the Style Editor in Firefox it's as if pull request 116 wasn't included in 2.17. I see: .cbwf-widget { width : calc(100% - 10px); } and if I change it to .cbwf-widget { width : calc(~ '100% - 10px' ); } the box appears where it should! I've tried reloading hard and clearing cache, but no luck.

          snago Since ~'...' is invalid in plain CSS (that escaping was needed for LESS), changing that effectively disables the width property, which makes the popup return to its rightful place...

          The problem seems to be that the old JS code and the new CSS styles are not equivalent: The old code was only applied to the whole stage view (as far as I can see) and the new CSS is also applied to the input popup. (AFAICS, I'm not an expert on CSS)

          Tobias Gruetzmacher added a comment - snago Since ~'...' is invalid in plain CSS (that escaping was needed for LESS), changing that effectively disables the width property, which makes the popup return to its rightful place... The problem seems to be that the old JS code and the new CSS styles are not equivalent: The old code was only applied to the whole stage view (as far as I can see) and the new CSS is also applied to the input popup. (AFAICS, I'm not an expert on CSS)

          It is even worse then that: The input popup is affected most, but other popups also suffer:

          Seems the .cbwf-widget doesn't just apply to the intended popup

          Tobias Gruetzmacher added a comment - It is even worse then that: The input popup is affected most, but other popups also suffer: Seems the .cbwf-widget doesn't just apply to the intended popup

          Tomasz G added a comment -

          I can confirm all pop-ups are impacted but input is the most. Take a look at this "in progress", when I hover mouse over it then scroll bar appear at the bottom.

           

          Tomasz G added a comment - I can confirm all pop-ups are impacted but input is the most. Take a look at this "in progress", when I hover mouse over it then scroll bar appear at the bottom.  

          Kamil Zieliński added a comment - - edited

          Hi folks, many thanks for your input!
          I found a workaround that works. It is a bit hacky and I but allows us to click on input options.

          What you need to do is to comment-out or set to inherit the width property in class cbwf-widget:

          .cbwf-widget {
            width: inherit;
          }
          

          To achieve that I used another Jenkins plugin ( https://plugins.jenkins.io/simple-theme-plugin/ )to add this rule (but you need to additionally add  !important declaration)

          Steps:
          Config page>Theme>Choose Extra CSS> paste:

          .cbwf-widget {
            width: inherit !important;
          }
          

          And save.

          Another way is to clone the stage view plugin, remove width property, build and upload folked plugin.

          Kamil Zieliński added a comment - - edited Hi folks, many thanks for your input! I found a workaround that works. It is a bit hacky and I but allows us to click on input options. What you need to do is to comment-out or set to inherit the width property in class cbwf-widget : .cbwf-widget { width: inherit; } To achieve that I used another Jenkins plugin ( https://plugins.jenkins.io/simple-theme-plugin/  )to add this rule (but you need to additionally add  !important  declaration) Steps: Config page>Theme>Choose Extra CSS> paste: .cbwf-widget { width: inherit !important; } And save. Another way is to clone the stage view plugin, remove width property, build and upload folked plugin.

          Allegedly a fix for this was already merged (14.10.2020): https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/118

          => Looking forward to a new release of "pipeline-stage-view" plugin! Is that (or this ticket) really for svanoort?

          Reinhold Füreder added a comment - Allegedly a fix for this was already merged (14.10.2020): https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/118 => Looking forward to a new release of "pipeline-stage-view" plugin! Is that (or this ticket) really for svanoort ?

          Fixed in 2.18

          Tobias Gruetzmacher added a comment - Fixed in 2.18

            Unassigned Unassigned
            snago Robin Karlsson
            Votes:
            14 Vote for this issue
            Watchers:
            16 Start watching this issue

              Created:
              Updated:
              Resolved: