Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64069

Unable to select a branch source when creating new multi-branch item.

    XMLWordPrintable

    Details

    • Similar Issues:
    • Released As:
      branch-api 2.6.3, cloudbees-folder 6.15

      Description

      Clicking on a source type on a new item doesn't display the SCM form.

      After clicking the GitHub (or other source types) the dropdown menu closes and the form is not displayed.

      Expected: Click on GitHub in the Branch Sources dropdown menu and the GitHub form pops up.

       

      See attachment.

        Attachments

        1. image-2020-10-30-07-02-43-834.png
          48 kB
          Reinhold Füreder
        2. Jenkins-Ticket.gif
          309 kB
          William Gillaspy
        3. screenshot-1.png
          58 kB
          Tim Jacomb
        4. screenshot-2.png
          4 kB
          Tim Jacomb
        5. selectSource.png
          14 kB
          William Gillaspy

          Issue Links

            Activity

            Hide
            timja Tim Jacomb added a comment -

            this fixes it but breaks compat with old core. Will experiment a bit more but maybe we just raise the baseline.

            $ git diff
            diff --git a/src/main/resources/jenkins/branch/BranchSource/config.jelly b/src/main/resources/jenkins/branch/BranchSource/config.jelly
            index c736737..c8f2850 100644
            --- a/src/main/resources/jenkins/branch/BranchSource/config.jelly
            +++ b/src/main/resources/jenkins/branch/BranchSource/config.jelly
            @@ -23,7 +23,7 @@
              -->
             <?jelly escape-by-default='true'?>
             <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:branch="/lib/branch-api">
            -  <branch:rowWrapper name="source">
            +  <div class="tr" name="source" data-hack="true">
                 <branch:entryWrapper>
                   <input type="hidden" name="stapler-class" value="${sourceDescriptor.clazz.name}"/>
                   <branch:blockWrapper>
            @@ -34,7 +34,7 @@
                     </j:scope>
                   </branch:blockWrapper>
                 </branch:entryWrapper>
            -  </branch:rowWrapper>
            +  </div>
               <j:set var="descriptors" value="${descriptor.propertyStrategyDescriptors(it,sourceDescriptor)}"/>
               <j:if test="${!descriptors.isEmpty()}">
                 <f:block>
            
            Show
            timja Tim Jacomb added a comment - this fixes it but breaks compat with old core. Will experiment a bit more but maybe we just raise the baseline. $ git diff diff --git a/src/main/resources/jenkins/branch/BranchSource/config.jelly b/src/main/resources/jenkins/branch/BranchSource/config.jelly index c736737..c8f2850 100644 --- a/src/main/resources/jenkins/branch/BranchSource/config.jelly +++ b/src/main/resources/jenkins/branch/BranchSource/config.jelly @@ -23,7 +23,7 @@ --> <?jelly escape-by- default = ' true ' ?> <j:jelly xmlns:j= "jelly:core" xmlns:st= "jelly:stapler" xmlns:d= "jelly:define" xmlns:l= "/lib/layout" xmlns:t= "/lib/hudson" xmlns:f= "/lib/form" xmlns:branch= "/lib/branch-api" > - <branch:rowWrapper name= "source" > + <div class= "tr" name= "source" data-hack= " true " > <branch:entryWrapper> <input type= "hidden" name= "stapler-class" value= "${sourceDescriptor.clazz.name}" /> <branch:blockWrapper> @@ -34,7 +34,7 @@ </j:scope> </branch:blockWrapper> </branch:entryWrapper> - </branch:rowWrapper> + </div> <j:set var = "descriptors" value= "${descriptor.propertyStrategyDescriptors(it,sourceDescriptor)}" /> <j: if test= "${!descriptors.isEmpty()}" > <f:block>
            Hide
            fqueiruga Félix Queiruga Balado added a comment -

            If raising the baseline is acceptable I'd say go for it. What's the data-hack for, btw?

            Show
            fqueiruga Félix Queiruga Balado added a comment - If raising the baseline is acceptable I'd say go for it. What's the data-hack for, btw?
            Hide
            timja Tim Jacomb added a comment -

            Just adding an attribute, making sure the jelly was getting reloaded

            Show
            timja Tim Jacomb added a comment - Just adding an attribute, making sure the jelly was getting reloaded
            Hide
            fqueiruga Félix Queiruga Balado added a comment -

            Ok,makes sense

            Show
            fqueiruga Félix Queiruga Balado added a comment - Ok,makes sense
            Hide
            dnusbaum Devin Nusbaum added a comment -

            Fixes for this issue have been released in Branch API plugin 2.6.3 and CloudBees Folder plugin 6.15.

            Show
            dnusbaum Devin Nusbaum added a comment - Fixes for this issue have been released in Branch API plugin 2.6.3 and CloudBees Folder plugin 6.15.

              People

              Assignee:
              timja Tim Jacomb
              Reporter:
              wgillaspy William Gillaspy
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: