Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64106

Switch SSH client from Trilead to Apache Mina SSH

    • Icon: New Feature New Feature
    • Resolution: Unresolved
    • Icon: Minor Minor
    • ssh-slaves-plugin
    • None

      In order to avoid continued maintenance of a forked and dead SSH library (Trilead), we should migrate the code in SSH Build Agents to use Mina SSH. This will allow us to keep up to date with any cryptographic or security updates published upstream as well as support more SSH server configurations.

          [JENKINS-64106] Switch SSH client from Trilead to Apache Mina SSH

          First functional SSH client implemented with Apache Mina https://github.com/kuisathaverat/ssh-slaves-plugin/tree/apache_mina there is a new SSH Launcher on the launcher selector "Launch agents via SSH (Apache Mina SSHD)" this uses Apache Mina SSHD library for the connections.

          Ivan Fernandez Calvo added a comment - First functional SSH client implemented with Apache Mina https://github.com/kuisathaverat/ssh-slaves-plugin/tree/apache_mina there is a new SSH Launcher on the launcher selector "Launch agents via SSH (Apache Mina SSHD)" this uses Apache Mina SSHD library for the connections.

          Allan BURDAJEWICZ added a comment - - edited

          ifernandezcalvo I was wondering if maybe this should be relying on https://issues.jenkins.io/browse/JENKINS-64105 ?

          Allan BURDAJEWICZ added a comment - - edited ifernandezcalvo I was wondering if maybe this should be relying on https://issues.jenkins.io/browse/JENKINS-64105 ?

          Ivan Fernandez Calvo added a comment - - edited

          In the new implementation for Apache Mina SSH, I did not rely on the SSH Credentials plugin to verify or authenticate the SSH keys the correct implementation used for Trilead is unnecessary complex and does not add any value (5 lines of code VS ~100), it is something already implemented in the library.
          However, when I finish the work here I will stop maintaining Trilead SSH and at some point, the old Trilead SSH launcher should disappear.

          Ivan Fernandez Calvo added a comment - - edited In the new implementation for Apache Mina SSH, I did not rely on the SSH Credentials plugin to verify or authenticate the SSH keys the correct implementation used for Trilead is unnecessary complex and does not add any value (5 lines of code VS ~100), it is something already implemented in the library. However, when I finish the work here I will stop maintaining Trilead SSH and at some point, the old Trilead SSH launcher should disappear.

            ifernandezcalvo Ivan Fernandez Calvo
            jvz Matt Sicker
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: