We have a pipeline that reboots the operating system of the node during a test process.  To achieve this, it marks the node as temporarily unavailable, disconnects the node, and after the reboot is complete, re-launches the node.  With changes in 2.24, it seems that the node is left in a "slaveIsDisconnecting == Boolean.TRUE" state after the disconnect, which prevents the re-launch attempt with the message "Ignoring connect attempt to start the slave; it's being shutdown".

The change in https://github.com/jenkinsci/vsphere-cloud-plugin/commit/7ea9d7ae1d57b6f38456ddd6b92873f651bf317b seems to be the cause of this change in behavior, with the "vsSlave.slaveIsDisconnecting = Boolean.TRUE;" moved before the "slaveComputer.isTemporarilyOffline()" conditional which returns early, preventing the node from being shutdown.

Requesting that the earlier behavior be restored.