Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64372

"Comment added" based triggers broken since Gerrit 3.3

    XMLWordPrintable

Details

    Description

      Starting from Gerrit 3.3.0 messages sent via Reply dialog are posted as Patchset level comments (instead of Change messages), see [1-2]. It seems like a breaking change in Gerrit behaviour.

      gerrit-trigger-plugin doesn't support such Patchset level comments, so posting comments via Gerrit web UI is triggering Jenkins jobs in Gerrit 3.2 and is not triggering in Gerrit 3.3.

      [1] https://gerrit-review.googlesource.com/c/gerrit/+/266176
      [2] https://gerrit-review.googlesource.com/c/homepage/+/288131

      Attachments

        Activity

          gtjoseph George Joseph added a comment -

          Just ran across the same issue. I'd classify this as a bug not a new feature.

          gtjoseph George Joseph added a comment - Just ran across the same issue. I'd classify this as a bug not a new feature.

          Note: Gerrit configuration option event.comment-added.publishPatchSetLevelComment introduced in Gerrit 3.3.1 allows restoring the pre-3.3 behavior and thus working around this issue.

          jero Jerome Oufella added a comment - Note: Gerrit configuration option event.comment-added.publishPatchSetLevelComment introduced in Gerrit 3.3.1 allows restoring the pre-3.3 behavior and thus working around this issue.

          People

            rsandell rsandell
            vlotorev Vitaliy Lotorev
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated: