Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6446

Unit test rules should be symmetric

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Currently the failed test rule and the passed test rule are not symmetric.
      The failed test rule only gives points only for new failed test and the passed test rule only for new passed tests.
      I.e. skipped test are lost along the way.
      Example:
      Build n : SUCCESS, 610 passing tests
      Build n+1: UNSTABLE, 71 passing, 67 failed, 2963 skipped tests (TestNG has the strange behaviour that when the init of some test classes fails, the skipped count sky-rockets)
      Build n+2: SUCCESS, 610 passing tests

      Build n+1 gives 71 minus points
      Build n+2 gives 539 plus points

      So, by breaking the build and fixing it again you can 'unrightfully' get lots of points

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          kutzi kutzi created issue -
          Hide
          Permalink
          kutzi kutzi added a comment -

          Note that this was probably introduced by JENKINS-4449 which I proposed

          Show
          kutzi kutzi added a comment - Note that this was probably introduced by JENKINS-4449 which I proposed
          kutzi kutzi made changes -
          Field Original Value New Value
          Assignee redsolo [ redsolo ] kutzi [ kutzi ]
          Hide
          Permalink
          kutzi kutzi added a comment -

          I'm trying to create a patch for this

          Show
          kutzi kutzi added a comment - I'm trying to create a patch for this
          Hide
          Permalink
          lkamal Kamal Mettananda added a comment - - edited

          This issue is still occurring.

          I like to suggest following method of marks allocation. Hopefully this will resolve this inconsistency.

          • Passing test
            • added: +1
            • removed: -1
          • Failing test
            • added: -1
            • removed: +1
          • Skipped test (no marks given or reduced)
            • added: 0
            • removed: 0

          Following is the details of how all scenarios are handled.

          • Passing Tests
            • Passing test added = +1
              • [Increases passing count = +1]
            • Passing test removed = -1
              • [Decreases passing count = -1]
            • Passing an already failing test = +2
              • [Decreases failing count = +1]
              • [Increases passing count = +1]
            • Passing an already skipped test = +1
              • [Decreases skipped count = 0]
              • [Increases passing count = +1]
          • Failing tests
            • Failing test added = -1
              • [Increases failing count = -1]
            • Failing test removed = +1
              • [Decreases failing count = +1]
            • Failing an already passing test = -2
              • [Decreases passing count = -1]
              • [Increases failing count = -1]
            • Failing an already skipped test = -1
              • [Decreases skipped count = 0]
              • [Increases failing count = -1]
          • Skipped tests
            • Skipped test added = 0
              • [Increases skipped count = 0]
            • Skipped test removed = 0
              • [Decreases skipped count = 0]
            • Skipped an already passing test = -1
              • [Decreases passing count = -1]
              • [Increases skipped count = 0]
            • Skipped an already failing test = +1
              • [Decreases failing count = +1]
              • [Increases skipped count = 0]

          Note: Skipped tests are eventually ignored here, but intentionally adding calculators for them so that someone can give marks for skipped ones if required.

          Show
          lkamal Kamal Mettananda added a comment - - edited This issue is still occurring. I like to suggest following method of marks allocation. Hopefully this will resolve this inconsistency. Passing test added: +1 removed: -1 Failing test added: -1 removed: +1 Skipped test (no marks given or reduced) added: 0 removed: 0 Following is the details of how all scenarios are handled. Passing Tests Passing test added = +1 [Increases passing count = +1] Passing test removed = -1 [Decreases passing count = -1] Passing an already failing test = +2 [Decreases failing count = +1] [Increases passing count = +1] Passing an already skipped test = +1 [Decreases skipped count = 0] [Increases passing count = +1] Failing tests Failing test added = -1 [Increases failing count = -1] Failing test removed = +1 [Decreases failing count = +1] Failing an already passing test = -2 [Decreases passing count = -1] [Increases failing count = -1] Failing an already skipped test = -1 [Decreases skipped count = 0] [Increases failing count = -1] Skipped tests Skipped test added = 0 [Increases skipped count = 0] Skipped test removed = 0 [Decreases skipped count = 0] Skipped an already passing test = -1 [Decreases passing count = -1] [Increases skipped count = 0] Skipped an already failing test = +1 [Decreases failing count = +1] [Increases skipped count = 0] Note: Skipped tests are eventually ignored here, but intentionally adding calculators for them so that someone can give marks for skipped ones if required.
          lkamal Kamal Mettananda made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          kutzi kutzi made changes -
          Assignee kutzi [ kutzi ]
          lkamal Kamal Mettananda made changes -
          Assignee Kamal Mettananda [ lkamal ]
          lkamal Kamal Mettananda made changes -
          Remote Link This issue links to "Created a pull request for the fix (Web Link)" [ 10601 ]
          Hide
          Permalink
          lkamal Kamal Mettananda added a comment -

          Created a pull request for the fix https://github.com/jenkinsci/ci-game-plugin/pull/11

          Show
          lkamal Kamal Mettananda added a comment - Created a pull request for the fix https://github.com/jenkinsci/ci-game-plugin/pull/11
          Hide
          Permalink
          cappuccino Simon Gamma added a comment -

          I don't see why you'd want the removal of a passing test to be penalised by -1? Any particular reason?

          Also: I don't see why the removal of a failing test is rewarded by +1...? Maybe I'm misinterpreting?

          Show
          cappuccino Simon Gamma added a comment - I don't see why you'd want the removal of a passing test to be penalised by -1? Any particular reason? Also: I don't see why the removal of a failing test is rewarded by +1...? Maybe I'm misinterpreting?
          Hide
          Permalink
          lkamal Kamal Mettananda added a comment -

          Hi Simon,

          Let me try to explain my thought process. May be I have missed something.

          1) When a test is added, we grant +1 point. So if we do not reduce that +1 point when a testcase is removed, it does not help in calculating the correct score.

          • Someone might add/remove the same test case to exploit this flaw.

          2) When a test is failed, we grant -1 point. So if we do not compensate by giving a +1 when that testcase is removed, there again we do not maintain the correct score.

          Please share you thoughts on this so that we can discuss and improve the solution to provide a more symmetric scoring mechanism.

          Thanks.

          Show
          lkamal Kamal Mettananda added a comment - Hi Simon, Let me try to explain my thought process. May be I have missed something. 1) When a test is added, we grant +1 point. So if we do not reduce that +1 point when a testcase is removed, it does not help in calculating the correct score. Someone might add/remove the same test case to exploit this flaw. 2) When a test is failed, we grant -1 point. So if we do not compensate by giving a +1 when that testcase is removed, there again we do not maintain the correct score. Please share you thoughts on this so that we can discuss and improve the solution to provide a more symmetric scoring mechanism. Thanks.
          Hide
          Permalink
          cappuccino Simon Gamma added a comment -

          Thank you for the explanations. I can now understand why you're doing it this way. However, I think that a scoring algorithm implemented this way penalises and rewards in wrong cases...

          1) If a developer is refactoring, it may often happen that a Testcase becomes obsolete (e.g. if the Code under Test changes very much) -> we shouldn't deduct points in such cases, should we? It is ok to delete Tests that are no longer useful.

          2) Awarding +1 point if a user deletes a failing test we encourage the developers to delete tests (which is easy) instead of fixing them (which can be hard).

          What are your thoughts on these cases?

          Show
          cappuccino Simon Gamma added a comment - Thank you for the explanations. I can now understand why you're doing it this way. However, I think that a scoring algorithm implemented this way penalises and rewards in wrong cases... 1) If a developer is refactoring, it may often happen that a Testcase becomes obsolete (e.g. if the Code under Test changes very much) -> we shouldn't deduct points in such cases, should we? It is ok to delete Tests that are no longer useful. 2) Awarding +1 point if a user deletes a failing test we encourage the developers to delete tests (which is easy) instead of fixing them (which can be hard). What are your thoughts on these cases?
          Hide
          Permalink
          lkamal Kamal Mettananda added a comment -

          Yes Simon, you have raised valid points. I will add more explanation, hope my responses are only improving the status of the discussion (than hindering it).

          1). So when someone is refactoring, if a testcase is removed; then author is loosing only the mark that was previously granted for the testcase addition; so this might be reasonable. However, as you correctly suggested if the one who added the testcase and deleted the testcase are two users, then it is kind of a problem since +1 was given for someone, but reduced from someone else.
          If we are not going to remove that already granted mark, the symmetry is gone. How should we correct this? Any suggestions...

          2). Here also, when a test was added we granted +1, then when test started failing we granted -2 against that user. So I thought of granting just +1 mark when this failing test is removed, so that the author is finally receiving 0 marks for the whole trip. (However if he/she fix a failing test, +2 will be granted).

          It would be great if we could decide on what points to be granted on each of the 12 scenarios (+ any missing), so that we can resolve the asymmetric marks granting issue.

          Show
          lkamal Kamal Mettananda added a comment - Yes Simon, you have raised valid points. I will add more explanation, hope my responses are only improving the status of the discussion (than hindering it). 1). So when someone is refactoring, if a testcase is removed; then author is loosing only the mark that was previously granted for the testcase addition; so this might be reasonable. However, as you correctly suggested if the one who added the testcase and deleted the testcase are two users, then it is kind of a problem since +1 was given for someone, but reduced from someone else. If we are not going to remove that already granted mark, the symmetry is gone. How should we correct this? Any suggestions... 2). Here also, when a test was added we granted +1, then when test started failing we granted -2 against that user. So I thought of granting just +1 mark when this failing test is removed, so that the author is finally receiving 0 marks for the whole trip. (However if he/she fix a failing test, +2 will be granted). It would be great if we could decide on what points to be granted on each of the 12 scenarios (+ any missing), so that we can resolve the asymmetric marks granting issue.
          Hide
          Permalink
          lkamal Kamal Mettananda added a comment -

          Hi Simon & all,

          I have added global configurations for all the six types of unittest changes (increase or decrease of passed, failed and skipped tests).

          Given default values are:

          • Passing test
            • added: +1
            • removed: 0
          • Failing test
            • added: -1
            • removed: 0
          • Skipped test (no marks given or reduced)
            • added: 0
            • removed: 0

          The configuration is available under 'Continuous integration game - Unit Tests' section in advanced mode.

          If you could review this and see whether this can be incorporated or provide more input; it will be helpful.

          Thanks.

          Show
          lkamal Kamal Mettananda added a comment - Hi Simon & all, I have added global configurations for all the six types of unittest changes (increase or decrease of passed, failed and skipped tests). Given default values are: Passing test added: +1 removed: 0 Failing test added: -1 removed: 0 Skipped test (no marks given or reduced) added: 0 removed: 0 The configuration is available under 'Continuous integration game - Unit Tests' section in advanced mode. If you could review this and see whether this can be incorporated or provide more input; it will be helpful. Thanks.
          Hide
          Permalink
          lkamal Kamal Mettananda added a comment -

          Here is the pull request https://github.com/jenkinsci/ci-game-plugin/pull/11

          Show
          lkamal Kamal Mettananda added a comment - Here is the pull request https://github.com/jenkinsci/ci-game-plugin/pull/11
          lkamal Kamal Mettananda made changes -
          Attachment CI-Game-UnitTest-Points.png [ 24571 ]
          Hide
          Permalink
          lkamal Kamal Mettananda added a comment -

          Is it possible for someone to review this pull request please?

          Show
          lkamal Kamal Mettananda added a comment - Is it possible for someone to review this pull request please?
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: lkamal
          Path:
          src/main/java/hudson/plugins/cigame/rules/build/BuildResultRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractFailedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractPassedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractSkippedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractUnitTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingFailedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingPassedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingSkippedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingSkippedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/RemovedFailedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/RemovedPassedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/UnitTestingRuleSet.java
          src/main/resources/hudson/plugins/cigame/rules/unittesting/Messages.properties
          src/test/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRuleTest.java
          src/test/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRuleTest.java
          src/test/java/hudson/plugins/cigame/rules/unittesting/MavenMultiModuleUnitTestsTest.java
          http://jenkins-ci.org/commit/ci-game-plugin/081f250e4d42cf5f2e6194f57f6e9d0cbf47d9c2
          Log:
          [FIXED JENKINS-6446] Modified the scoring mechanism as follows to avoid the inconsistency in granting marks.
          Passing test
          added: +1
          removed: -1
          Failing test
          added: -1
          removed: +1
          Skipped test (no marks given or reduced)
          added: 0
          removed: 0

          Following is the details of how all scenarios are handled.

          Passing Tests
          Passing test added = +1
          [Increases passing count = +1]
          Passing test removed = -1
          [Decreases passing count = -1]
          Passing an already failing test = +2
          [Decreases failing count = +1]
          [Increases passing count = +1]
          Passing an already skipped test = +1
          [Decreases skipped count = 0]
          [Increases passing count = +1]

          Failing tests
          Failing test added = -1
          [Increases failing count = -1]
          Failing test removed = +1
          [Decreases failing count = +1]
          Failing an already passing test = -2
          [Decreases passing count = -1]
          [Increases failing count = -1]
          Failing an already skipped test = -1
          [Decreases skipped count = 0]
          [Increases failing count = -1]

          Skipped tests
          Skipped test added = 0
          [Increases skipped count = 0]
          Skipped test removed = 0
          [Decreases skipped count = 0]
          Skipped an already passing test = -1
          [Decreases passing count = -1]
          [Increases skipped count = 0]
          Skipped an already failing test = +1
          [Decreases failing count = +1]
          [Increases skipped count = 0]

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: lkamal Path: src/main/java/hudson/plugins/cigame/rules/build/BuildResultRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractFailedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractPassedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractSkippedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractUnitTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingFailedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingPassedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingSkippedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingSkippedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/RemovedFailedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/RemovedPassedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/UnitTestingRuleSet.java src/main/resources/hudson/plugins/cigame/rules/unittesting/Messages.properties src/test/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRuleTest.java src/test/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRuleTest.java src/test/java/hudson/plugins/cigame/rules/unittesting/MavenMultiModuleUnitTestsTest.java http://jenkins-ci.org/commit/ci-game-plugin/081f250e4d42cf5f2e6194f57f6e9d0cbf47d9c2 Log: [FIXED JENKINS-6446] Modified the scoring mechanism as follows to avoid the inconsistency in granting marks. Passing test added: +1 removed: -1 Failing test added: -1 removed: +1 Skipped test (no marks given or reduced) added: 0 removed: 0 Following is the details of how all scenarios are handled. Passing Tests Passing test added = +1 [Increases passing count = +1] Passing test removed = -1 [Decreases passing count = -1] Passing an already failing test = +2 [Decreases failing count = +1] [Increases passing count = +1] Passing an already skipped test = +1 [Decreases skipped count = 0] [Increases passing count = +1] Failing tests Failing test added = -1 [Increases failing count = -1] Failing test removed = +1 [Decreases failing count = +1] Failing an already passing test = -2 [Decreases passing count = -1] [Increases failing count = -1] Failing an already skipped test = -1 [Decreases skipped count = 0] [Increases failing count = -1] Skipped tests Skipped test added = 0 [Increases skipped count = 0] Skipped test removed = 0 [Decreases skipped count = 0] Skipped an already passing test = -1 [Decreases passing count = -1] [Increases skipped count = 0] Skipped an already failing test = +1 [Decreases failing count = +1] [Increases skipped count = 0]
          scm_issue_link SCM/JIRA link daemon made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Resolved [ 5 ]
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: lkamal
          Path:
          src/main/java/hudson/plugins/cigame/rules/build/BuildResultRule.java
          http://jenkins-ci.org/commit/ci-game-plugin/e796a32831959f0e22490a5718eba71b11611e3f
          Log:
          [FIXED JENKINS-6446] Removing a TODO added for future references

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: lkamal Path: src/main/java/hudson/plugins/cigame/rules/build/BuildResultRule.java http://jenkins-ci.org/commit/ci-game-plugin/e796a32831959f0e22490a5718eba71b11611e3f Log: [FIXED JENKINS-6446] Removing a TODO added for future references
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: lkamal
          Path:
          pom.xml
          src/main/java/hudson/plugins/cigame/GameDescriptor.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingFailedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingPassedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingSkippedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingSkippedTestsRule.java
          src/main/resources/hudson/plugins/cigame/GamePublisher/global.jelly
          src/main/resources/hudson/plugins/cigame/GamePublisher/global.properties
          src/main/resources/hudson/plugins/cigame/GamePublisher/help-failedTestDecreasingPoints.html
          src/main/resources/hudson/plugins/cigame/GamePublisher/help-failedTestIncreasingPoints.html
          src/main/resources/hudson/plugins/cigame/GamePublisher/help-passedTestDecreasingPoints.html
          src/main/resources/hudson/plugins/cigame/GamePublisher/help-passedTestIncreasingPoints.html
          src/main/resources/hudson/plugins/cigame/GamePublisher/help-skippedTestDecreasingPoints.html
          src/main/resources/hudson/plugins/cigame/GamePublisher/help-skippedTestIncreasingPoints.html
          src/test/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRuleTest.java
          src/test/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRuleTest.java
          src/test/java/hudson/plugins/cigame/rules/unittesting/MavenMultiModuleUnitTestsTest.java
          http://jenkins-ci.org/commit/ci-game-plugin/626af1ccd3ce3eee662f9a567b114c4cc095fdd3
          Log:
          [FIXED JENKINS-6446] Added global configurations for all the six types of unittest changes (increase or descrease of passed, failed and skipped tests). The configuration is available under 'Continuous integration game - Unit Tests' section in advanced mode. Default values are set to 1 for increasing passing tests, -1 for increasing failed tests and 0 for all other 4 scenarios

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: lkamal Path: pom.xml src/main/java/hudson/plugins/cigame/GameDescriptor.java src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingFailedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingPassedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingSkippedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingSkippedTestsRule.java src/main/resources/hudson/plugins/cigame/GamePublisher/global.jelly src/main/resources/hudson/plugins/cigame/GamePublisher/global.properties src/main/resources/hudson/plugins/cigame/GamePublisher/help-failedTestDecreasingPoints.html src/main/resources/hudson/plugins/cigame/GamePublisher/help-failedTestIncreasingPoints.html src/main/resources/hudson/plugins/cigame/GamePublisher/help-passedTestDecreasingPoints.html src/main/resources/hudson/plugins/cigame/GamePublisher/help-passedTestIncreasingPoints.html src/main/resources/hudson/plugins/cigame/GamePublisher/help-skippedTestDecreasingPoints.html src/main/resources/hudson/plugins/cigame/GamePublisher/help-skippedTestIncreasingPoints.html src/test/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRuleTest.java src/test/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRuleTest.java src/test/java/hudson/plugins/cigame/rules/unittesting/MavenMultiModuleUnitTestsTest.java http://jenkins-ci.org/commit/ci-game-plugin/626af1ccd3ce3eee662f9a567b114c4cc095fdd3 Log: [FIXED JENKINS-6446] Added global configurations for all the six types of unittest changes (increase or descrease of passed, failed and skipped tests). The configuration is available under 'Continuous integration game - Unit Tests' section in advanced mode. Default values are set to 1 for increasing passing tests, -1 for increasing failed tests and 0 for all other 4 scenarios
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: lkamal
          Path:
          src/main/resources/hudson/plugins/cigame/GamePublisher/global.jelly
          http://jenkins-ci.org/commit/ci-game-plugin/57b43778dfffa7b1dec25dcb6123b40c2993e195
          Log:
          [FIXED JENKINS-6446] Modified the global config view of unit tests so that it will be displayed in a separate table rather than using a top level title

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: lkamal Path: src/main/resources/hudson/plugins/cigame/GamePublisher/global.jelly http://jenkins-ci.org/commit/ci-game-plugin/57b43778dfffa7b1dec25dcb6123b40c2993e195 Log: [FIXED JENKINS-6446] Modified the global config view of unit tests so that it will be displayed in a separate table rather than using a top level title
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: simschla
          Path:
          pom.xml
          src/main/java/hudson/plugins/cigame/GameDescriptor.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractFailedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractPassedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractSkippedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractUnitTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingFailedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingPassedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingSkippedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingSkippedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/RemovedFailedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/RemovedPassedTestsRule.java
          src/main/java/hudson/plugins/cigame/rules/unittesting/UnitTestingRuleSet.java
          src/main/resources/hudson/plugins/cigame/GamePublisher/global.jelly
          src/main/resources/hudson/plugins/cigame/GamePublisher/global.properties
          src/main/resources/hudson/plugins/cigame/GamePublisher/help-failedTestDecreasingPoints.html
          src/main/resources/hudson/plugins/cigame/GamePublisher/help-failedTestIncreasingPoints.html
          src/main/resources/hudson/plugins/cigame/GamePublisher/help-passedTestDecreasingPoints.html
          src/main/resources/hudson/plugins/cigame/GamePublisher/help-passedTestIncreasingPoints.html
          src/main/resources/hudson/plugins/cigame/GamePublisher/help-skippedTestDecreasingPoints.html
          src/main/resources/hudson/plugins/cigame/GamePublisher/help-skippedTestIncreasingPoints.html
          src/main/resources/hudson/plugins/cigame/rules/unittesting/Messages.properties
          src/test/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRuleTest.java
          src/test/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRuleTest.java
          src/test/java/hudson/plugins/cigame/rules/unittesting/MavenMultiModuleUnitTestsTest.java
          http://jenkins-ci.org/commit/ci-game-plugin/c66201634b4310a7e1bb157c36026631093b22c1
          Log:
          Merge pull request #11 from lkamal/master

          [FIXED JENKINS-6446] added global configurations for all the six types of unittest changes (increase or descrease of passed, failed and skipped tests)

          Compare: https://github.com/jenkinsci/ci-game-plugin/compare/321ce5b740db...c66201634b43

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: simschla Path: pom.xml src/main/java/hudson/plugins/cigame/GameDescriptor.java src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractFailedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractPassedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractSkippedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/AbstractUnitTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingFailedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingPassedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/DecreasingSkippedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/IncreasingSkippedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/RemovedFailedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/RemovedPassedTestsRule.java src/main/java/hudson/plugins/cigame/rules/unittesting/UnitTestingRuleSet.java src/main/resources/hudson/plugins/cigame/GamePublisher/global.jelly src/main/resources/hudson/plugins/cigame/GamePublisher/global.properties src/main/resources/hudson/plugins/cigame/GamePublisher/help-failedTestDecreasingPoints.html src/main/resources/hudson/plugins/cigame/GamePublisher/help-failedTestIncreasingPoints.html src/main/resources/hudson/plugins/cigame/GamePublisher/help-passedTestDecreasingPoints.html src/main/resources/hudson/plugins/cigame/GamePublisher/help-passedTestIncreasingPoints.html src/main/resources/hudson/plugins/cigame/GamePublisher/help-skippedTestDecreasingPoints.html src/main/resources/hudson/plugins/cigame/GamePublisher/help-skippedTestIncreasingPoints.html src/main/resources/hudson/plugins/cigame/rules/unittesting/Messages.properties src/test/java/hudson/plugins/cigame/rules/unittesting/IncreasingFailedTestsRuleTest.java src/test/java/hudson/plugins/cigame/rules/unittesting/IncreasingPassedTestsRuleTest.java src/test/java/hudson/plugins/cigame/rules/unittesting/MavenMultiModuleUnitTestsTest.java http://jenkins-ci.org/commit/ci-game-plugin/c66201634b4310a7e1bb157c36026631093b22c1 Log: Merge pull request #11 from lkamal/master [FIXED JENKINS-6446] added global configurations for all the six types of unittest changes (increase or descrease of passed, failed and skipped tests) Compare: https://github.com/jenkinsci/ci-game-plugin/compare/321ce5b740db...c66201634b43
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 136541 ] JNJira + In-Review [ 187225 ]

            People

            Assignee:
            lkamal Kamal Mettananda
            Reporter:
            kutzi kutzi
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: