Details
-
Bug
-
Status: In Review (View Workflow)
-
Major
-
Resolution: Unresolved
-
jdk-11.0.10.jdk, remoting-2.34.jar
Description
I am getting the following error after updating to jdk11.
Exception in thread "main" java.lang.IllegalArgumentException: object is not an instance of declaring class
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at hudson.remoting.Launcher.addClasspath(Launcher.java:129)
On analysing the remoting source code found that the hudson.remoting.Launcher.addClasspath invokes URLClassLoader and passes the instance using ClassLoader.getSystemClassLoader().
$addURL.invoke(ClassLoader.getSystemClassLoader(),new File(token).toURI().toURL());
However in java 11, this seems like an illegal operation as ClassLoader.getSystemClassLoader() does not get the instance of URLClassLoader due to which we are getting the error "object is not an instance of declaring class".
To fix this issue what I have updated the addClasspath to invoke the URLClassLoader using a new instance of the class
$addURL.invoke(URLClassLoader.newInstance(urls),new File(token).toURI().toURL());
This resolved the issue.
Kindly verify if this approach is apt.
Attachments
Activity
Jeff Thompson
added a comment - If the version is correct, then it definitely isn't supported. Otherwise, we'll probably need more information about the scenario to understand what distinguishes this from other, known working ones.
Jeff Thompson
added a comment - If the version is correct, then it definitely isn't supported. Otherwise, we'll probably need more information about the scenario to understand what distinguishes this from other, known working ones. Hello, I have update the the version to 4.7 still facing the same issue.
On analysing the remoting source code found that the hudson.remoting.Launcher.addClasspath invokes URLClassLoader and passes the instance using ClassLoader.getSystemClassLoader().
However in java 11, this seems like an illegal operation as ClassLoader.getSystemClassLoader() does not get the instance of URLClassLoader due to which we are getting the error "object is not an instance of declaring class".
Are you really using remoting 2.34? That was released in 2013. The current release of the remoting jar is remoting-4.7 per https://github.com/jenkinsci/remoting/releases/tag/remoting-4.7
Remoting has been running with Java 11 for over a year, possibly over two years now.