Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-65511

Checkboxes not aligned with corresponding options and their heading (regression in 2.264)

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 364.v48a_33389553d

      How to reproduce?

      • Create a new view
      • Click on "Add Job Filter"
      • Select "Build Statuses Filter" and "User Permissions for Jobs"

      Bug Description:
      While tweaking the "View Job Filters" plugin I see these 3 checkboxes under the "Build Statuses Filter" section (shown in pic):

      • Currently Building,
      • Never Built and,
      • In Build Queue

      I was wondering if "Build Statuses:" should be placed before the first checkbox (and/or above all 3 checkboxes)? The same bug can be seen under the "User Permissions for Jobs" section.

          [JENKINS-65511] Checkboxes not aligned with corresponding options and their heading (regression in 2.264)

          Dheeraj Singh added a comment -

          I cloned the repo of this plugin and then started a local Jenkins instance with the view-job-filter plugin included using the command "mvn hpi:run",
          However, then I see the alignment of checkboxes and heading to be perfectly right (as seen in the picture)

          Dheeraj Singh added a comment - I cloned the repo of this plugin and then started a local Jenkins instance with the view-job-filter plugin included using the command " mvn hpi:run ", However, then I see the alignment of checkboxes and heading to be perfectly right (as seen in the picture)

          Mark Waite added a comment -

          Issue is also visible in Jenkins 2.319.1 where it looks like this:

          Issue is also visible in Jenkins 2.328 pre-release where it looks like this:

          Mark Waite added a comment - Issue is also visible in Jenkins 2.319.1 where it looks like this: Issue is also visible in Jenkins 2.328 pre-release where it looks like this:

          Stijn Haers added a comment -

          Same issue on jenkins 2.319.3 with view-job-filters 2.3:

          If I inspect the html code in my browser following issues:
          1. Job Statuses is enclosed in 'label' tags while it's not a label of a checkbox

          2. All job states are NOT enclosed in the label tag, but just next to it

           

          I'm not a web developer, but I think it should be like this:

          The differences:
          1. No extra title 'Build Statuses', it's already stated just above, no need to repeat it

          2. All labels are enclosed in the label tags

          3. All labels have the 'for' attribute, which makes that you can double click the label to check/uncheck the checkbox.

          Stijn Haers added a comment - Same issue on jenkins 2.319.3 with view-job-filters 2.3: If I inspect the html code in my browser following issues: 1. Job Statuses is enclosed in 'label' tags while it's not a label of a checkbox 2. All job states are NOT enclosed in the label tag, but just next to it   I'm not a web developer, but I think it should be like this: The differences: 1. No extra title 'Build Statuses', it's already stated just above, no need to repeat it 2. All labels are enclosed in the label tags 3. All labels have the 'for' attribute, which makes that you can double click the label to check/uncheck the checkbox.

          Dheeraj Singh added a comment -

          Hi sha512,

          Thank you for your detailed comments and screenshots with labels. This is very helpful for me as I was not able to find a fix for this when I last looked at it. I'll try what you've suggested and update here the results.

          Thanks again!

          Dheeraj Singh added a comment - Hi sha512 , Thank you for your detailed comments and screenshots with labels. This is very helpful for me as I was not able to find a fix for this when I last looked at it. I'll try what you've suggested and update here the results. Thanks again!

          Mark Waite added a comment - - edited

          Confirmed still an issue with latest release of view filter plugin and Jenkins 2.346.1

          Should be able to see that from a debugger or development environment with

          mvn clean -Djenkins.version=2.346.1 hpi:run

          Mark Waite added a comment - - edited Confirmed still an issue with latest release of view filter plugin and Jenkins 2.346.1 Should be able to see that from a debugger or development environment with mvn clean -Djenkins.version=2.346.1 hpi:run

          Basil Crow added a comment -

          Bisected this to

          commit 87b72f57c3
          Author: Josh Soref <jsoref@users.noreply.github.com>
          Date:   Fri Oct 23 11:36:38 2020
          
              [JENKINS-56109] Change Jenkins configuration UI from tables to divs (#3895)
              
              Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
              Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
              Co-authored-by: Félix Queiruga <fqueiruga@cloudbees.com>
              Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
              Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
          

          Basil Crow added a comment - Bisected this to commit 87b72f57c3 Author: Josh Soref <jsoref@users.noreply.github.com> Date: Fri Oct 23 11:36:38 2020 [JENKINS-56109] Change Jenkins configuration UI from tables to divs (#3895) Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com> Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com> Co-authored-by: Félix Queiruga <fqueiruga@cloudbees.com> Co-authored-by: Tim Jacomb <t.jacomb@kainos.com> Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>

          Tim Jacomb added a comment -

          Addressed in https://github.com/jenkinsci/view-job-filters-plugin/pull/29

          i.e. actually using labels . (as commented earlier in this thread)

          Tim Jacomb added a comment - Addressed in https://github.com/jenkinsci/view-job-filters-plugin/pull/29 i.e. actually using labels . (as commented earlier in this thread)

            pascal9117 shuhuai Chang
            iamdheerajs Dheeraj Singh
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: