Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-65745

Multi-project Throttle Category checkboxes layout problem

    XMLWordPrintable

Details

    • 2.4

    Description

      In the job configuration screen, the Multi-Project Throttle Category checkboxes are not aligned with respective category labels.

      The checkbox on the left of section title is actually related to the first category.

      This may lead to confusion when configuring jobs.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          lluccia Leandro Conca added a comment -

          I was able to create an initial solution replacing the label element by the title attribute in the checkbox.

          https://github.com/lluccia/throttle-concurrent-builds-plugin/commit/0ea0012616191a465283cae93128d23af2a33b43?branch=0ea0012616191a465283cae93128d23af2a33b43&diff=unified

          lluccia Leandro Conca added a comment - I was able to create an initial solution replacing the label element by the title attribute in the checkbox. https://github.com/lluccia/throttle-concurrent-builds-plugin/commit/0ea0012616191a465283cae93128d23af2a33b43?branch=0ea0012616191a465283cae93128d23af2a33b43&diff=unified
          basil Basil Crow added a comment -

          Thanks for reporting this, lluccia. Would you be willing to open a pull request with the above change, including screenshots of the behavior before and after? While I'm not a frontend developer myself, I'm sure we could find others in the Jenkins community (maybe from the UX Sig) to review the change. I'd then be happy to merge and release the fix.

          basil Basil Crow added a comment - Thanks for reporting this, lluccia . Would you be willing to open a pull request with the above change, including screenshots of the behavior before and after? While I'm not a frontend developer myself, I'm sure we could find others in the Jenkins community (maybe from the UX Sig) to review the change. I'd then be happy to merge and release the fix.
          lluccia Leandro Conca added a comment -

          I opened the pull request https://github.com/jenkinsci/throttle-concurrent-builds-plugin/pull/127 for review.

          Thanks.

          lluccia Leandro Conca added a comment - I opened the pull request https://github.com/jenkinsci/throttle-concurrent-builds-plugin/pull/127 for review. Thanks.
          martinjost Martin Jost added a comment -

          Added "tables-to-divs-regression" -label to make it visible in dashboard

          martinjost Martin Jost added a comment - Added " tables-to-divs-regression" -label to make it visible in dashboard
          basil Basil Crow added a comment -

          Fixed in jenkinsci/throttle-concurrent-builds-plugin#127. Released in 2.4.

          basil Basil Crow added a comment - Fixed in jenkinsci/throttle-concurrent-builds-plugin#127 . Released in 2.4 .

          People

            lluccia Leandro Conca
            lluccia Leandro Conca
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: