Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-65745

Multi-project Throttle Category checkboxes layout problem

XMLWordPrintable

    • 2.4

      In the job configuration screen, the Multi-Project Throttle Category checkboxes are not aligned with respective category labels.

      The checkbox on the left of section title is actually related to the first category.

      This may lead to confusion when configuring jobs.

        1. 4724335fe3d44dceb902a3374128f7e1.png
          4724335fe3d44dceb902a3374128f7e1.png
          62 kB

          [JENKINS-65745] Multi-project Throttle Category checkboxes layout problem

          Leandro Conca added a comment -

          I was able to create an initial solution replacing the label element by the title attribute in the checkbox.

          https://github.com/lluccia/throttle-concurrent-builds-plugin/commit/0ea0012616191a465283cae93128d23af2a33b43?branch=0ea0012616191a465283cae93128d23af2a33b43&diff=unified

          Leandro Conca added a comment - I was able to create an initial solution replacing the label element by the title attribute in the checkbox. https://github.com/lluccia/throttle-concurrent-builds-plugin/commit/0ea0012616191a465283cae93128d23af2a33b43?branch=0ea0012616191a465283cae93128d23af2a33b43&diff=unified

          Basil Crow added a comment -

          Thanks for reporting this, lluccia. Would you be willing to open a pull request with the above change, including screenshots of the behavior before and after? While I'm not a frontend developer myself, I'm sure we could find others in the Jenkins community (maybe from the UX Sig) to review the change. I'd then be happy to merge and release the fix.

          Basil Crow added a comment - Thanks for reporting this, lluccia . Would you be willing to open a pull request with the above change, including screenshots of the behavior before and after? While I'm not a frontend developer myself, I'm sure we could find others in the Jenkins community (maybe from the UX Sig) to review the change. I'd then be happy to merge and release the fix.

          Leandro Conca added a comment -

          I opened the pull request https://github.com/jenkinsci/throttle-concurrent-builds-plugin/pull/127 for review.

          Thanks.

          Leandro Conca added a comment - I opened the pull request https://github.com/jenkinsci/throttle-concurrent-builds-plugin/pull/127 for review. Thanks.

          Martin Jost added a comment -

          Added "tables-to-divs-regression" -label to make it visible in dashboard

          Martin Jost added a comment - Added " tables-to-divs-regression" -label to make it visible in dashboard

          Basil Crow added a comment -

          Fixed in jenkinsci/throttle-concurrent-builds-plugin#127. Released in 2.4.

          Basil Crow added a comment - Fixed in jenkinsci/throttle-concurrent-builds-plugin#127 . Released in 2.4 .

            lluccia Leandro Conca
            lluccia Leandro Conca
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: