Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-66016

Artifactory Build Info link leads to 404 in Plugin version 3.11.4

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Critical Critical
    • artifactory-plugin
    • None
    • Jenkins 2.289.1 LTS
      Artifactory Plugin 3.11.4

      With the Artifactory-plugin in the version 3.11.4 the "Artifactory Build Info"-link on the page of a build leads to a 404 page in Artifactory.

       

      A downgrade to Artifactory-plugin 3.10.6 solves the problem.

       

      When looking at the link they look like this:

      v3.11.4:

      v3.10.6: 

          [JENKINS-66016] Artifactory Build Info link leads to 404 in Plugin version 3.11.4

          Jon Sten added a comment -

          As far as I can tell from this comment (https://github.com/jfrog/jenkins-artifactory-plugin/pull/515#issuecomment-867609065) it was a deliberate change. Problem is/was that old artifact links, produced the plugin prior to 3.11.4 was stored incorrectly and was double escaped on disk. The PR above fixes that issue by not escaping before storing on disk (and only relying on escaping done by XML serializer). The downside with that is that links produced before the new version of the plugin didn't get escaped twice anymore, which leads to incorrect links. When we made the PR we accounted for that, but the maintainer of the plugin decided not to include that change, and instead accept the broken links. After all, the links will only affect old links which was produced by older versions of the plugin, and over time they will disappear.

          Jon Sten added a comment - As far as I can tell from this comment ( https://github.com/jfrog/jenkins-artifactory-plugin/pull/515#issuecomment-867609065 ) it was a deliberate change. Problem is/was that old artifact links, produced the plugin prior to 3.11.4 was stored incorrectly and was double escaped on disk. The PR above fixes that issue by not escaping before storing on disk (and only relying on escaping done by XML serializer). The downside with that is that links produced before the new version of the plugin didn't get escaped twice anymore, which leads to incorrect links. When we made the PR we accounted for that, but the maintainer of the plugin decided not to include that change, and instead accept the broken links. After all, the links will only affect old links which was produced by older versions of the plugin, and over time they will disappear.

            eyalbe Eyal Ben Moshe
            christopha Christoph
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: