Details
-
New Feature
-
Status: Closed (View Workflow)
-
Minor
-
Resolution: Fixed
Description
Hi,
in my company we use old perforce plugin in freestyle jobs, they mostly run incremental builds (one perforce changelist at a time), but sometimes we need to wipe out workspace and build all pending changelist at once.
Old (legacy) perforce plugin has "P4ONECHANGELIST" parameter support, which, when enabled, builds only the oldest, not yet build change returned by polling routine.
This is supported by p4 plugin using "incremental" clause, but is available only in declarative pipelines.
I'd like to have similar, parametrized feature in p4 plugin, but for freestyle jobs. I know there is "Polling per change" filter, but it's not parametrized in any way (or I can't find how to do it).
I have attached a short diff, that acts as if "Polling per change" field was active, if there is P4_INCREMENTAL environment variable set to "true" or not defined at all, and inactive if P4_INCREMENTAL environment variable is "false" .
I have attached diff file. Is it possible to include this change in p4 plugin release?
Kind regards,
Daniel Jeznach
Attachments
Activity
Thank you for taking look at this. I know about "incremental" filter, however have not found a way how parametrize it in FreeStyleProjects.
I have attached diff, it checks if current run is FreeStyleBuild, if so, it calls the same code as if "incremental" filter were used. This way it can be parametrized using "P4_INCREMENTAL build parameter (boolean).
Daniel Jeznach
added a comment - - edited Thank you for taking look at this. I know about "incremental" filter, however have not found a way how parametrize it in FreeStyleProjects.
I have attached diff, it checks if current run is FreeStyleBuild, if so, it calls the same code as if "incremental" filter were used. This way it can be parametrized using "P4_INCREMENTAL build parameter (boolean).
Karl Wirth
added a comment - Hi daniel_jeznach_img - Thanks. Just to confirm that my 'Additional Information' was for our developers and QA so they could easily see where the enhancement was required.
If you would like to submit a shelve for the devlopers to review please feel free to: https://github.com/jenkinsci/p4-plugin
We are always looking for community contributoirs to help improve the project.
Karl Wirth
added a comment - Hi daniel_jeznach_img - Thanks. Just to confirm that my 'Additional Information' was for our developers and QA so they could easily see where the enhancement was required.
If you would like to submit a shelve for the devlopers to review please feel free to: https://github.com/jenkinsci/p4-plugin
We are always looking for community contributoirs to help improve the project.
Daniel Jeznach
added a comment - I've created a pull request for this one. I tried to comply to all guidelines, I hope the code will meet your standards.
Daniel Jeznach
added a comment - I've created a pull request for this one. I tried to comply to all guidelines, I hope the code will meet your standards. Karl Wirth
added a comment - daniel_jeznach_img- Thanks.
FYI p4paul Pull request - https://github.com/jenkinsci/p4-plugin/pull/129
Karl Wirth
added a comment - daniel_jeznach_img - Thanks.
FYI p4paul Pull request - https://github.com/jenkinsci/p4-plugin/pull/129 
Paul Allen
added a comment - Released in 1.11.6 
daniel_jeznach_img- Thanks. I will highlight it onto the developers:
Additional information:
In pipeline it is possible to code the 'filter:[incremental(true)]' to take a variable instead of 'true' to control behavior on the fly. In Fresstyle you dont have this flexibility. The 'Enabled' tickbox is either always on or always off:
This request is asking for an override as a paramater to the job.