Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-66305

Prepare Jira for core Guava upgrade

    XMLWordPrintable

    Details

    • Similar Issues:
    • Released As:
      3.6

      Description

      See JENKINS-65988. Jenkins core is using Guava 11.0.1, which was released on January 9, 2012. Jenkins core would like to upgrade to Guava 30.1.1, which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.

      Caffeine

      In particular, this plugin has been identified as using the com.google.common.cache.Cache#get(K key) API, which has been removed between Guava 11.0.1 and latest. The removal took place in Guava 12.0.

      To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The recommendation is for plugins to migrate from Guava's cache to Caffeine via the Jenkins Caffeine API plugin.

      For the most part, the migration is a trivial matter of replacing imports of com.google.common.cache.Cache with imports of com.github.benmanes.caffeine.cache.Cache and imports of com.google.common.cache.CacheBuilder with imports of com.github.benmanes.caffeine.cache.Caffeine. For examples of how to do this, see these existing PRs:

      Objects#firstNonNull

      In particular, this plugin has been identified as using the com.google.common.base.Objects#firstNonNull method, which existed in Guava 11.0.1 but was removed in later versions.

      To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to migrate away from Objects#firstNonNull and rewrite the code to use the native functionality provided by the Java Platform.

      For an example of how to do this, see:

        Attachments

          Activity

          Hide
          basil Basil Crow added a comment -
          Show
          basil Basil Crow added a comment - Olivier Lamy FYI
          Hide
          olamy Olivier Lamy added a comment -

          Basil Crow thanks.  I will have a look next week. 

          Show
          olamy Olivier Lamy added a comment - Basil Crow  thanks.  I will have a look next week. 
          Hide
          basil Basil Crow added a comment -

          Fixed in jenkinsci/jira-plugin#368. Released in 3.6.

          Show
          basil Basil Crow added a comment - Fixed in jenkinsci/jira-plugin#368 . Released in 3.6 .

            People

            Assignee:
            olamy Olivier Lamy
            Reporter:
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: