• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • jira-plugin
    • 3.6

      See JENKINS-65988. Jenkins core is using Guava 11.0.1, which was released on January 9, 2012. Jenkins core would like to upgrade to Guava 30.1.1, which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.

      Caffeine

      In particular, this plugin has been identified as using the com.google.common.cache.Cache#get(K key) API, which has been removed between Guava 11.0.1 and latest. The removal took place in Guava 12.0.

      To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The recommendation is for plugins to migrate from Guava's cache to Caffeine via the Jenkins Caffeine API plugin.

      For the most part, the migration is a trivial matter of replacing imports of com.google.common.cache.Cache with imports of com.github.benmanes.caffeine.cache.Cache and imports of com.google.common.cache.CacheBuilder with imports of com.github.benmanes.caffeine.cache.Caffeine. For examples of how to do this, see these existing PRs:

      Objects#firstNonNull

      In particular, this plugin has been identified as using the com.google.common.base.Objects#firstNonNull method, which existed in Guava 11.0.1 but was removed in later versions.

      To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to migrate away from Objects#firstNonNull and rewrite the code to use the native functionality provided by the Java Platform.

      For an example of how to do this, see:

          [JENKINS-66305] Prepare Jira for core Guava upgrade

          Basil Crow created issue -
          Basil Crow made changes -
          Assignee New: Radek Antoniuk [ warden ]

          Basil Crow added a comment -

          olamy FYI

          Basil Crow added a comment - olamy FYI
          Basil Crow made changes -
          Description Original: See JENKINS-65988. Jenkins core is using [Guava 11.0.1|https://github.com/google/guava/releases/tag/v11.0.1], which was released on January 9, 2012. Jenkins core would like to upgrade to [Guava 30.1.1|https://github.com/google/guava/releases/tag/v30.1.1], which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.

          In particular, this plugin has been identified as using the {{com.google.common.cache.Cache#get(K key)}} API, which has been removed between Guava [11.0.1|https://guava.dev/releases/11.0.1/api/docs/com/google/common/cache/Cache.html] and [latest|https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/cache/Cache.html]. The removal took place in Guava 12.0.

          To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The recommendation is for plugins to migrate from Guava's cache to [Caffeine|https://github.com/ben-manes/caffeine] via the Jenkins [Caffeine API|https://plugins.jenkins.io/caffeine-api/] plugin.

          For the most part, the migration is a trivial matter of replacing imports of {{com.google.common.cache.Cache}} with imports of {{com.github.benmanes.caffeine.cache.Cache}} and imports of {{com.google.common.cache.CacheBuilder}} with imports of {{com.github.benmanes.caffeine.cache.Caffeine}}. For examples of how to do this, see these existing PRs:

          * [jenkinsci/active-directory-plugin#109|https://github.com/jenkinsci/active-directory-plugin/pull/109]
          * [jenkinsci/azure-ad-plugin#125|https://github.com/jenkinsci/azure-ad-plugin/pull/125]
          * [jenkinsci/configuration-as-code-plugin#1596|https://github.com/jenkinsci/configuration-as-code-plugin/pull/1596]
          * [jenkinsci/kubernetes-plugin#991|https://github.com/jenkinsci/kubernetes-plugin/pull/991]
          * [jenkinsci/lockable-resources-plugin#242|https://github.com/jenkinsci/lockable-resources-plugin/pull/242]
          * [jenkinsci/role-strategy-plugin#150|https://github.com/jenkinsci/role-strategy-plugin/pull/150]
          New: See JENKINS-65988. Jenkins core is using [Guava 11.0.1|https://github.com/google/guava/releases/tag/v11.0.1], which was released on January 9, 2012. Jenkins core would like to upgrade to [Guava 30.1.1|https://github.com/google/guava/releases/tag/v30.1.1], which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.

          h3. Caffeine

          In particular, this plugin has been identified as using the {{com.google.common.cache.Cache#get(K key)}} API, which has been removed between Guava [11.0.1|https://guava.dev/releases/11.0.1/api/docs/com/google/common/cache/Cache.html] and [latest|https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/cache/Cache.html]. The removal took place in Guava 12.0.

          To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The recommendation is for plugins to migrate from Guava's cache to [Caffeine|https://github.com/ben-manes/caffeine] via the Jenkins [Caffeine API|https://plugins.jenkins.io/caffeine-api/] plugin.

          For the most part, the migration is a trivial matter of replacing imports of {{com.google.common.cache.Cache}} with imports of {{com.github.benmanes.caffeine.cache.Cache}} and imports of {{com.google.common.cache.CacheBuilder}} with imports of {{com.github.benmanes.caffeine.cache.Caffeine}}. For examples of how to do this, see these existing PRs:
           * [jenkinsci/active-directory-plugin#109|https://github.com/jenkinsci/active-directory-plugin/pull/109]
           * [jenkinsci/azure-ad-plugin#125|https://github.com/jenkinsci/azure-ad-plugin/pull/125]
           * [jenkinsci/configuration-as-code-plugin#1596|https://github.com/jenkinsci/configuration-as-code-plugin/pull/1596]
           * [jenkinsci/kubernetes-plugin#991|https://github.com/jenkinsci/kubernetes-plugin/pull/991]
           * [jenkinsci/lockable-resources-plugin#242|https://github.com/jenkinsci/lockable-resources-plugin/pull/242]
           * [jenkinsci/role-strategy-plugin#150|https://github.com/jenkinsci/role-strategy-plugin/pull/150]

          h3. Objects#firstNonNull

          In particular, this plugin has been identified as using the {{com.google.common.base.Objects#firstNonNull}} method, which existed in Guava [11.0.1|https://guava.dev/releases/11.0.1/api/docs/com/google/common/base/Objects.html] but was [removed in later versions|https://guava.dev/releases/snapshot-jre/api/docs/com/google/common/base/Objects.html].

          To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to migrate away from {{Objects#firstNonNull}} and rewrite the code to use the native functionality provided by the Java Platform.

          For an example of how to do this, see:

          * [jenkinsci/gearman-plugin#14|https://github.com/jenkinsci/gearman-plugin/pull/14]

          Olivier Lamy added a comment -

          basil thanks.  I will have a look next week. 

          Olivier Lamy added a comment - basil  thanks.  I will have a look next week. 

          Basil Crow added a comment -

          Fixed in jenkinsci/jira-plugin#368. Released in 3.6.

          Basil Crow added a comment - Fixed in jenkinsci/jira-plugin#368 . Released in 3.6 .
          Basil Crow made changes -
          Released As New: 3.6
          Assignee Original: Radek Antoniuk [ warden ] New: Olivier Lamy [ olamy ]
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Basil Crow made changes -
          Labels New: JEP-233
          Basil Crow made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]

            olamy Olivier Lamy
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: