• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Component/s: support-core-plugin
• Labels:

  None
• Environment:

  support core plugin v2.75

[JENKINS-66445] Prevent bad warning log if new "additional-stop-words.txt" does not exist

Collapse comment: Reinhold Füreder added a comment - 2021-08-24 13:05

Reinhold Füreder added a comment - 2021-08-24 13:05

Maybe the following (untested) code could be an appropriate improvement/fix?

File f = new File(fileLocation);
if (f.exists()) {
  if (!f.canRead()) {
    LOGGER.log(Level.WARNING, "Could not load user provided stop words as " + fileLocation + " is not readable.");
  } else {
    try (BufferedReader br = new BufferedReader(new InputStreamReader(new FileInputStream(fileLocation), Charset.defaultCharset()))) {
      for (String line = br.readLine(); line != null; line = br.readLine()) {
        if (StringUtils.isNotEmpty(line)) {
          words.add(line);
        }
      }
      return words;
    } catch (IOException ex) {
      LOGGER.log(Level.WARNING, "Could not load user provided stop words " + fileLocation 
          + " due to unexpected i/o error.", ex);
    }
  }
}

Please also mind the change in the second log output.

Expand comment: Reinhold Füreder added a comment - 2021-08-24 13:05

Reinhold Füreder added a comment - 2021-08-24 13:05 Maybe the following (untested) code could be an appropriate improvement/fix? File f = new File(fileLocation); if (f.exists()) { if (!f.canRead()) { LOGGER.log(Level.WARNING, "Could not load user provided stop words as " + fileLocation + " is not readable." ); } else { try (BufferedReader br = new BufferedReader( new InputStreamReader( new FileInputStream(fileLocation), Charset.defaultCharset()))) { for ( String line = br.readLine(); line != null ; line = br.readLine()) { if (StringUtils.isNotEmpty(line)) { words.add(line); } } return words; } catch (IOException ex) { LOGGER.log(Level.WARNING, "Could not load user provided stop words " + fileLocation + " due to unexpected i/o error." , ex); } } } Please also mind the change in the second log output.

Collapse comment: Reinhold Füreder added a comment - 2021-08-31 11:17

Reinhold Füreder added a comment - 2021-08-31 11:17

Maybe allan_burdajewicz is the more appropriate assignee for this little issue?

Expand comment: Reinhold Füreder added a comment - 2021-08-31 11:17

Reinhold Füreder added a comment - 2021-08-31 11:17 Maybe allan_burdajewicz is the more appropriate assignee for this little issue?

Collapse comment: Reinhold Füreder added a comment - 2021-10-08 05:13

Reinhold Füreder added a comment - 2021-10-08 05:13

As I was just updating our Jenkins instances from 2.303.1 to 2.303.2 I stumbled over this issue again:

• Any news/updates?
• I had naively hoped this is a rather low hanging fruit?

Many thanks in advance...

Expand comment: Reinhold Füreder added a comment - 2021-10-08 05:13

Reinhold Füreder added a comment - 2021-10-08 05:13 As I was just updating our Jenkins instances from 2.303.1 to 2.303.2 I stumbled over this issue again: Any news/updates? I had naively hoped this is a rather low hanging fruit? Many thanks in advance...

Collapse comment: Allan BURDAJEWICZ added a comment - 2021-10-14 06:41

Allan BURDAJEWICZ added a comment - 2021-10-14 06:41

Sorry for the delay. Will look into this shortly. The proposed fix looks good. I think we should log a WARNING only if the file location is provided with a system property, but that provided location does not exists.

Expand comment: Allan BURDAJEWICZ added a comment - 2021-10-14 06:41

Allan BURDAJEWICZ added a comment - 2021-10-14 06:41 Sorry for the delay. Will look into this shortly. The proposed fix looks good. I think we should log a WARNING only if the file location is provided with a system property, but that provided location does not exists.

Collapse comment: Reinhold Füreder added a comment - 2021-10-20 07:33

Reinhold Füreder added a comment - 2021-10-20 07:33

Thanks allan_burdajewicz: sounds good! Looking forward to the fix...

Expand comment: Reinhold Füreder added a comment - 2021-10-20 07:33

Reinhold Füreder added a comment - 2021-10-20 07:33 Thanks allan_burdajewicz : sounds good! Looking forward to the fix...

Collapse comment: Allan BURDAJEWICZ added a comment - 2021-10-28 05:25

Allan BURDAJEWICZ added a comment - 2021-10-28 05:25

Release just done, should be out soon.

Expand comment: Allan BURDAJEWICZ added a comment - 2021-10-28 05:25

Allan BURDAJEWICZ added a comment - 2021-10-28 05:25 Release just done, should be out soon.