-
Bug
-
Resolution: Fixed
-
Major
-
Windows 10, Jenkins 2.309, nodelabelparameter-plugin 1.9.0
-
-
1.10.0
After allowing Jenkins >=2.306 to rename the "master" node to "built-in", thenrestarting Jenkins, the node-label-parameter plugin still shows "master" as the name of the controlling node.
- links to
[JENKINS-66511] Rename of 'master' node to 'built-in' is not recognized
https://ci.jenkins.io/job/Plugins/job/nodelabelparameter-plugin/view/change-requests/job/PR-66/ should provide a build that can be tested with Jenkins versions that are using the more inclusive naming.
Dominik Vorreiter
added a comment - Hi, same for us. After migration, no difference in node naming and when declaring "built-in" node in pipelines, it waits for ever.
In the first migration run, the master node had a label "built-in". Could this be the cause?
I have tried two additional migrations (shut Jenkins down, set <nodeRenameMigrationNeeded>true</nodeRenameMigrationNeeded> in config.xml, start Jenkins, migrate) without the label on master, stopping all builds before, but no difference.
I see no error in the Jenkins log. There is no log entry for the migration.
Jenkins 2.319.2 LTS, nodelabelparameter-plugin not installed!
Dominik Vorreiter
added a comment - Hi, same for us. After migration, no difference in node naming and when declaring "built-in" node in pipelines, it waits for ever.
In the first migration run, the master node had a label "built-in". Could this be the cause?
I have tried two additional migrations (shut Jenkins down, set <nodeRenameMigrationNeeded>true</nodeRenameMigrationNeeded> in config.xml, start Jenkins, migrate) without the label on master, stopping all builds before, but no difference.
I see no error in the Jenkins log. There is no log entry for the migration.
Jenkins 2.319.2 LTS, nodelabelparameter-plugin not installed! dominikkv since node label parameter plugin is not installed, this is not the location to report the issue. The people who might be able to assist with the issue will only see it here by accident and will wonder why an issue in Jenkins core is being reported in a plugin issue report that was closed by the release of node label parameter plugin 1.10.0 two months ago.
Please submit a new issue report. Please follow the "How to report an issue" guidelines to assure that you've provided enough information about the steps you've taken and the environment where you're running.
Dominik Vorreiter
added a comment - I'm sorry, didn't see this was for a plugin. I have created a new issue: JENKINS-67650
Dominik Vorreiter
added a comment - I'm sorry, didn't see this was for a plugin. I have created a new issue: JENKINS-67650 
Thanks for the bug report. The automated tests for the plugin show a failure when run with:
$ mvn clean -Djenkins.version=2.309 verify [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 30.606 s <<< FAILURE! - in org.jvnet.jenkins.plugins.nodelabelparameter.NodelLabelNodePropertyTest [ERROR] org.jvnet.jenkins.plugins.nodelabelparameter.NodelLabelNodePropertyTest.jobMustRunOnAllRequestedSlaves_DontIgnoreTempOfflineNodes Time elapsed: 14.021 s <<< FAILURE! java.lang.AssertionError: expcted number of runs expected:<3> but was:<2> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.jvnet.jenkins.plugins.nodelabelparameter.NodelLabelNodePropertyTest.runTest(NodelLabelNodePropertyTest.java:100) at org.jvnet.jenkins.plugins.nodelabelparameter.NodelLabelNodePropertyTest.jobMustRunOnAllRequestedSlaves_DontIgnoreTempOfflineNodes(NodelLabelNodePropertyTest.java:84) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:601) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.lang.Thread.run(Thread.java:829)Some changes will be needed for full support of the built-in label on the controller.
The plugin automated tests are also failing for me on Jenkins 2.303.1, which does not contain the change to the built-in label.