Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6700

Failure in test class constructor or @Before method is not reported (was: Maven plugin doesn't set build to unstable on SurefireExecutionException)

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • junit-plugin
    • None
    • Hudson 1.351, Maven 2.2.1, Surefire 2.5, TestNG 5.9
      Jenkins 1.420

      Occasionally we have some test which lets Surefire fail hard which Hudson doesn't recognize. I.e. the tests are not executed, but the build result is still success.
      E.g. we had a test which failed with a NoSuchFieldException in the constructor of the test class:

      Running TestSuite
      log4j:WARN No appenders could be found for logger (...).
      log4j:WARN Please initialize the log4j system properly.
      org.apache.maven.surefire.booter.SurefireExecutionException:
      Cannot instantiate class XyzTest; nested exception is org.testng.TestNGException:
      Cannot instantiate class XyzTest
      org.testng.TestNGException:
      Cannot instantiate class XyzTest
      at org.testng.internal.ObjectFactoryImpl.newInstance(ObjectFactoryImpl.java:35)
      at org.testng.internal.ClassHelper.createInstance(ClassHelper.java:330)
      at org.testng.internal.ClassImpl.getDefaultInstance(ClassImpl.java:62)
      at org.testng.internal.ClassImpl.getInstances(ClassImpl.java:81)
      at org.testng.internal.TestNGClassFinder.<init>(TestNGClassFinder.java:114)
      at org.testng.TestRunner.initMethods(TestRunner.java:289)
      at org.testng.TestRunner.init(TestRunner.java:235)
      at org.testng.TestRunner.init(TestRunner.java:197)
      at org.testng.TestRunner.<init>(TestRunner.java:141)
      at org.testng.SuiteRunner$DefaultTestRunnerFactory.newTestRunner(SuiteRunner.java:488)
      at org.testng.SuiteRunner.privateRun(SuiteRunner.java:250)
      at org.testng.SuiteRunner.run(SuiteRunner.java:204)
      at org.testng.TestNG.createAndRunSuiteRunners(TestNG.java:877)
      at org.testng.TestNG.runSuitesLocally(TestNG.java:842)
      at org.testng.TestNG.run(TestNG.java:751)
      at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:62)
      at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:141)
      at org.apache.maven.surefire.Surefire.run(Surefire.java:180)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:597)
      at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:350)
      at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1021)
      Caused by: java.lang.reflect.InvocationTargetException
      at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
      at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
      at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
      at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
      at org.testng.internal.ObjectFactoryImpl.newInstance(ObjectFactoryImpl.java:26)
      ... 23 more
      Caused by: java.lang.NoSuchFieldException: cipherService
      at java.lang.Class.getDeclaredField(Class.java:1882)
      at XyzTest.<init>(XyzTest.java:91)
      ... 28 more
      [ERROR] There are test failures.

          [JENKINS-6700] Failure in test class constructor or @Before method is not reported (was: Maven plugin doesn't set build to unstable on SurefireExecutionException)

          kutzi added a comment - - edited

          Should be fixed in 1.423

          kutzi added a comment - - edited Should be fixed in 1.423

          dogfood added a comment -

          Integrated in jenkins_main_trunk #966
          [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported
          [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported

          Christoph Kutzinski : a2c8673da13b032ea0afc745219c9c021a93efb3
          Files :

          • test/src/test/java/hudson/tasks/junit/SuiteResultTest.java
          • core/src/main/java/hudson/tasks/junit/SuiteResult.java
          • changelog.html

          Christoph Kutzinski : 6168fba02dbd6100f17540a00bbe8c6094dafd9c
          Files :

          • test/src/test/resources/hudson/tasks/junit/junit-report-6700.xml

          dogfood added a comment - Integrated in jenkins_main_trunk #966 [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported Christoph Kutzinski : a2c8673da13b032ea0afc745219c9c021a93efb3 Files : test/src/test/java/hudson/tasks/junit/SuiteResultTest.java core/src/main/java/hudson/tasks/junit/SuiteResult.java changelog.html Christoph Kutzinski : 6168fba02dbd6100f17540a00bbe8c6094dafd9c Files : test/src/test/resources/hudson/tasks/junit/junit-report-6700.xml

          dogfood added a comment -

          Integrated in jenkins_main_trunk #975
          [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported
          [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported

          Christoph Kutzinski : a2c8673da13b032ea0afc745219c9c021a93efb3
          Files :

          • core/src/main/java/hudson/tasks/junit/SuiteResult.java
          • test/src/test/java/hudson/tasks/junit/SuiteResultTest.java
          • changelog.html

          Christoph Kutzinski : 6168fba02dbd6100f17540a00bbe8c6094dafd9c
          Files :

          • test/src/test/resources/hudson/tasks/junit/junit-report-6700.xml

          dogfood added a comment - Integrated in jenkins_main_trunk #975 [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported Christoph Kutzinski : a2c8673da13b032ea0afc745219c9c021a93efb3 Files : core/src/main/java/hudson/tasks/junit/SuiteResult.java test/src/test/java/hudson/tasks/junit/SuiteResultTest.java changelog.html Christoph Kutzinski : 6168fba02dbd6100f17540a00bbe8c6094dafd9c Files : test/src/test/resources/hudson/tasks/junit/junit-report-6700.xml

          I can confirm that upgrading to Jenkins 1.424 fixed the problem for us - tests that were failing in the @BeforeClass are now correctly reported as failing. Thanks!

          Matthew Webber added a comment - I can confirm that upgrading to Jenkins 1.424 fixed the problem for us - tests that were failing in the @BeforeClass are now correctly reported as failing. Thanks!

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          changelog.html
          core/src/main/java/hudson/tasks/junit/SuiteResult.java
          core/src/test/java/hudson/tasks/junit/SuiteResultTest.java
          http://jenkins-ci.org/commit/jenkins/02486455fd1dae745baf09ee7e7a5e7bb89ca26d
          Log:
          [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported(cherry picked from commit a2c8673da13b032ea0afc745219c9c021a93efb3)

          Conflicts:

          changelog.html
          core/src/test/java/hudson/tasks/junit/SuiteResultTest.java

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html core/src/main/java/hudson/tasks/junit/SuiteResult.java core/src/test/java/hudson/tasks/junit/SuiteResultTest.java http://jenkins-ci.org/commit/jenkins/02486455fd1dae745baf09ee7e7a5e7bb89ca26d Log: [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported(cherry picked from commit a2c8673da13b032ea0afc745219c9c021a93efb3) Conflicts: changelog.html core/src/test/java/hudson/tasks/junit/SuiteResultTest.java

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          test/src/test/resources/hudson/tasks/junit/junit-report-6700.xml
          http://jenkins-ci.org/commit/jenkins/ce54cd0a86abb1c5c337e33f5aaa25a4869fd341
          Log:
          [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported(cherry picked from commit 6168fba02dbd6100f17540a00bbe8c6094dafd9c)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: test/src/test/resources/hudson/tasks/junit/junit-report-6700.xml http://jenkins-ci.org/commit/jenkins/ce54cd0a86abb1c5c337e33f5aaa25a4869fd341 Log: [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported(cherry picked from commit 6168fba02dbd6100f17540a00bbe8c6094dafd9c)

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          changelog.html
          core/src/main/java/hudson/tasks/junit/SuiteResult.java
          test/src/test/java/hudson/tasks/junit/SuiteResultTest.java
          http://jenkins-ci.org/commit/jenkins/a2c8673da13b032ea0afc745219c9c021a93efb3
          Log:
          [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html core/src/main/java/hudson/tasks/junit/SuiteResult.java test/src/test/java/hudson/tasks/junit/SuiteResultTest.java http://jenkins-ci.org/commit/jenkins/a2c8673da13b032ea0afc745219c9c021a93efb3 Log: [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          test/src/test/resources/hudson/tasks/junit/junit-report-6700.xml
          http://jenkins-ci.org/commit/jenkins/6168fba02dbd6100f17540a00bbe8c6094dafd9c
          Log:
          [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: test/src/test/resources/hudson/tasks/junit/junit-report-6700.xml http://jenkins-ci.org/commit/jenkins/6168fba02dbd6100f17540a00bbe8c6094dafd9c Log: [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          changelog.html
          core/src/main/java/hudson/tasks/junit/SuiteResult.java
          test/src/test/java/hudson/tasks/junit/SuiteResultTest.java
          http://jenkins-ci.org/commit/jenkins/a2c8673da13b032ea0afc745219c9c021a93efb3
          Log:
          [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html core/src/main/java/hudson/tasks/junit/SuiteResult.java test/src/test/java/hudson/tasks/junit/SuiteResultTest.java http://jenkins-ci.org/commit/jenkins/a2c8673da13b032ea0afc745219c9c021a93efb3 Log: [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          test/src/test/resources/hudson/tasks/junit/junit-report-6700.xml
          http://jenkins-ci.org/commit/jenkins/6168fba02dbd6100f17540a00bbe8c6094dafd9c
          Log:
          [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: test/src/test/resources/hudson/tasks/junit/junit-report-6700.xml http://jenkins-ci.org/commit/jenkins/6168fba02dbd6100f17540a00bbe8c6094dafd9c Log: [FIXED JENKINS-6700] Failure in test class constructor or @Before method was not reported

            kutzi kutzi
            kutzi kutzi
            Votes:
            3 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: