Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-67298

Remove agent-to-controller FilePath calls from Job Cacher plugin

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • jobcacher-plugin
    • None

      JENKINS-67173 proposes the removal of support of agent-to-controller FilePath access.

      https://github.com/jenkinsci/jobcacher-plugin/blob/6080e75fab6ec17f04f6261ebee7301e9581bc6a/src/main/java/jenkins/plugins/itemstorage/local/LocalObjectPath.java#L74 ends up calling various FilePath methods in https://github.com/jenkinsci/jobcacher-plugin/blob/6080e75fab6ec17f04f6261ebee7301e9581bc6a/src/main/java/jenkins/plugins/itemstorage/local/LocalObjectPath.java#L126-L133 to filter the files to transfer. This should be changed.

      Stack traces:

      Command UserRequest:hudson.FilePath$Exists@… created at
	at hudson.remoting.Command.<init>(Command.java:81)
	at hudson.remoting.Request.<init>(Request.java:113)
	at hudson.remoting.Request.<init>(Request.java:108)
	at hudson.remoting.UserRequest.<init>(UserRequest.java:77)
	at hudson.remoting.Channel.call(Channel.java:999)
	at hudson.FilePath.act(FilePath.java:1165)
	at hudson.FilePath.act(FilePath.java:1154)
	at hudson.FilePath.exists(FilePath.java:1697)
	at jenkins.plugins.itemstorage.local.LocalObjectPath$IsNotThereOrOlderVisitor.visit(LocalObjectPath.java:127)
	at hudson.util.DirScanner.scanSingle(DirScanner.java:51)
	at hudson.util.DirScanner$Glob.scan(DirScanner.java:146)
	at jenkins.plugins.itemstorage.local.LocalObjectPath$IsModifiedGlob.scan(LocalObjectPath.java:105)
	at hudson.FilePath.writeToTar(FilePath.java:2822)
	at hudson.FilePath.access$4400(FilePath.java:212)
	at hudson.FilePath$CopyRecursiveRemoteToLocal.invoke(FilePath.java:2787)
	at hudson.FilePath$CopyRecursiveRemoteToLocal.invoke(FilePath.java:2774)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3329)
	at hudson.remoting.UserRequest.perform(UserRequest.java:211)
	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
	at hudson.remoting.Request$2.run(Request.java:376)
	at hudson.remoting.InterceptingExecutorService.lambda$wrap$0(InterceptingExecutorService.java:78)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:122)
	at java.base/java.lang.Thread.run(Thread.java:829)

Command UserRequest:hudson.FilePath$Exists@… created at
	at hudson.remoting.Command.<init>(Command.java:81)
	at hudson.remoting.Request.<init>(Request.java:113)
	at hudson.remoting.Request.<init>(Request.java:108)
	at hudson.remoting.UserRequest.<init>(UserRequest.java:77)
	at hudson.remoting.Channel.call(Channel.java:999)
	at hudson.FilePath.act(FilePath.java:1165)
	at hudson.FilePath.act(FilePath.java:1154)
	at hudson.FilePath.exists(FilePath.java:1697)
	at jenkins.plugins.itemstorage.local.LocalObjectPath$IsNotThereOrOlderVisitor.visit(LocalObjectPath.java:131)
	at hudson.util.DirScanner.scanSingle(DirScanner.java:51)
	at hudson.util.DirScanner$Glob.scan(DirScanner.java:146)
	at jenkins.plugins.itemstorage.local.LocalObjectPath$IsModifiedGlob.scan(LocalObjectPath.java:105)
	at hudson.FilePath.writeToTar(FilePath.java:2822)
	at hudson.FilePath.access$4400(FilePath.java:212)
	at hudson.FilePath$CopyRecursiveRemoteToLocal.invoke(FilePath.java:2787)
	at hudson.FilePath$CopyRecursiveRemoteToLocal.invoke(FilePath.java:2774)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3329)
	at hudson.remoting.UserRequest.perform(UserRequest.java:211)
	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
	at hudson.remoting.Request$2.run(Request.java:376)
	at hudson.remoting.InterceptingExecutorService.lambda$wrap$0(InterceptingExecutorService.java:78)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:122)
	at java.base/java.lang.Thread.run(Thread.java:829)

Command UserRequest:hudson.FilePath$LastModified@… created at
	at hudson.remoting.Command.<init>(Command.java:81)
	at hudson.remoting.Request.<init>(Request.java:113)
	at hudson.remoting.Request.<init>(Request.java:108)
	at hudson.remoting.UserRequest.<init>(UserRequest.java:77)
	at hudson.remoting.Channel.call(Channel.java:999)
	at hudson.FilePath.act(FilePath.java:1165)
	at hudson.FilePath.act(FilePath.java:1154)
	at hudson.FilePath.lastModified(FilePath.java:1715)
	at jenkins.plugins.itemstorage.local.LocalObjectPath$IsNotThereOrOlderVisitor.visit(LocalObjectPath.java:127)
	at hudson.util.DirScanner.scanSingle(DirScanner.java:51)
	at hudson.util.DirScanner$Glob.scan(DirScanner.java:146)
	at jenkins.plugins.itemstorage.local.LocalObjectPath$IsModifiedGlob.scan(LocalObjectPath.java:105)
	at hudson.FilePath.writeToTar(FilePath.java:2822)
	at hudson.FilePath.access$4400(FilePath.java:212)
	at hudson.FilePath$CopyRecursiveRemoteToLocal.invoke(FilePath.java:2787)
	at hudson.FilePath$CopyRecursiveRemoteToLocal.invoke(FilePath.java:2774)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3329)
	at hudson.remoting.UserRequest.perform(UserRequest.java:211)
	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
	at hudson.remoting.Request$2.run(Request.java:376)
	at hudson.remoting.InterceptingExecutorService.lambda$wrap$0(InterceptingExecutorService.java:78)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:122)
	at java.base/java.lang.Thread.run(Thread.java:829)

Command UserRequest:hudson.FilePath$Touch@… created at
	at hudson.remoting.Command.<init>(Command.java:81)
	at hudson.remoting.Request.<init>(Request.java:113)
	at hudson.remoting.Request.<init>(Request.java:108)
	at hudson.remoting.UserRequest.<init>(UserRequest.java:77)
	at hudson.remoting.Channel.call(Channel.java:999)
	at hudson.FilePath.act(FilePath.java:1165)
	at hudson.FilePath.act(FilePath.java:1154)
	at hudson.FilePath.touch(FilePath.java:1731)
	at jenkins.plugins.itemstorage.local.LocalObjectPath$IsNotThereOrOlderVisitor.visit(LocalObjectPath.java:132)
	at hudson.util.DirScanner.scanSingle(DirScanner.java:51)
	at hudson.util.DirScanner$Glob.scan(DirScanner.java:146)
	at jenkins.plugins.itemstorage.local.LocalObjectPath$IsModifiedGlob.scan(LocalObjectPath.java:105)
	at hudson.FilePath.writeToTar(FilePath.java:2822)
	at hudson.FilePath.access$4400(FilePath.java:212)
	at hudson.FilePath$CopyRecursiveRemoteToLocal.invoke(FilePath.java:2787)
	at hudson.FilePath$CopyRecursiveRemoteToLocal.invoke(FilePath.java:2774)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3329)
	at hudson.remoting.UserRequest.perform(UserRequest.java:211)
	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
	at hudson.remoting.Request$2.run(Request.java:376)
	at hudson.remoting.InterceptingExecutorService.lambda$wrap$0(InterceptingExecutorService.java:78)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:122)
	at java.base/java.lang.Thread.run(Thread.java:829)

            repolevedavaj Jonas Bamberger
            danielbeck Daniel Beck
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: