Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-67377

Add more Pull Request trigger events for plugin

      currently, we see that not all pull request events (listed in Bitbucket server webhooks) are supported by the plugin. 

      Ending up in {"status":"error","message":"Event is not supported: pr:reviewer:approved"} when trying to add the pr approved event to the existing webhook configuration. 

      Ask:

      Please add support to all the events (listed in Bitbucket webhooks) in the plugin.

          [JENKINS-67377] Add more Pull Request trigger events for plugin

          Hi Susheel, thanks for the suggestion.

          I'd like to have a bit more context for this feature before we consider a solution. Can you briefly describe your workflow, and the conditions in which you would want a reviewer approval to trigger a build?

          Martin Henschke added a comment - Hi Susheel, thanks for the suggestion. I'd like to have a bit more context for this feature before we consider a solution. Can you briefly describe your workflow, and the conditions in which you would want a reviewer approval to trigger a build?

          Hey Martin, 

          thanks for the reply.

          we have a job (job1) that runs against a Pull Request to validate the changes in an env (lets say ENV1) once the PR is created (opened). 
          Once the job is successful (validated in ENV1) and reported back with result. Only then the reviewers will be reviewing the src code (PR diff). 

          Once it is reviewed and approved it goes for a final check (job2) in another env (lets say ENV2) and once good in ENV2 the merge is enabled. 

          The job2 is kicked off only when someone approves the PR. 

          Susheel Prasad Kanakamedala added a comment - Hey Martin,  thanks for the reply. we have a job (job1) that runs against a Pull Request to validate the changes in an env (lets say ENV1) once the PR is created (opened).  Once the job is successful (validated in ENV1) and reported back with result. Only then the reviewers will be reviewing the src code (PR diff).  Once it is reviewed and approved it goes for a final check (job2) in another env (lets say ENV2) and once good in ENV2 the merge is enabled.  The job2 is kicked off only when someone approves the PR. 

            Unassigned Unassigned
            skanakam Susheel Prasad Kanakamedala
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: