• Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • git-plugin

      Hi,

      I'm experiencing some inconsistent behaviours with the gitlfspull extension and if/how it respects the .lfsconfig include/exclude fetch filters, e.g.:

      [lfs]
        fetchexclude=dir_to_exclude/**/*
      

      I'm finding that for normal branches (not filed as PRs) all files configured for LFS storage are smudged after the git lfs pull completes, including those that are explicitly excluded. Whereas, branches filed as PRs do have the contents of the excluded directories correctly unsmudged (the files are just pointers).

          [JENKINS-67860] Git LFS include/exclude filters ignored

          Mark Waite added a comment -

          The git plugin disables the smudge filter ( GIT_LFS_SKIP_SMUDGE=1 ) and uses an explicit git lfs pull origin to retrieve the large files. There is an attempt to set the LFS fetchinclude and fetchexclude values if sparse checkout is being used, but as far as I can tell, that's the only case where the plugin sets fetchexclude.

          Mark Waite added a comment - The git plugin disables the smudge filter ( GIT_LFS_SKIP_SMUDGE=1 ) and uses an explicit git lfs pull origin  to retrieve the large files. There is an attempt to set the LFS fetchinclude and fetchexclude values if sparse checkout is being used, but as far as I can tell, that's the only case where the plugin sets fetchexclude.

          Rob Ruck added a comment -

          Thanks for confirming my suspicions markewaite. Will this be considered a bug that will be fixed, or is this is how it is intended to be?

          If it's the latter, presumably I'll need to disable the gitlfspull extension, resolve the authentication issue mentioned in https://issues.jenkins.io/browse/JENKINS-62382 and move to doing a manual `git lfs pull` that does respect the lfs filters?

          Rob Ruck added a comment - Thanks for confirming my suspicions markewaite . Will this be considered a bug that will be fixed, or is this is how it is intended to be? If it's the latter, presumably I'll need to disable the gitlfspull extension, resolve the authentication issue mentioned in https://issues.jenkins.io/browse/JENKINS-62382 and move to doing a manual `git lfs pull` that does respect the lfs filters?

            Unassigned Unassigned
            robruckob Rob Ruck
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: