• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • packaging
    • None
    • Windows MSI installer for Jenkins

      The Windows installer for Jenkins should recommend Java 11, especially if it detects Java 8 as the current JVM. (Split out into JENKINS-68170.)

      When Jenkins requires Java 11 or newer, the Windows installer should prevent installation if it detects that the Jenkins war file will be run with Java 8. When Java 11 is required, attempts to run with Java 8 should be expected to fail.

          [JENKINS-67894] Prevent Windows installer from using Java 8

          Tim Jacomb added a comment -

          Best tracked on GitHub if there's still something you think should be done

          Tim Jacomb added a comment - Best tracked on GitHub if there's still something you think should be done

          Alex Earl added a comment -

          I have the change ready (I won't do a PR yet), just let me know when we are ready for a PR

          Alex Earl added a comment - I have the change ready (I won't do a PR yet), just let me know when we are ready for a PR

          Basil Crow added a comment -

          This ticket as filed by markewaite seems to contain two separate tasks:
           

          1. The Windows installer for Jenkins should recommend Java 11, especially if it detects Java 8 as the current JVM.
          2. When Jenkins requires Java 11 or newer, the Windows installer should prevent installation if it detects that the Jenkins war file will be run with Java 8. When Java 11 is required, attempts to run with Java 8 should be expected to fail.

          It seems that task #1 can be integrated and released today, while task #2 cannot be integrated and released until we decide to drop support for Java 8. Is my understanding correct?

          If so, then I would propose that we repurpose this ticket to cover task #2 while filing a separate ticket for task #1 and having slide_o_mix propose the PR, merge, and release it immediately. Thoughts?

          Basil Crow added a comment - This ticket as filed by markewaite seems to contain two separate tasks:   The Windows installer for Jenkins should recommend Java 11, especially if it detects Java 8 as the current JVM. When Jenkins requires Java 11 or newer, the Windows installer should prevent installation if it detects that the Jenkins war file will be run with Java 8. When Java 11 is required, attempts to run with Java 8 should be expected to fail. It seems that task #1 can be integrated and released today, while task #2 cannot be integrated and released until we decide to drop support for Java 8. Is my understanding correct? If so, then I would propose that we repurpose this ticket to cover task #2 while filing a separate ticket for task #1 and having slide_o_mix propose the PR, merge, and release it immediately. Thoughts?

          Mark Waite added a comment -

          Sounds fine to me.

          Mark Waite added a comment - Sounds fine to me.

          Basil Crow added a comment -

          Split out into JENKINS-68170. This ticket needs to remain blocked on dropping support for Java 8. JENKINS-68170 can be merged and released immediately.

          Basil Crow added a comment - Split out into JENKINS-68170 . This ticket needs to remain blocked on dropping support for Java 8. JENKINS-68170 can be merged and released immediately.

          Basil Crow added a comment -

          slide_o_mix If you are interested, this task can now be worked on, because I just merged the PR to require Java 11 in Jenkins core this morning.

          Basil Crow added a comment - slide_o_mix If you are interested, this task can now be worked on, because I just merged the PR to require Java 11 in Jenkins core this morning.

          Alex Earl added a comment -

          Yes, I am back from vacation and will look at this. Should not be hard to do.

          Alex Earl added a comment - Yes, I am back from vacation and will look at this. Should not be hard to do.

          Alex Earl added a comment -

          Alex Earl added a comment - See https://github.com/jenkinsci/packaging/pull/322

          Alex Earl added a comment -

          I believe this should be part of the next weekly?

          Alex Earl added a comment - I believe this should be part of the next weekly?

          Mark Waite added a comment -

          I believe this should be part of the next weekly?

          Yes.

          Mark Waite added a comment - I believe this should be part of the next weekly? Yes.

            slide_o_mix Alex Earl
            markewaite Mark Waite
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: