Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-68031

Jenkins 2.0 style config form bottom border is cut off (regression in 2.335)

    XMLWordPrintable

Details

    • 2.345

    Description

      This started after 2.332, but before 2.335, and in 2.338 it does look slightly different.

      The bottom border of the /job/xx/configure form frame is cut off.

      Attachments

        Issue Links

          Activity

            danielbeck Daniel Beck created issue -
            danielbeck Daniel Beck made changes -
            Field Original Value New Value
            Attachment 68031-2.335.png [ 57462 ]
            danielbeck Daniel Beck made changes -
            Attachment 68031-2.338-PR-6084.png [ 57463 ]
            frankie699 frankie699 made changes -
            Assignee Yu-Xun Chen [ JIRAUSER140365 ]
            basil Basil Crow made changes -
            Labels regression ui regression ux
            basil Basil Crow made changes -
            Summary Jenkins 2.0 style config form bottom border is cut off Jenkins 2.0 style config form bottom border is cut off (regression in 2.335)
            basil Basil Crow added a comment - Can reproduce, bisected to https://github.com/jenkinsci/jenkins/pull/5923
            basil Basil Crow made changes -
            Link This issue is caused by JENKINS-68248 [ JENKINS-68248 ]
            basil Basil Crow made changes -
            Link This issue causes JENKINS-67744 [ JENKINS-67744 ]
            basil Basil Crow made changes -
            Link This issue causes JENKINS-67744 [ JENKINS-67744 ]
            timja Tim Jacomb added a comment -

            I think this was somewhat intentional.

            / will be re-worked in the new job configure screens.

            cc janfaracik

            timja Tim Jacomb added a comment - I think this was somewhat intentional. / will be re-worked in the new job configure screens. cc janfaracik
            timja Tim Jacomb added a comment - see https://github.com/jenkinsci/jenkins/pull/6485
            timja Tim Jacomb made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            timja Tim Jacomb made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            timja Tim Jacomb made changes -
            Remote Link This issue links to "https://github.com/jenkinsci/jenkins/pull/6485 (Web Link)" [ 27574 ]
            notmyfault Alexander Brandes made changes -
            Labels regression ux
            basil Basil Crow added a comment - - edited

            Let us be clear about what this ticket is about.

            This ticket is not about redesigning the Configure Project page. Rather than being a bug caused by JENKINS-68248, the effort to redesign the Configure Project page is a new feature at the same level as JENKINS-68248. Therefore it deserves its own top-level ticket. I have filed JENKINS-68282 for this purpose.

            This ticket is about a bug caused by JENKINS-68248; namely, that the bottom of the page lacks a border in the same way that the left and right of the page do. This does not seem intentional.

            True, the redesign of the Configure Project page in JENKINS-68282 may solve this bug (in which case this bug could be closed once JENKINS-68282 is landed), but let us not conflate the two: they are not equivalent in scope, nor are they equivalent in risk. Although this ticket is low in priority, a targeted bug fix for this ticket would have low risk (and therefore safe for a backport), while a redesign of the Configure Project page as in JENKINS-68282 is high risk (and therefore not likely a good candidate for backport).

            basil Basil Crow added a comment - - edited Let us be clear about what this ticket is about. This ticket is not about redesigning the Configure Project page. Rather than being a bug caused by JENKINS-68248 , the effort to redesign the Configure Project page is a new feature at the same level as JENKINS-68248 . Therefore it deserves its own top-level ticket. I have filed JENKINS-68282 for this purpose. This ticket is about a bug caused by JENKINS-68248 ; namely, that the bottom of the page lacks a border in the same way that the left and right of the page do. This does not seem intentional. True, the redesign of the Configure Project page in JENKINS-68282 may solve this bug (in which case this bug could be closed once JENKINS-68282 is landed), but let us not conflate the two: they are not equivalent in scope, nor are they equivalent in risk. Although this ticket is low in priority, a targeted bug fix for this ticket would have low risk (and therefore safe for a backport), while a redesign of the Configure Project page as in JENKINS-68282 is high risk (and therefore not likely a good candidate for backport).
            basil Basil Crow made changes -
            Status In Review [ 10005 ] In Progress [ 3 ]
            basil Basil Crow made changes -
            Remote Link This issue links to "https://github.com/jenkinsci/jenkins/pull/6485 (Web Link)" [ 27574 ]
            basil Basil Crow made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            basil Basil Crow made changes -
            Labels regression ux
            basil Basil Crow made changes -
            Link This issue relates to JENKINS-68282 [ JENKINS-68282 ]
            basil Basil Crow made changes -
            Remote Link This issue links to "jenkinsci/jenkins#6380 (Web Link)" [ 27577 ]
            basil Basil Crow made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            basil Basil Crow made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            basil Basil Crow made changes -
            Released As 2.345
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Fixed but Unreleased [ 10203 ]
            notmyfault Alexander Brandes made changes -
            Status Fixed but Unreleased [ 10203 ] Closed [ 6 ]

            People

              frankie699 frankie699
              danielbeck Daniel Beck
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: