Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-68492

'javadoc:javadoc' can no longer be executed with 'install'

XMLWordPrintable

    • 2.348, 2.346.1

      This used to work before https://github.com/jenkinsci/jenkins/pull/6366 :

      mvn clean javadoc:javadoc install

      AbstractGroovyViewModule references generated code (taglib-interface), so it's understandable that it now fails.

      Trying

      mvn clean install javadoc:javadoc

      fails because of Checkstyle violations in hudson/cli/client/Messages.java (33 in recent releases, 1 in older releases)

      We run javadoc:javadoc explicitly on cert.ci to ensure we do not introduce Javadoc errors that fail the release build (although the impact PR 6366 makes me think it didn't actually accomplish that before).

      Filing as a bug because I think one of the invocations above should work (in particular, Checkstyle looking at generated sources seems wrong), but open to alternatives.

          [JENKINS-68492] 'javadoc:javadoc' can no longer be executed with 'install'

          Basil Crow added a comment -

          although the impact PR 6366 makes me think it didn't actually accomplish that before

          Certainly the case. In my opinion, a bit much to claim this is a regression when this never worked in the first place. A PR from you would have been appreciated.

          Basil Crow added a comment - although the impact PR 6366 makes me think it didn't actually accomplish that before Certainly the case. In my opinion, a bit much to claim this is a regression when this never worked in the first place. A PR from you would have been appreciated.

          Jesse Glick added a comment -

          We run javadoc:javadoc explicitly on cert.ci to ensure we do not introduce Javadoc errors that fail the release build

          I think this is accomplished just by -Dset.changelist?

          Jesse Glick added a comment - We run javadoc:javadoc explicitly on cert.ci to ensure we do not introduce Javadoc errors that fail the release build I think this is accomplished just by -Dset.changelist ?

          Daniel Beck added a comment -

          I think this is accomplished just by -Dset.changelist?

          Not set in https://github.com/jenkinsci-cert/jenkins-merge-tool/blob/3683074d4b8f3b9d3e0ed3c0b478bd972c0f3571/merge-tool.sh#L218-L227 which is the "final" CI run for all fixes X all branches. So this should be set even when we're not deploying the result?

          Daniel Beck added a comment - I think this is accomplished just by -Dset.changelist ? Not set in https://github.com/jenkinsci-cert/jenkins-merge-tool/blob/3683074d4b8f3b9d3e0ed3c0b478bd972c0f3571/merge-tool.sh#L218-L227 which is the "final" CI run for all fixes X all branches. So this should be set even when we're not deploying the result?

            basil Basil Crow
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: