• 1.11

      After uploading a custom folder icon, the icon does not show up. Instead the ALT-Text of the image "Folder" is displayed. The provided URL of the image returns a 404.

      I believe, getImageOf() returns a wrong path. I think using Jenkins.RESOURCE_PATH is wrong, since this points into the .war file of jenkins itself. It should be working if this is left out when building the url string.

          [JENKINS-68894] Uploaded folder Icon not shown

          amesser Thanks for creating this issue. I seem to have trouble reproducing it though.

          According to the documentation Jenkins.RESOURCE_PATH should return "either "" or strings like "/static/VERSION" which is what I'm seeing in my local tests and deployments as well.

          Would you mind sharing the Jenkins and plugin version used as well as the "redacted" URL that gives you a 404?

          Daniel Krämer added a comment - amesser Thanks for creating this issue. I seem to have trouble reproducing it though. According to the documentation Jenkins.RESOURCE_PATH should return " either "" or strings like "/static/VERSION " which is what I'm seeing in my local tests and deployments as well. Would you mind sharing the Jenkins and plugin version used as well as the "redacted" URL that gives you a 404?

          The page contains the following url:

          https://buildmachinespc.hilscher.local/jenkins-pipeline/jenkins-pipeline/static/c195b117/userContent/customFolderIcons/442a32b9-2bab-45b2-9da9-2710e5554edb.png

          I should have had a more detailed look in it. I see the double prefix "jenkins-pipeline" now. If I remove one of it, the image is delivered. We're using Jenkins with a http prefix to have it run in a subfolder. (start option --prefix)

          Jenkins version is 2.346.1, Custom Folder Icon Plugin Version 1.10

          Andreas Messer added a comment - The page contains the following url: https://buildmachinespc.hilscher.local/jenkins-pipeline/jenkins-pipeline/static/c195b117/userContent/customFolderIcons/442a32b9-2bab-45b2-9da9-2710e5554edb.png I should have had a more detailed look in it. I see the double prefix "jenkins-pipeline" now. If I remove one of it, the image is delivered. We're using Jenkins with a http prefix to have it run in a subfolder. (start option --prefix) Jenkins version is 2.346.1, Custom Folder Icon Plugin Version 1.10

          Daniel Krämer added a comment - - edited

          That is valuable information.

          I found an issue that causes the croppie.js and croppie.css to not be loaded properly when a prefix is defined - resulting in a missing preview / upload functionality. However once that was resolved it seems to be working just fine. Correction: I can reproduce it in Jenkins 2.346.1 but not in 2.357

          Found the root cause: https://issues.jenkins.io/browse/JENKINS-68639

          Daniel Krämer added a comment - - edited That is valuable information. I found an issue that causes the croppie.js and croppie.css to not be loaded properly when a prefix is defined - resulting in a missing preview / upload functionality. However once that was resolved it seems to be working just fine. Correction: I can reproduce it in Jenkins 2.346.1 but not in 2.357 Found the root cause: https://issues.jenkins.io/browse/JENKINS-68639

          Issue is caused by a bug in Jenkins 2.346.1 (among others) that is fixed with 2.357
          There is hope that this will be resolved in the next LTS.
          In the meantime I built a workaround that will solve the issue in these particular versions.

          Daniel Krämer added a comment - Issue is caused by a bug in Jenkins 2.346.1 (among others) that is fixed with 2.357 There is hope that this will be resolved in the next LTS. In the meantime I built a workaround that will solve the issue in these particular versions.

          Thank you very much for your work! Will try it on monday.

          Andreas Messer added a comment - Thank you very much for your work! Will try it on monday.

            strangelookingnerd Daniel Krämer
            amesser Andreas Messer
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: