Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-69795

"master" => "built-in" migration applied, NODE_LABEL still contains "master"

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not A Defect
    • Icon: Minor Minor
    • core
    • None

      After applying "master" => "built-in" migration, NODE_NAME for build-it node still contains "master" instead of "built-in" as expected from documentation

      NODE_NAME="master"
      NODE_LABELS="built-in master" # master is custom label assigned to built-in node

      jenkins version is 2.361.2 after upgrade from 2.346.3.
      the system got updates to each LTS version, while the initial version was 1.xxx.

       

       

          [JENKINS-69795] "master" => "built-in" migration applied, NODE_LABEL still contains "master"

          Roberto Rizzetto created issue -

          Mark Waite added a comment -

          Thanks for reporting the issue. I see the same behavior in my environment. I've created a test job in my environment that reports unstable if the NODE_NAME is master.

          The same condition does not exist in a fresh installation of Jenkins 2.361.2.

          Mark Waite added a comment - Thanks for reporting the issue. I see the same behavior in my environment. I've created a test job in my environment that reports unstable if the NODE_NAME is master. The same condition does not exist in a fresh installation of Jenkins 2.361.2.

          Daniel Beck added a comment -

          This is labeled "regression". Was the NODE_NAME correct "built-in" before, but changed back to "master" after an update?

          Also, the title and description of this issue are not aligned, does the NODE_LABEL matter at all? The description says you manually added "master".

          To help diagnose further, please run the following in the Script Console and provide the output:

          println Jenkins.nodeNameAndSelfLabelOverride
println Jenkins.get().getRenameMigrationDone()
println Jenkins.get().getSelfLabel()

           

          Daniel Beck added a comment - This is labeled "regression". Was the NODE_NAME correct "built-in" before, but changed back to "master" after an update? Also, the title and description of this issue are not aligned, does the NODE_LABEL matter at all? The description says you manually added "master". To help diagnose further, please run the following in the Script Console and provide the output: println Jenkins.nodeNameAndSelfLabelOverride println Jenkins.get().getRenameMigrationDone() println Jenkins.get().getSelfLabel()  

          Mark Waite added a comment -

          I'm not sure that the `regression` label is correct. I'm not sure that the behavior has changed. It may have always been this way since initial implementation.

          When I run the following in the script console of my instance:

          println Jenkins.nodeNameAndSelfLabelOverride
println Jenkins.get().getRenameMigrationDone()
println Jenkins.get().getSelfLabel()

          it reports

          null
true
built-in

          That's Jenkins 2.361.2 with plugins and installation as described in my docker-lfs repository and its private variant.

          Mark Waite added a comment - I'm not sure that the `regression` label is correct. I'm not sure that the behavior has changed. It may have always been this way since initial implementation. When I run the following in the script console of my instance: println Jenkins.nodeNameAndSelfLabelOverride println Jenkins.get().getRenameMigrationDone() println Jenkins.get().getSelfLabel() it reports null true built-in That's Jenkins 2.361.2 with plugins and installation as described in my docker-lfs repository and its private variant.

          Daniel Beck added a comment - - edited

          Y'all need to uninstall envinject.

          Daniel Beck added a comment - - edited Y'all need to uninstall envinject .
          Daniel Beck made changes -
          Resolution New: Not A Defect [ 7 ]
          Status Original: Open [ 1 ] New: Closed [ 6 ]
          Daniel Beck made changes -
          Labels Original: regression

          Roberto Rizzetto added a comment -

          Thanks Daniel for this analysis.
          So the problem is the  envinject. to which I will open a ticket

          Roberto Rizzetto added a comment - Thanks Daniel for this analysis. So the problem is the   envinject . to which I will open a ticket
          Mark Waite made changes -
          Assignee New: Mark Waite [ markewaite ]
          Mark Waite made changes -
          Assignee Original: Mark Waite [ markewaite ]

            Unassigned Unassigned
            robrizlav Roberto Rizzetto
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: