Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-69972

Plugin manager HTTP Proxy configuration URL fails fatally, if URL is malformed

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • 2.379

      If you attempt to validate a URL at the plugin manager's proxy field and enter a malformed URL, like missing the protocol type, there's no form validation, but the typical "Oops!" banner.
      Unless you know exactly what you did wrong, the page is not useful at all.

      There's already existing form validation, if you miss the "www" part of the URL, but not if you miss the protocol part, like https/http/etc.
      It would make sense to use proper form validation for the protocol part too, rather than just failing fatally.

      Stacktrace: https://gist.githubusercontent.com/NotMyFault/30eafe1e07ca674750f6cd9186883bd2/raw/35180434c026ff3d0bdd3b052b42ead68ce13002/gistfile1.txt

          [JENKINS-69972] Plugin manager HTTP Proxy configuration URL fails fatally, if URL is malformed

          Basil Crow added a comment -

          This would be trivial to fix by catching the IllegalArgumentException and returning FormValidation.error(e, Messages.ProxyConfiguration_MalformedTestUrl(testUrl)).

          Basil Crow added a comment - This would be trivial to fix by catching the IllegalArgumentException and returning FormValidation.error(e, Messages.ProxyConfiguration_MalformedTestUrl(testUrl)) .

            basil Basil Crow
            notmyfault Alexander Brandes
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: