Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-70128

Dismiss button unreadable in old data monitor with dark theme (regression in 2.378)

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • 2.385

      Steps to reproduce

      • Create unreadable data; exempli gratia, by installing the Docker Build Step plugin, configuring a Freestyle job with it, and uninstalling the plugin.
      • Enable the dark theme.
      • Go to Manage Jenkins.

      Expected results

       

      Note

      These are the actual results prior to jenkinsci/jenkins#7364 and 2.378.

      The Dismiss button should be readable, as it is in the "old" screenshot where there is black text on a light blue background.

      Actual results

      The Dismiss button is unreadable, as it is bright red text on an orange background, which cannot be distinguished, as shown in the "new" screenshot.

        1. after.png
          after.png
          27 kB
        2. before.png
          before.png
          28 kB

          [JENKINS-70128] Dismiss button unreadable in old data monitor with dark theme (regression in 2.378)

          Markus Winter added a comment -

          The same problem exists for other monitors:

          • monitor warning about building on the built-in node
          • missing root url
          • Legacy Apitoken enabled
          • and more

          Probably anything that uses the class "jenkins-!-destructive-color" in a submit button where the surrounding div has "alert-warning" class

          Markus Winter added a comment - The same problem exists for other monitors: monitor warning about building on the built-in node missing root url Legacy Apitoken enabled and more Probably anything that uses the class "jenkins-!-destructive-color" in a submit button where the surrounding div has "alert-warning" class

          Ulli Hafner added a comment -

          Isn't this more of a problem of the dark theme plugin? Shouldn't the dark theme correctly adapt the Jenkins color theme here and change the background of the popup? (Sadly, the dark theme plugin does not use Jira, so I can't cross link this issue).

          Ulli Hafner added a comment - Isn't this more of a problem of the dark theme plugin? Shouldn't the dark theme correctly adapt the Jenkins color theme here and change the background of the popup? (Sadly, the dark theme plugin does not use Jira, so I can't cross link this issue).

          Tim Jacomb added a comment -

          > Isn't this more of a problem of the dark theme plugin?

          Yes although it may need core changes.

          I have tried to fix this and I haven't came up with anything good, any help would be appreciated.

          Tim Jacomb added a comment - > Isn't this more of a problem of the dark theme plugin? Yes although it may need core changes. I have tried to fix this and I haven't came up with anything good, any help would be appreciated.

          Basil Crow added a comment -

          There are two distinct but related problems: ① lack of support for this use case in the dark theme plugin (which, as Tim noted above, may also need core changes)—not covered by this ticket—and ② the fact that jenkinsci/jenkins#7364 exposed ① in a situation where it was not previously exposed—which is what this ticket covers. ① is an improvement; ② is a regression. Addressing ① would obviate ②. Reverting jenkinsci/jenkins#7364 would resolve ② (i.e., this ticket) but not ①.

          Basil Crow added a comment - There are two distinct but related problems: ① lack of support for this use case in the dark theme plugin (which, as Tim noted above, may also need core changes)—not covered by this ticket—and ② the fact that jenkinsci/jenkins#7364 exposed ① in a situation where it was not previously exposed—which is what this ticket covers. ① is an improvement; ② is a regression. Addressing ① would obviate ②. Reverting jenkinsci/jenkins#7364 would resolve ② (i.e., this ticket) but not ①.

          Ulli Hafner added a comment -

          I see. Since these popups are ugly and broken anyway (the buttons overlap the content text, layout is poor, no simple API for developers) we should not invest much time on making them compatible with the dark theme. It would make more sense to replace them with something better suited and compatible to the new UI changes. 

          So it would be simpler to revert the PR and wait for someone rewriting this UI elements.

           

          Ulli Hafner added a comment - I see. Since these popups are ugly and broken anyway (the buttons overlap the content text, layout is poor, no simple API for developers) we should not invest much time on making them compatible with the dark theme. It would make more sense to replace them with something better suited and compatible to the new UI changes.  So it would be simpler to revert the PR and wait for someone rewriting this UI elements.  

          > I have tried to fix this and I haven't came up with anything good, any help would be appreciated.

          Same here :/
          I think we should revert the PR for now. Although there is an open core PR to create a separate "dismiss" component, we could look into supporting in the dark theme plugin in the future.

          Filed https://github.com/jenkinsci/jenkins/pull/7556

          Alexander Brandes added a comment - > I have tried to fix this and I haven't came up with anything good, any help would be appreciated. Same here :/ I think we should revert the PR for now. Although there is an open core PR to create a separate "dismiss" component, we could look into supporting in the dark theme plugin in the future. Filed https://github.com/jenkinsci/jenkins/pull/7556

            notmyfault Alexander Brandes
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: