Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-70239

Case sensitivity on emails

XMLWordPrintable

      If an E-Mail-Address of a author appears once as 'theauthor@mailto.me' and once as 'TheAuthor@mailto.me' is get counts as two authors instead of one.

          [JENKINS-70239] Case sensitivity on emails

          Jagruti added a comment - - edited

          Hi,

          I found the email being set here.

          The issue says that the email ids are case sensitive.

          To make them insensitive, do I have to set the email id in say lowercase only?

          My solution would be: 

          lineBlame.setEmail(emailByLine.get(line).toLowerCase());

          I am not really aware of the code base.

          I would appreciate your guidance here.

          Jagruti added a comment - - edited Hi, I found the email being set here. The issue says that the email ids are case sensitive. To make them insensitive, do I have to set the email id in say lowercase only? My solution would be:  lineBlame.setEmail(emailByLine.get(line).toLowerCase()); I am not really aware of the code base. I would appreciate your guidance here.

          Ulli Hafner added a comment -

          Your solution will help only partially. A fix is much simpler:

          https://github.com/jenkinsci/forensics-api-plugin/blob/master/src/main/java/io/jenkins/plugins/forensics/miner/CommitStatistics.java#L188

          This line will count the number of different authors. This needs to be made case insensitive.

          Ulli Hafner added a comment - Your solution will help only partially. A fix is much simpler: https://github.com/jenkinsci/forensics-api-plugin/blob/master/src/main/java/io/jenkins/plugins/forensics/miner/CommitStatistics.java#L188 This line will count the number of different authors. This needs to be made case insensitive.

          Ulli Hafner added a comment -

          timsch Where exactly did you see the problem? Only in the commit statistics table? Or are there different places?

          Ulli Hafner added a comment - timsch Where exactly did you see the problem? Only in the commit statistics table? Or are there different places?

          Udit added a comment -

          Is this bug resolved or is still open?

          Udit added a comment - Is this bug resolved or is still open?

          Ulli Hafner added a comment -

          The bug is still open, I'm not sure if jagrutiti still plans to work on it.

          Ulli Hafner added a comment - The bug is still open, I'm not sure if jagrutiti still plans to work on it.

          Udit added a comment -

          Okay, I'll wait for a day till she comes back to this issue

          Udit added a comment - Okay, I'll wait for a day till she comes back to this issue

          Jagruti added a comment -

          Hi,

          I missed this issue due to vacation. I will take it up.

          Jagruti added a comment - Hi, I missed this issue due to vacation. I will take it up.

          Kalle Niemitalo added a comment - - edited

          Git matches email addresses in .mailmap files case-insensitively, according to the gitmailmap documentation. I think it is correct to do the same in Jenkins when reporting about Git commits. But I don't know whether e.g. Mercurial has a different policy.

          For Internet email, RFC 5321 (SMTP) §2.4 (General Syntax Principles and Transaction Model) says "The local-part of a mailbox MUST BE treated as case sensitive." If Jenkins sends email to an author or to a committer, then it must preserve the case of the local-part. But this does not apply if the address is merely displayed and no email is sent.

          Kalle Niemitalo added a comment - - edited Git matches email addresses in .mailmap files case-insensitively, according to the gitmailmap documentation. I think it is correct to do the same in Jenkins when reporting about Git commits. But I don't know whether e.g. Mercurial has a different policy. For Internet email, RFC 5321 (SMTP) §2.4 (General Syntax Principles and Transaction Model) says "The local-part of a mailbox MUST BE treated as case sensitive." If Jenkins sends email to an author or to a committer, then it must preserve the case of the local-part. But this does not apply if the address is merely displayed and no email is sent.

            jagrutiti Jagruti
            timsch Tim Schlüter
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: