• Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • job-dsl-plugin
    • None

      We're currently introducing JobDSL plugin for configuration purposes. We have found, that when we use the "folder" declaration, any custom settings made in these folders are trashed and reset to "unconfigured" state. This affects at least:

      • Icons set by "CustomFolderIconPlugin"
      • Views defined for the folders

      maybe more settings are affected. Since JobDSL does not support configuring these parameters at all, I would expect it to leave these settings alone if they exist. Even in case it would support them one day, I would generally assume, that any config setting in existing items, not explicitly defined in JobDSL scripts is not touched by JobDSL plugin and left as is.

          [JENKINS-70264] JobDSL trashes existing folder configuration

          Daniel Krämer added a comment - - edited

          https://github.com/jenkinsci/job-dsl-plugin/pull/1258 should fix this - at least for the CustomFolderIcon Plugin.

          Daniel Krämer added a comment - - edited https://github.com/jenkinsci/job-dsl-plugin/pull/1258 should fix this - at least for the CustomFolderIcon Plugin.

          Vanio Begic added a comment -

          Hello jamietanna should this really be a requirement on plugin behavior? I would expect that definitions of items coming from DSL to be "complete" in the sense that they override any configurations done in any other fashion. This would be in accordance with other tools for declarative configuration management. 

           

          In short, I really do not see why it would be problematic for the plugin to override other manually performed configurations. The problem does arise though if multiple Job DSL jobs define the same object. Is that the reason why this is considered to be a  desirable feature?

          Vanio Begic added a comment - Hello jamietanna should this really be a requirement on plugin behavior? I would expect that definitions of items coming from DSL to be "complete" in the sense that they override any configurations done in any other fashion. This would be in accordance with other tools for declarative configuration management.    In short, I really do not see why it would be problematic for the plugin to override other manually performed configurations. The problem does arise though if multiple Job DSL jobs define the same object. Is that the reason why this is considered to be a  desirable feature?

            jamietanna Jamie Tanna
            amesser Andreas Messer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: