• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Component/s: core
• Labels:

  • regression
  • ux

1. 

   2.370.png

   178 kB

   2023-03-14 11:11

2. 

   2.369.png

   196 kB

   2023-03-14 11:11

[JENKINS-70794] Plugins without URL have an invalid link (regression in 2.370)

Daniel Beck created issue - 2023-03-14 11:11

Daniel Beck made changes - 2023-03-14 11:12

Description

Original: [https://github.com/jenkinsci/jenkins/blob/e4cba7380f25cff2b89edc951d84c8103994caac/core/src/main/java/hudson/PluginManager.java#L1472-L1476] means that there's an empty string as URL, resulting in a value-less {{href}} attribute (hbs), rather than no {{href}} attribute (Jelly). Firefox at least interprets this as a link to the current page. It wasn't great before (there was still a hover state), but it's worse now. Screenshots with a patched {{matrix-auth}} metadata, not having a {{wiki}} entry.

New: {{wiki}} in update site metadata is optional. It's just that update-center2 always links to plugins.jenkins.io for public plugins, and lets that site deal with lack of documentation URLs. [https://github.com/jenkinsci/jenkins/blob/e4cba7380f25cff2b89edc951d84c8103994caac/core/src/main/java/hudson/PluginManager.java#L1472-L1476] means that there's an empty string as URL, resulting in a value-less {{href}} attribute (hbs), rather than no {{href}} attribute (Jelly). Firefox at least interprets this as a link to the current page. It wasn't great before (there was still a hover state), but it's worse now. Screenshots with a patched {{matrix-auth}} metadata, not having a {{wiki}} entry.

Basil Crow made changes - 2023-04-06 21:36

Summary

Original: Plugins without URL have an invalid link

New: Plugins without URL have an invalid link (regression in 2.370)