-
Bug
-
Resolution: Fixed
-
Minor
-
None
-
jenkins 2.387.1
warnings-ng 10.0.2
we are using warnings-ng plugin on jenkins to visualize the result of IntelliJ-Idea-Inspections. Our observation:
- jobs, which reported inspection-results with an older version of the plugin, still allow sorting for module/package/file/categories/issues.
- jobs, which report inspection-results with version 10.0.2 of the plugin, don't allow sorting for module anymore - only for package/file/categories/issues.
- the provided information (input for the plugin as xml-file) is identical.
Problem imho is in the file idea-outstanding-issues.xml,
old (with ability to sort for modules):
<analysisReport plugin="analysis-model-api@10.21.0"> ... <subReports> <analysisReport> ... <elements class="linked-hash-set"> <issue> ... {color:#de350b} <moduleName>base-ls</moduleName>{color}
new (without ability for sort for modules):
<analysisReport plugin="analysis-model-api@11.0.0"> ... <subReports> <analysisReport> ... <elements class="linked-hash-set"> <issue> ... {color:#de350b} <moduleName>-</moduleName>{color}
the module probably gets parsed from the provided xml-files for each entry:
<problems> <problem> ... <module>KIXCustomer.base-ls.main</module> ... </problem>
assumptions:
- as the module information is '-' for all entries, sorting for modules is not a valid option, therefore there is no button.
- problem is in parsing module-information from input file.
we would be glad, if sorting for modules is possible again.
- links to
[JENKINS-70801] Module information not available anymore
oliva imlinga
added a comment - additionally, a snipplet from jenkins-output for a buildrun with the old version of the plugin and findings for different modules (resulting in the ability to sort per module in the UI):
22:37:08 [IntelliJ IDEA Inspections] Searching for all files in 'c:\Jenkins\FGI\dev\3.22\agreeSB_3.22' that match the pattern '**/build/inspectionResult/*.xml' 22:37:08 [IntelliJ IDEA Inspections] -> found 1 file 22:37:08 [IntelliJ IDEA Inspections] Successfully parsed file c:\Jenkins\FGI\dev\3.22\agreeSB_3.22\build\inspectionResult\RedundantSuppression.xml 22:37:08 [IntelliJ IDEA Inspections] -> found 17 issues (skipped 0 duplicates) 22:37:11 [IntelliJ IDEA Inspections] Post processing issues on 'sbs648' with source code encoding 'UTF-8' 22:37:11 [IntelliJ IDEA Inspections] Creating SCM blamer to obtain author and commit information for affected files 22:37:11 [IntelliJ IDEA Inspections] -> No blamer installed yet. You need to install the 'git-forensics' plugin to enable blaming for Git. 22:37:11 [IntelliJ IDEA Inspections] Resolving file names for all issues in workspace 'c:\Jenkins\FGI\dev\3.22\agreeSB_3.22' 22:37:11 [IntelliJ IDEA Inspections] -> resolved paths in source directory (9 found, 0 not found) 22:37:11 [IntelliJ IDEA Inspections] Resolving module names from module definitions (build.xml, pom.xml, or Manifest.mf files) 22:37:11 [IntelliJ IDEA Inspections] -> resolved module names for 17 issues 22:37:11 [IntelliJ IDEA Inspections] Resolving package names (or namespaces) by parsing the affected files 22:37:11 [IntelliJ IDEA Inspections] -> resolved package names of 9 affected files 22:37:11 [IntelliJ IDEA Inspections] No filter has been set, publishing all 17 issues 22:37:11 [IntelliJ IDEA Inspections] Creating fingerprints for all affected code blocks to track issues over different builds 22:37:11 [IntelliJ IDEA Inspections] -> created fingerprints for 17 issues (skipped 0 issues) 22:37:11 [IntelliJ IDEA Inspections] Copying affected files to Jenkins' build folder '/var/lib/jenkins/jobs/KIXCustomer2AnalyseIDEABuild_FGI_3.22_agreeSB_3.22/builds/6/files-with-issues' 22:37:11 [IntelliJ IDEA Inspections] -> 0 copied, 17 not in workspace, 0 not-found, 0 with I/O error 22:37:11 [IntelliJ IDEA Inspections] Repository miner is not configured, skipping repository mining 22:37:11 [IntelliJ IDEA Inspections] Reference build recorder is not configured 22:37:11 [IntelliJ IDEA Inspections] Obtaining reference build from same job (KIXCustomer2AnalyseIDEABuild_FGI_3.22_agreeSB_3.22) 22:37:11 [IntelliJ IDEA Inspections] No valid reference build found that meets the criteria (NO_JOB_FAILURE - SUCCESSFUL_QUALITY_GATE) 22:37:11 [IntelliJ IDEA Inspections] All reported issues will be considered outstanding 22:37:11 [IntelliJ IDEA Inspections] Evaluating quality gates 22:37:11 [IntelliJ IDEA Inspections] -> WARNING - Total (any severity): 17 - Quality Gate: 1 22:37:11 [IntelliJ IDEA Inspections] -> Some quality gates have been missed: overall result is WARNING 22:37:11 [IntelliJ IDEA Inspections] Health report is disabled - skipping 22:37:11 [IntelliJ IDEA Inspections] Created analysis result for 17 issues (found 0 new issues, fixed 0 issues) 22:37:11 [IntelliJ IDEA Inspections] Attaching ResultAction with ID 'idea' to build 'KIXCustomer2AnalyseIDEABuild_FGI_3.22_agreeSB_3.22 #6'.
oliva imlinga
added a comment - additionally, a snipplet from jenkins-output for a buildrun with the old version of the plugin and findings for different modules (resulting in the ability to sort per module in the UI):
22:37:08 [IntelliJ IDEA Inspections] Searching for all files in 'c:\Jenkins\FGI\dev\3.22\agreeSB_3.22' that match the pattern '**/build/inspectionResult/*.xml'
22:37:08 [IntelliJ IDEA Inspections] -> found 1 file
22:37:08 [IntelliJ IDEA Inspections] Successfully parsed file c:\Jenkins\FGI\dev\3.22\agreeSB_3.22\build\inspectionResult\RedundantSuppression.xml
22:37:08 [IntelliJ IDEA Inspections] -> found 17 issues (skipped 0 duplicates)
22:37:11 [IntelliJ IDEA Inspections] Post processing issues on 'sbs648' with source code encoding 'UTF-8'
22:37:11 [IntelliJ IDEA Inspections] Creating SCM blamer to obtain author and commit information for affected files
22:37:11 [IntelliJ IDEA Inspections] -> No blamer installed yet. You need to install the 'git-forensics' plugin to enable blaming for Git.
22:37:11 [IntelliJ IDEA Inspections] Resolving file names for all issues in workspace 'c:\Jenkins\FGI\dev\3.22\agreeSB_3.22'
22:37:11 [IntelliJ IDEA Inspections] -> resolved paths in source directory (9 found, 0 not found)
22:37:11 [IntelliJ IDEA Inspections] Resolving module names from module definitions (build.xml, pom.xml, or Manifest.mf files)
22:37:11 [IntelliJ IDEA Inspections] -> resolved module names for 17 issues
22:37:11 [IntelliJ IDEA Inspections] Resolving package names (or namespaces) by parsing the affected files
22:37:11 [IntelliJ IDEA Inspections] -> resolved package names of 9 affected files
22:37:11 [IntelliJ IDEA Inspections] No filter has been set, publishing all 17 issues
22:37:11 [IntelliJ IDEA Inspections] Creating fingerprints for all affected code blocks to track issues over different builds
22:37:11 [IntelliJ IDEA Inspections] -> created fingerprints for 17 issues (skipped 0 issues)
22:37:11 [IntelliJ IDEA Inspections] Copying affected files to Jenkins ' build folder ' / var /lib/jenkins/jobs/KIXCustomer2AnalyseIDEABuild_FGI_3.22_agreeSB_3.22/builds/6/files-with-issues'
22:37:11 [IntelliJ IDEA Inspections] -> 0 copied, 17 not in workspace, 0 not-found, 0 with I/O error
22:37:11 [IntelliJ IDEA Inspections] Repository miner is not configured, skipping repository mining
22:37:11 [IntelliJ IDEA Inspections] Reference build recorder is not configured
22:37:11 [IntelliJ IDEA Inspections] Obtaining reference build from same job (KIXCustomer2AnalyseIDEABuild_FGI_3.22_agreeSB_3.22)
22:37:11 [IntelliJ IDEA Inspections] No valid reference build found that meets the criteria (NO_JOB_FAILURE - SUCCESSFUL_QUALITY_GATE)
22:37:11 [IntelliJ IDEA Inspections] All reported issues will be considered outstanding
22:37:11 [IntelliJ IDEA Inspections] Evaluating quality gates
22:37:11 [IntelliJ IDEA Inspections] -> WARNING - Total (any severity): 17 - Quality Gate: 1
22:37:11 [IntelliJ IDEA Inspections] -> Some quality gates have been missed: overall result is WARNING
22:37:11 [IntelliJ IDEA Inspections] Health report is disabled - skipping
22:37:11 [IntelliJ IDEA Inspections] Created analysis result for 17 issues (found 0 new issues, fixed 0 issues)
22:37:11 [IntelliJ IDEA Inspections] Attaching ResultAction with ID 'idea' to build 'KIXCustomer2AnalyseIDEABuild_FGI_3.22_agreeSB_3.22 #6' .
oliva imlinga
added a comment - just tried to do some research for the issue and cloned the subproject 'analysis-model'.
it looks like the relevant code is: edu.hm.hafner.analysis.parser.IdeaInspectionParser#parseProblems. it seems that IssueBuilder#setModuleName is neither called in the working version (10.21.0) nor in the not-working version (11.0.0) - so i don't have any clue, how this did ever work - probably there has been some magic for setting the modulename anywhere else ? 
if there should not be any magic elsewhere, probably just mapping the module from idea's outputfile will do the trick:
...
.setModuleName(StringEscapeUtils.unescapeXml(getChildValue(element, "module")))
...
oliva imlinga
added a comment - just tried to do some research for the issue and cloned the subproject 'analysis-model'.
it looks like the relevant code is: edu.hm.hafner.analysis.parser.IdeaInspectionParser#parseProblems. it seems that IssueBuilder#setModuleName is neither called in the working version (10.21.0) nor in the not-working version (11.0.0) - so i don't have any clue, how this did ever work - probably there has been some magic for setting the modulename anywhere else ?
if there should not be any magic elsewhere, probably just mapping the module from idea's outputfile will do the trick:
...
.setModuleName(StringEscapeUtils.unescapeXml(getChildValue(element, "module" )))
...
It is called in ModuleResolver in analysis-model. Somehow the module is parsed to empty. Which module type are you using?
These are supported:
new AntModuleDetector(factory), new GradleModuleDetector(factory), new MavenModuleDetector(factory), new OsgiModuleDetector(factory)
oliva imlinga
added a comment - Hi Ulli,
we have a gradle-build (with build.gradle.kts-files), so i think that GradleModuleDetector should fetch the module name.
i'm ouf-of-office tomorrow - maybe i'll be able to debug 'edu.hm.hafner.analysis.ModuleResolver#run' a bit on tuesday.
lg, Oliver
oliva imlinga
added a comment - Hi Ulli,
we have a gradle-build (with build.gradle.kts-files), so i think that GradleModuleDetector should fetch the module name.
i'm ouf-of-office tomorrow - maybe i'll be able to debug 'edu.hm.hafner.analysis.ModuleResolver#run' a bit on tuesday.
lg, Oliver Hi Ulli,
maybe the problem is:
as no rootProject is detected in our settings.gradle.kts (edu.hm.hafner.analysis.GradleModuleDetector#parseGradleSettings)
no module-mappings are collected (edu.hm.hafner.analysis.AbstractModuleDetector#addMapping)
and therefore no module-names are guessed (edu.hm.hafner.analysis.ModuleDetector#guessModuleName, prefixes are empty)
our definition within the settings.gradle.kts: rootProject.name = "our_name"
when debugging locally:
- only if i put the definition in the first line of settings.gradle.kts it seems to match. if there e.g. is a blank line before, it doesn't match the rootProject-name anymore.
- i'm not quite sure, why this is. our system: windows, linebreaks in the settings-file include cr/lf. if i remove the leading '^' of the used regex, the rootProject-name is matched in all lines.
what i'd be interested in (as i still don't get module names on jenkins again if i put 'rootProject.name' as first line of the settings-file): can you tell the reason, why the module-information is not taken from IntelliJ's output file (<module>...</module>), but tried to be reconstructed afterwards from filenames / module information ?
best regards,
oliver
oliva imlinga
added a comment - - edited Hi Ulli,
maybe the problem is:
as no rootProject is detected in our settings.gradle.kts (edu.hm.hafner.analysis.GradleModuleDetector#parseGradleSettings)
no module-mappings are collected (edu.hm.hafner.analysis.AbstractModuleDetector#addMapping)
and therefore no module-names are guessed (edu.hm.hafner.analysis.ModuleDetector#guessModuleName, prefixes are empty)
our definition within the settings.gradle.kts: rootProject.name = "our_name"
when debugging locally:
only if i put the definition in the first line of settings.gradle.kts it seems to match. if there e.g. is a blank line before, it doesn't match the rootProject-name anymore.
i'm not quite sure, why this is. our system: windows, linebreaks in the settings-file include cr/lf. if i remove the leading '^' of the used regex, the rootProject-name is matched in all lines.
what i'd be interested in (as i still don't get module names on jenkins again if i put 'rootProject.name' as first line of the settings-file): can you tell the reason, why the module-information is not taken from IntelliJ's output file (<module>...</module>), but tried to be reconstructed afterwards from filenames / module information ?
best regards,
oliver as no rootProject is detected in our settings.gradle.kts (edu.hm.hafner.analysis.GradleModuleDetector#parseGradleSettings)
no module-mappings are collected (edu.hm.hafner.analysis.AbstractModuleDetector#addMapping)
and therefore no module-names are guessed (edu.hm.hafner.analysis.ModuleDetector#guessModuleName, prefixes are empty)our definition within the settings.gradle.kts: rootProject.name = "our_name"
when debugging locally:
only if i put the definition in the first line of settings.gradle.kts it seems to match. if there e.g. is a blank line before, it doesn't match the rootProject-name anymore.
i'm not quite sure, why this is. our system: windows, linebreaks in the settings-file include cr/lf. if i remove the leading '^' of the used regex, the rootProject-name is matched in all lines.
Can you attach a copy of your file (if required anonymized version)?
what i'd be interested in (as i still don't get module names on jenkins again if i put 'rootProject.name' as first line of the settings-file): can you tell the reason, why the module-information is not taken from IntelliJ's output file (<module>...</module>), but tried to be reconstructed afterwards from filenames / module information ?
It is simply not implemented by the author of the parser. Feel free to provide a PR!
i used this file for local debugging:
@"it is simply not implemented by the author of the parser. Feel free to provide a PR!":
oliva imlinga
added a comment - - edited i used this file for local debugging:
settings.gradle.kts
@"it is simply not implemented by the author of the parser. Feel free to provide a PR!":
=> https://github.com/jenkinsci/analysis-model/pull/911 oliva imlinga
added a comment - Hi Uli,
thanks for deploying the new version 10.0.1 with the PR from above.
=> we are able to sort for module-names again 
lg, Oliver
oliva imlinga
added a comment - Hi Uli,
thanks for deploying the new version 10.0.1 with the PR from above.
=> we are able to sort for module-names again
lg, Oliver oliva imlinga
added a comment - verified with our jenkins installation and version 10.0.1 of warnings-ng plugin (which includes the latest version of analysis-model with the specified merge-request).
oliva imlinga
added a comment - verified with our jenkins installation and version 10.0.1 of warnings-ng plugin (which includes the latest version of analysis-model with the specified merge-request). 
here is a snipplet from the output of one buildrun.
btw. it seems, that the same information is printed several times (starting with 'Searching for all files in '....' that match the pattern '...').